[PATCH 9/9] regulator: bd71837: Build BD71837 regulator driver

[PATCH 9/9] regulator: bd71837: Build BD71837 regulator driver

[Matti Vaittinen]

Configurations and Makefile for BD71837 regulator driver

Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
 drivers/regulator/Kconfig  | 11 +++++++++++
 drivers/regulator/Makefile |  1 +
 2 files changed, 12 insertions(+)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 097f61784a7d..139f4b53fea0 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -180,6 +180,17 @@ config REGULATOR_BCM590XX
 	  BCM590xx PMUs. This will enable support for the software
 	  controllable LDO/Switching regulators.
 
+config REGULATOR_BD71837
+	tristate "ROHM BD71837 Power Regulator"
+	depends on MFD_BD71837
+	help
+	  This driver supports voltage regulators on ROHM BD71837 PMIC.
+	  This will enable support for the software controllable buck
+	  and LDO regulators.
+
+	  This driver can also be built as a module. If so, the module
+	  will be called bd71837-regulator.
+
 config REGULATOR_BD9571MWV
 	tristate "ROHM BD9571MWV Regulators"
 	depends on MFD_BD9571MWV
diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 590674fbecd7..1b4d8ec416c2 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -27,6 +27,7 @@ obj-$(CONFIG_REGULATOR_AS3711) += as3711-regulator.o
 obj-$(CONFIG_REGULATOR_AS3722) += as3722-regulator.o
 obj-$(CONFIG_REGULATOR_AXP20X) += axp20x-regulator.o
 obj-$(CONFIG_REGULATOR_BCM590XX) += bcm590xx-regulator.o
+obj-$(CONFIG_REGULATOR_BD71837) += bd71837-regulator.o
 obj-$(CONFIG_REGULATOR_BD9571MWV) += bd9571mwv-regulator.o
 obj-$(CONFIG_REGULATOR_DA903X)	+= da903x.o
 obj-$(CONFIG_REGULATOR_DA9052)	+= da9052-regulator.o
-- 
2.14.3

Re: [PATCH 9/9] regulator: bd71837: Build BD71837 regulator driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

On Thu, May 24, 2018 at 09:01:14AM +0300, Matti Vaittinen wrote:
> Configurations and Makefile for BD71837 regulator driver
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
>  drivers/regulator/Kconfig  | 11 +++++++++++
>  drivers/regulator/Makefile |  1 +
>  2 files changed, 12 insertions(+)

Just squash this into the single patch adding the driver, it makes life
easier.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: [PATCH 9/9] regulator: bd71837: Build BD71837 regulator driver

[Vaittinen, Matti]

> On Thu, May 24, 2018 at 09:01:14AM +0300, Matti Vaittinen wrote:
> > Configurations and Makefile for BD71837 regulator driver
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> >  drivers/regulator/Kconfig  | 11 +++++++++++
> >  drivers/regulator/Makefile |  1 +
> >  2 files changed, 12 insertions(+)
>
> Just squash this into the single patch adding the driver, it makes life
> easier.

Will do. I was wondering if it is nicer to have smaller patches and thus
decided to split this but if it is easier to read them in one patch
- no problem.

Br,
    Matti Vaittinen

RE: [PATCH 9/9] regulator: bd71837: Build BD71837 regulator driver

[Vaittinen, Matti]

=0A=
=0A=
> On Thu, May 24, 2018 at 09:01:14AM +0300, Matti Vaittinen wrote:=0A=
> > Configurations and Makefile for BD71837 regulator driver=0A=
> >=0A=
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>=0A=
> > ---=0A=
> >  drivers/regulator/Kconfig  | 11 +++++++++++=0A=
> >  drivers/regulator/Makefile |  1 +=0A=
> >  2 files changed, 12 insertions(+)=0A=
>=0A=
> Just squash this into the single patch adding the driver, it makes life=
=0A=
> easier.=0A=
=0A=
Will do. I was wondering if it is nicer to have smaller patches and thus=0A=
decided to split this but if it is easier to read them in one patch=0A=
- no problem.=0A=
=0A=
Br,=0A=
    Matti Vaittinen=

[RFC PATCH] regulator: bd71837: buck_7_volts[] can be static

[kbuild test robot]

Fixes: 9ebaeaf21446 ("regulator: bd71837: Build BD71837 regulator driver")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 bd71837-regulator.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/bd71837-regulator.c b/drivers/regulator/bd71837-regulator.c
index e6c3fa7..d48b71c 100644
--- a/drivers/regulator/bd71837-regulator.c
+++ b/drivers/regulator/bd71837-regulator.c
@@ -207,7 +207,7 @@ static const struct regulator_linear_range bd71837_buck6_voltage_ranges[] = {
  * 110 = 1.95V
  * 111 = 1.995V
  */
-const unsigned int buck_7_volts[] = {
+static const unsigned int buck_7_volts[] = {
 	1605000, 1695000, 1755000, 1800000, 1845000, 1905000, 1950000, 1995000
 };
 
@@ -232,7 +232,7 @@ static const struct regulator_linear_range bd71837_ldo1_voltage_ranges[] = {
  * LDO2
  * 0.8 or 0.9V
  */
-const unsigned int ldo_2_volts[] = {
+static const unsigned int ldo_2_volts[] = {
 	900000, 800000
 };
 

Re: [PATCH 9/9] regulator: bd71837: Build BD71837 regulator driver

[kbuild test robot]

Hi Matti,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on ljones-mfd/for-mfd-next]
[also build test WARNING on v4.17-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/mfd-regulator-clk-bd71837-ROHM-BD71837-PMIC-driver/20180526-192351
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation