* [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests
@ 2019-04-24 9:45 ` Thomas Huth
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2019-04-24 9:45 UTC (permalink / raw)
To: qemu-devel, Stefan Berger; +Cc: pbonzini, lvivier
Since we do not use gtester anymore (which had a bug here),
we can now use g_test_skip() to mark skipped tests.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/tpm-tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
index 582ec0cfd4..e640777aa9 100644
--- a/tests/tpm-tests.c
+++ b/tests/tpm-tests.c
@@ -22,7 +22,7 @@ static bool
tpm_test_swtpm_skip(void)
{
if (!tpm_util_swtpm_has_tpm2()) {
- g_test_message("swtpm not in PATH or missing --tpm2 support");
+ g_test_skip("swtpm not in PATH or missing --tpm2 support");
return true;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests
@ 2019-04-24 9:45 ` Thomas Huth
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Huth @ 2019-04-24 9:45 UTC (permalink / raw)
To: qemu-devel, Stefan Berger; +Cc: lvivier, pbonzini
Since we do not use gtester anymore (which had a bug here),
we can now use g_test_skip() to mark skipped tests.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/tpm-tests.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
index 582ec0cfd4..e640777aa9 100644
--- a/tests/tpm-tests.c
+++ b/tests/tpm-tests.c
@@ -22,7 +22,7 @@ static bool
tpm_test_swtpm_skip(void)
{
if (!tpm_util_swtpm_has_tpm2()) {
- g_test_message("swtpm not in PATH or missing --tpm2 support");
+ g_test_skip("swtpm not in PATH or missing --tpm2 support");
return true;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests
@ 2019-04-24 10:00 ` Marc-André Lureau
0 siblings, 0 replies; 7+ messages in thread
From: Marc-André Lureau @ 2019-04-24 10:00 UTC (permalink / raw)
To: Thomas Huth; +Cc: QEMU, Stefan Berger, Laurent Vivier, Paolo Bonzini
On Wed, Apr 24, 2019 at 11:49 AM Thomas Huth <thuth@redhat.com> wrote:
>
> Since we do not use gtester anymore (which had a bug here),
> we can now use g_test_skip() to mark skipped tests.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/tpm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> index 582ec0cfd4..e640777aa9 100644
> --- a/tests/tpm-tests.c
> +++ b/tests/tpm-tests.c
> @@ -22,7 +22,7 @@ static bool
> tpm_test_swtpm_skip(void)
> {
> if (!tpm_util_swtpm_has_tpm2()) {
> - g_test_message("swtpm not in PATH or missing --tpm2 support");
> + g_test_skip("swtpm not in PATH or missing --tpm2 support");
> return true;
> }
>
> --
> 2.21.0
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests
@ 2019-04-24 10:00 ` Marc-André Lureau
0 siblings, 0 replies; 7+ messages in thread
From: Marc-André Lureau @ 2019-04-24 10:00 UTC (permalink / raw)
To: Thomas Huth; +Cc: Laurent Vivier, Paolo Bonzini, QEMU, Stefan Berger
On Wed, Apr 24, 2019 at 11:49 AM Thomas Huth <thuth@redhat.com> wrote:
>
> Since we do not use gtester anymore (which had a bug here),
> we can now use g_test_skip() to mark skipped tests.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/tpm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> index 582ec0cfd4..e640777aa9 100644
> --- a/tests/tpm-tests.c
> +++ b/tests/tpm-tests.c
> @@ -22,7 +22,7 @@ static bool
> tpm_test_swtpm_skip(void)
> {
> if (!tpm_util_swtpm_has_tpm2()) {
> - g_test_message("swtpm not in PATH or missing --tpm2 support");
> + g_test_skip("swtpm not in PATH or missing --tpm2 support");
> return true;
> }
>
> --
> 2.21.0
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests
2019-04-24 9:45 ` Thomas Huth
(?)
(?)
@ 2019-04-24 10:16 ` Philippe Mathieu-Daudé
-1 siblings, 0 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-04-24 10:16 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Stefan Berger; +Cc: lvivier, pbonzini
On 4/24/19 11:45 AM, Thomas Huth wrote:
> Since we do not use gtester anymore (which had a bug here),
> we can now use g_test_skip() to mark skipped tests.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/tpm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> index 582ec0cfd4..e640777aa9 100644
> --- a/tests/tpm-tests.c
> +++ b/tests/tpm-tests.c
> @@ -22,7 +22,7 @@ static bool
> tpm_test_swtpm_skip(void)
> {
> if (!tpm_util_swtpm_has_tpm2()) {
> - g_test_message("swtpm not in PATH or missing --tpm2 support");
> + g_test_skip("swtpm not in PATH or missing --tpm2 support");
> return true;
> }
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests
@ 2019-04-28 14:14 ` Stefan Berger
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Berger @ 2019-04-28 14:14 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: pbonzini, lvivier
On 4/24/19 5:45 AM, Thomas Huth wrote:
> Since we do not use gtester anymore (which had a bug here),
> we can now use g_test_skip() to mark skipped tests.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
> tests/tpm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> index 582ec0cfd4..e640777aa9 100644
> --- a/tests/tpm-tests.c
> +++ b/tests/tpm-tests.c
> @@ -22,7 +22,7 @@ static bool
> tpm_test_swtpm_skip(void)
> {
> if (!tpm_util_swtpm_has_tpm2()) {
> - g_test_message("swtpm not in PATH or missing --tpm2 support");
> + g_test_skip("swtpm not in PATH or missing --tpm2 support");
> return true;
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests
@ 2019-04-28 14:14 ` Stefan Berger
0 siblings, 0 replies; 7+ messages in thread
From: Stefan Berger @ 2019-04-28 14:14 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: lvivier, pbonzini
On 4/24/19 5:45 AM, Thomas Huth wrote:
> Since we do not use gtester anymore (which had a bug here),
> we can now use g_test_skip() to mark skipped tests.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
> tests/tpm-tests.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/tpm-tests.c b/tests/tpm-tests.c
> index 582ec0cfd4..e640777aa9 100644
> --- a/tests/tpm-tests.c
> +++ b/tests/tpm-tests.c
> @@ -22,7 +22,7 @@ static bool
> tpm_test_swtpm_skip(void)
> {
> if (!tpm_util_swtpm_has_tpm2()) {
> - g_test_message("swtpm not in PATH or missing --tpm2 support");
> + g_test_skip("swtpm not in PATH or missing --tpm2 support");
> return true;
> }
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-04-28 14:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-24 9:45 [Qemu-devel] [PATCH] tests/tpm-tests: Use g_test_skip() to mark skipped tests Thomas Huth
2019-04-24 9:45 ` Thomas Huth
2019-04-24 10:00 ` Marc-André Lureau
2019-04-24 10:00 ` Marc-André Lureau
2019-04-24 10:16 ` Philippe Mathieu-Daudé
2019-04-28 14:14 ` Stefan Berger
2019-04-28 14:14 ` Stefan Berger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.