From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>, kristian@klausen.dk
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] systemd: Add tpm2 PACKAGECONFIG
Date: Sat, 18 Sep 2021 10:17:31 +0100 [thread overview]
Message-ID: <042c07228f93912207b7d0616d99dbe0a1e6bfb6.camel@linuxfoundation.org> (raw)
In-Reply-To: <YUS4fOY2J2hoAsxx@piout.net>
On Fri, 2021-09-17 at 17:47 +0200, Alexandre Belloni wrote:
> On 15/09/2021 13:31:07+0200, Kristian Klausen via lists.openembedded.org wrote:
> > Den Wed, Sep 15, 2021 at 12:48:18 +0200 skrev Quentin Schulz:
> > > Hi Kristian,
> > >
> > > On Wed, Sep 15, 2021 at 12:23:08PM +0200, Kristian Klausen via lists.openembedded.org wrote:
> > > > The TPM2 support is used, among other things, for unlocking encrypted
> > > > volumes.
> > > >
> > > > Signed-off-by: Kristian Klausen <kristian@klausen.dk>
> > > > ---
> > > > meta/recipes-core/systemd/systemd_249.3.bb | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/meta/recipes-core/systemd/systemd_249.3.bb b/meta/recipes-core/systemd/systemd_249.3.bb
> > > > index c027b88fd6..f8c85dabf0 100644
> > > > --- a/meta/recipes-core/systemd/systemd_249.3.bb
> > > > +++ b/meta/recipes-core/systemd/systemd_249.3.bb
> > > > @@ -128,6 +128,7 @@ PACKAGECONFIG[bzip2] = "-Dbzip2=true,-Dbzip2=false,bzip2"
> > > > PACKAGECONFIG[cgroupv2] = "-Ddefault-hierarchy=unified,-Ddefault-hierarchy=hybrid"
> > > > PACKAGECONFIG[coredump] = "-Dcoredump=true,-Dcoredump=false"
> > > > PACKAGECONFIG[cryptsetup] = "-Dlibcryptsetup=true,-Dlibcryptsetup=false,cryptsetup,,cryptsetup"
> > > > +PACKAGECONFIG[tpm2] = "-Dtpm2=true,-Dtpm2=false,tpm2-tss,tpm2-tss libtss2 libtss2-tcti-device"
> > >
> > > Shouldn't the RDEPENDS part of the PACKAGECONFIG be pulled in
> > > automatically by Bitbake since I assume the libs they contained are used
> > > by the linker for systemd?
> > >
> > > Also looking at the tpm2-tss recipe, I'm not sure there's a package
> > > named libtss2-tcti-device?
> >
> > Are we looking at the same recipe? It is defined in
> > tpm2-tss_3.0.3.bb[1].
> >
> > [1] https://git.yoctoproject.org/cgit/cgit.cgi/meta-security/tree/meta-tpm/recipes-tpm2/tpm2-tss/tpm2-tss_3.0.3.bb?id=e0fca90835169e21ffabe6f2e4b901678236d36e#n37
> >
>
> Then, shouldn't that be a bbappend in meta-security? Else, you run the
> risk of pulling a dependency for a recipe in a layer you don't have.
Even if the dependency is in another layer, we've been moving towards having the
PACKAGECONFIG in the main recipe with the default as not enabled. This means the
correct "disable" configure options are added explicitly.
Cheers,
Richard
next prev parent reply other threads:[~2021-09-18 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 10:23 [PATCH] systemd: Add tpm2 PACKAGECONFIG Kristian Klausen
2021-09-15 10:48 ` [OE-core] " Quentin Schulz
2021-09-15 11:31 ` Kristian Klausen
2021-09-15 11:34 ` Quentin Schulz
2021-09-17 15:47 ` Alexandre Belloni
2021-09-18 9:17 ` Richard Purdie [this message]
2021-09-18 15:26 ` Armin Kuster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=042c07228f93912207b7d0616d99dbe0a1e6bfb6.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alexandre.belloni@bootlin.com \
--cc=kristian@klausen.dk \
--cc=openembedded-core@lists.openembedded.org \
--cc=quentin.schulz@theobroma-systems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.