All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Quentin Schulz" <quentin.schulz@theobroma-systems.com>
To: kristian@klausen.dk
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] systemd: Add tpm2 PACKAGECONFIG
Date: Wed, 15 Sep 2021 12:48:18 +0200	[thread overview]
Message-ID: <20210915104818.43wown7ss2pcfnky@fedora> (raw)
In-Reply-To: <20210915102308.1892-1-kristian@klausen.dk>

Hi Kristian,

On Wed, Sep 15, 2021 at 12:23:08PM +0200, Kristian Klausen via lists.openembedded.org wrote:
> The TPM2 support is used, among other things, for unlocking encrypted
> volumes.
> 
> Signed-off-by: Kristian Klausen <kristian@klausen.dk>
> ---
>  meta/recipes-core/systemd/systemd_249.3.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/systemd/systemd_249.3.bb b/meta/recipes-core/systemd/systemd_249.3.bb
> index c027b88fd6..f8c85dabf0 100644
> --- a/meta/recipes-core/systemd/systemd_249.3.bb
> +++ b/meta/recipes-core/systemd/systemd_249.3.bb
> @@ -128,6 +128,7 @@ PACKAGECONFIG[bzip2] = "-Dbzip2=true,-Dbzip2=false,bzip2"
>  PACKAGECONFIG[cgroupv2] = "-Ddefault-hierarchy=unified,-Ddefault-hierarchy=hybrid"
>  PACKAGECONFIG[coredump] = "-Dcoredump=true,-Dcoredump=false"
>  PACKAGECONFIG[cryptsetup] = "-Dlibcryptsetup=true,-Dlibcryptsetup=false,cryptsetup,,cryptsetup"
> +PACKAGECONFIG[tpm2] = "-Dtpm2=true,-Dtpm2=false,tpm2-tss,tpm2-tss libtss2 libtss2-tcti-device"

Shouldn't the RDEPENDS part of the PACKAGECONFIG be pulled in
automatically by Bitbake since I assume the libs they contained are used
by the linker for systemd?

Also looking at the tpm2-tss recipe, I'm not sure there's a package
named libtss2-tcti-device?

I would assume that

PACKAGECONFIG[tpm2] = "-Dtpm2=true,-Dtpm2=false,tpm2-tss"

would be enough except if there's dynamic loading of libraries or
binaries from tpm2-tss that are required at runtime?

Cheers,
Quentin

  reply	other threads:[~2021-09-15 10:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 10:23 [PATCH] systemd: Add tpm2 PACKAGECONFIG Kristian Klausen
2021-09-15 10:48 ` Quentin Schulz [this message]
2021-09-15 11:31   ` [OE-core] " Kristian Klausen
2021-09-15 11:34     ` Quentin Schulz
2021-09-17 15:47     ` Alexandre Belloni
2021-09-18  9:17       ` Richard Purdie
2021-09-18 15:26       ` Armin Kuster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210915104818.43wown7ss2pcfnky@fedora \
    --to=quentin.schulz@theobroma-systems.com \
    --cc=kristian@klausen.dk \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.