All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Wolfram Sang <wsa@kernel.org>,
	lakshmi.sowjanya.d@intel.com, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, bala.senthil@intel.com,
	pandith.n@intel.com
Subject: Re: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode Plus and High Speed Mode
Date: Tue, 30 Nov 2021 09:51:42 +0200	[thread overview]
Message-ID: <042d2c9f-4333-44b1-09c0-b0953a51c176@linux.intel.com> (raw)
In-Reply-To: <YaUGV3lEmW9qtP+3@kunai>

On 11/29/21 6:56 PM, Wolfram Sang wrote:
> On Tue, Nov 09, 2021 at 04:05:51PM +0530, lakshmi.sowjanya.d@intel.com wrote:
>> From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
>>
>> Add support to configure HCNT, LCNT values for Fast Mode Plus and High
>> Speed Mode.
>>
>> Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
> 
> Applied to for-next, thanks!
> 
>> +	u32 fp_lcnt;
>> +	u32 hs_lcnt;
>>   	u32 sda_hold;
> 
> Short question unrelated to this patch. Why are all these u32...
> 
>>   		dev->ss_hcnt = cfg->ss_hcnt;
>>   		dev->fs_hcnt = cfg->fs_hcnt;
> 
> ... and the ones in dev are u16? Wouldn't it be easier if they all had
> the same type?
> 
True, only sda_hold(_time) is u32 and other timing parameters are u16.

Lakshmi: Would you like to send a patch fixing this and get more 
contributions to the driver :-)

Originally this discrepancy was introduced 2014 by the commit 
8efd1e9ee3bd ("i2c: designware-pci: set ideal HCNT, LCNT and SDA hold 
time value").

Jarkko

  reply	other threads:[~2021-11-30  7:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 10:35 [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode Plus and High Speed Mode lakshmi.sowjanya.d
2021-11-09 10:35 ` [PATCH v1 2/2] i2c: designware-pci: Set ideal timing parameters for Elkhart Lake PSE lakshmi.sowjanya.d
2021-11-09 12:59   ` Jarkko Nikula
2021-11-29 17:00     ` Wolfram Sang
2021-11-29 16:57   ` Wolfram Sang
2021-11-30  9:14     ` Andy Shevchenko
2021-11-30 15:49       ` Andy Shevchenko
2021-11-30 21:34         ` Wolfram Sang
2021-11-29 16:56 ` [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode Plus and High Speed Mode Wolfram Sang
2021-11-30  7:51   ` Jarkko Nikula [this message]
2021-12-01  5:51     ` D, Lakshmi Sowjanya
2021-12-01  7:33       ` Jarkko Nikula
2021-12-01  8:36         ` Wolfram Sang
2021-12-01  9:39           ` D, Lakshmi Sowjanya
2021-12-01 11:35             ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=042d2c9f-4333-44b1-09c0-b0953a51c176@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=bala.senthil@intel.com \
    --cc=lakshmi.sowjanya.d@intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pandith.n@intel.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.