From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Wolfram Sang <wsa@kernel.org>,
lakshmi.sowjanya.d@intel.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, jarkko.nikula@linux.intel.com,
bala.senthil@intel.com, pandith.n@intel.com
Subject: Re: [PATCH v1 2/2] i2c: designware-pci: Set ideal timing parameters for Elkhart Lake PSE
Date: Tue, 30 Nov 2021 17:49:41 +0200 [thread overview]
Message-ID: <YaZIFTHCGb5dLM2f@smile.fi.intel.com> (raw)
In-Reply-To: <YaXrkJbsktXFAgFJ@smile.fi.intel.com>
On Tue, Nov 30, 2021 at 11:14:57AM +0200, Andy Shevchenko wrote:
> On Mon, Nov 29, 2021 at 05:57:03PM +0100, Wolfram Sang wrote:
> > On Tue, Nov 09, 2021 at 04:05:52PM +0530, lakshmi.sowjanya.d@intel.com wrote:
> > > From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
> > >
> > > Set optimal HCNT, LCNT and hold time values for all the speeds supported
> > > in Intel Programmable Service Engine I2C controller in Intel Elkhart
> > > Lake.
> > >
> > > Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
> >
> > Applied to for-next, thanks!
>
> Oh là là! Can we revert these, please?
>
> After the commit 64d0a0755c7d ("i2c: designware: Read counters from ACPI for
> PCI driver") the PCI driver should get this from ACPI tables, no hard coding
> needed anymore. I did that series to address this very issue.
>
> So, Lakshmi, please ask for BIOS fix as we discussed long time ago.
For the record, I have just checked the DSDT dump I have from
Elkhart Lake machine and BIOS provides those counters for devices
\_SB.PCI0.I2C0 .. \_SB.PCI0.I2C5 (6 devices altogether).
So, BIOS is quite aware of the interface and patches are not needed.
I rather add a comment there that these tables in the driver shouldn't
be spread and expanded anymore (at least by Intel).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-30 15:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 10:35 [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode Plus and High Speed Mode lakshmi.sowjanya.d
2021-11-09 10:35 ` [PATCH v1 2/2] i2c: designware-pci: Set ideal timing parameters for Elkhart Lake PSE lakshmi.sowjanya.d
2021-11-09 12:59 ` Jarkko Nikula
2021-11-29 17:00 ` Wolfram Sang
2021-11-29 16:57 ` Wolfram Sang
2021-11-30 9:14 ` Andy Shevchenko
2021-11-30 15:49 ` Andy Shevchenko [this message]
2021-11-30 21:34 ` Wolfram Sang
2021-11-29 16:56 ` [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode Plus and High Speed Mode Wolfram Sang
2021-11-30 7:51 ` Jarkko Nikula
2021-12-01 5:51 ` D, Lakshmi Sowjanya
2021-12-01 7:33 ` Jarkko Nikula
2021-12-01 8:36 ` Wolfram Sang
2021-12-01 9:39 ` D, Lakshmi Sowjanya
2021-12-01 11:35 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaZIFTHCGb5dLM2f@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bala.senthil@intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lakshmi.sowjanya.d@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pandith.n@intel.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.