From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eric Blake <eblake@redhat.com>, Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Ed Maste" <emaste@freebsd.org>,
qemu-block@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Max Reitz" <mreitz@redhat.com>, "Li-Wen Hsu" <lwhsu@freebsd.org>
Subject: Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash
Date: Wed, 24 Apr 2019 16:42:51 +0200 [thread overview]
Message-ID: <04383486-acc8-f07e-e6be-63cb654be25c@redhat.com> (raw)
In-Reply-To: <167b6b7c-3fef-47e8-d30d-09abfe1e50ba@redhat.com>
On 4/24/19 4:14 PM, Eric Blake wrote:
> On 4/24/19 5:37 AM, Thomas Huth wrote:
>> bash is installed in a different directory on non-Linux systems like
>> FreeBSD. Do not hard-code /bin/bash here so that the tests can run
>> there, too.
>
> These tests were obviously copy-and-pasted from a fork point prior to
> commit 11a82d14.
:(
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/qemu-iotests/239 | 2 +-
>> tests/qemu-iotests/240 | 2 +-
>> tests/qemu-iotests/241 | 2 +-
>> tests/qemu-iotests/243 | 2 +-
>> tests/qemu-iotests/244 | 2 +-
>> 5 files changed, 5 insertions(+), 5 deletions(-)
>
>
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eric Blake <eblake@redhat.com>, Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Ed Maste" <emaste@freebsd.org>,
qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Li-Wen Hsu" <lwhsu@freebsd.org>
Subject: Re: [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash
Date: Wed, 24 Apr 2019 16:42:51 +0200 [thread overview]
Message-ID: <04383486-acc8-f07e-e6be-63cb654be25c@redhat.com> (raw)
Message-ID: <20190424144251.tJIEDA6_w_cFLYEZ1absOVPUyVRuaOLI9Pasj0wGUyk@z> (raw)
In-Reply-To: <167b6b7c-3fef-47e8-d30d-09abfe1e50ba@redhat.com>
On 4/24/19 4:14 PM, Eric Blake wrote:
> On 4/24/19 5:37 AM, Thomas Huth wrote:
>> bash is installed in a different directory on non-Linux systems like
>> FreeBSD. Do not hard-code /bin/bash here so that the tests can run
>> there, too.
>
> These tests were obviously copy-and-pasted from a fork point prior to
> commit 11a82d14.
:(
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> tests/qemu-iotests/239 | 2 +-
>> tests/qemu-iotests/240 | 2 +-
>> tests/qemu-iotests/241 | 2 +-
>> tests/qemu-iotests/243 | 2 +-
>> tests/qemu-iotests/244 | 2 +-
>> 5 files changed, 5 insertions(+), 5 deletions(-)
>
>
next prev parent reply other threads:[~2019-04-24 14:42 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 10:37 [Qemu-devel] [PATCH 0/6] tests/qemu-iotests: Run basic iotests during "make check" Thomas Huth
2019-04-24 10:37 ` Thomas Huth
2019-04-24 10:37 ` [Qemu-devel] [PATCH 1/6] tests/qemu-iotests/check: Pick a default machine if necessary Thomas Huth
2019-04-24 10:37 ` Thomas Huth
2019-04-30 21:31 ` Alex Bennée
2019-04-30 21:31 ` Alex Bennée
2019-04-24 10:37 ` [Qemu-devel] [PATCH 2/6] tests/qemu-iotests/group: Introduce a new "ci" group for CI pipelines Thomas Huth
2019-04-24 10:37 ` Thomas Huth
2019-04-24 11:25 ` Daniel P. Berrangé
2019-04-24 11:25 ` Daniel P. Berrangé
2019-04-24 12:37 ` Thomas Huth
2019-04-24 12:37 ` Thomas Huth
2019-04-24 12:50 ` Daniel P. Berrangé
2019-04-24 12:50 ` Daniel P. Berrangé
2019-04-24 13:01 ` Thomas Huth
2019-04-24 13:01 ` Thomas Huth
2019-04-24 13:12 ` Daniel P. Berrangé
2019-04-24 13:12 ` Daniel P. Berrangé
2019-04-25 7:44 ` Thomas Huth
2019-04-25 7:44 ` Thomas Huth
2019-04-24 10:37 ` [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash Thomas Huth
2019-04-24 10:37 ` Thomas Huth
2019-04-24 14:14 ` Eric Blake
2019-04-24 14:14 ` Eric Blake
2019-04-24 14:42 ` Philippe Mathieu-Daudé [this message]
2019-04-24 14:42 ` Philippe Mathieu-Daudé
2019-04-24 15:23 ` Daniel P. Berrangé
2019-04-24 15:23 ` Daniel P. Berrangé
2019-04-25 7:48 ` Thomas Huth
2019-04-25 7:48 ` Thomas Huth
2019-04-30 21:33 ` Alex Bennée
2019-04-30 21:33 ` Alex Bennée
2019-04-24 10:37 ` [Qemu-devel] [PATCH 4/6] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD Thomas Huth
2019-04-24 10:37 ` Thomas Huth
2019-04-24 21:29 ` Wainer dos Santos Moschetta
2019-04-24 21:29 ` Wainer dos Santos Moschetta
2019-04-25 6:00 ` Thomas Huth
2019-04-25 6:00 ` Thomas Huth
2019-04-26 16:43 ` Laszlo Ersek
2019-04-26 16:43 ` Laszlo Ersek
2019-05-06 10:12 ` [Qemu-devel] Update *BSD images with gnu-sed and bash (was: [PATCH 4/6] cirrus / travis: Add gnu-sed and bash for macOS and FreeBSD) Thomas Huth
2019-05-07 8:32 ` Gerd Hoffmann
2019-05-07 10:13 ` Thomas Huth
2019-05-08 7:06 ` [Qemu-devel] Update *BSD images with gnu-sed and bash Kamil Rytarowski
2019-05-08 8:07 ` Thomas Huth
2019-05-08 19:21 ` Kamil Rytarowski
2019-04-24 10:37 ` [Qemu-devel] [PATCH 5/6] tests: Run the iotests during "make check" again Thomas Huth
2019-04-24 10:37 ` Thomas Huth
2019-04-24 10:48 ` Daniel P. Berrangé
2019-04-24 10:48 ` Daniel P. Berrangé
2019-04-24 10:59 ` Thomas Huth
2019-04-24 10:59 ` Thomas Huth
2019-04-24 12:02 ` Vladimir Sementsov-Ogievskiy
2019-04-24 12:02 ` Vladimir Sementsov-Ogievskiy
2019-04-24 12:13 ` Daniel P. Berrangé
2019-04-24 12:13 ` Daniel P. Berrangé
2019-04-24 12:18 ` Vladimir Sementsov-Ogievskiy
2019-04-24 12:18 ` Vladimir Sementsov-Ogievskiy
2019-04-24 20:42 ` Wainer dos Santos Moschetta
2019-04-24 20:42 ` Wainer dos Santos Moschetta
2019-04-25 5:57 ` Thomas Huth
2019-04-25 5:57 ` Thomas Huth
2019-04-25 10:24 ` Thomas Huth
2019-04-25 10:24 ` Thomas Huth
2019-04-28 2:42 ` Eric Blake
2019-04-28 2:42 ` Eric Blake
2019-04-24 10:37 ` [Qemu-devel] [PATCH 6/6] tests/qemu-iotests: Remove the "_supported_os Linux" line from many tests Thomas Huth
2019-04-24 10:37 ` Thomas Huth
2019-04-27 4:51 ` [Qemu-devel] [PATCH 0/6] tests/qemu-iotests: Run basic iotests during "make check" no-reply
2019-04-27 4:51 ` no-reply
2019-04-29 12:04 ` Christian Borntraeger
2019-04-29 12:04 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04383486-acc8-f07e-e6be-63cb654be25c@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=eblake@redhat.com \
--cc=emaste@freebsd.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=lwhsu@freebsd.org \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.