* sparse fixes, part2
@ 2016-10-13 19:55 Christoph Hellwig
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
0 siblings, 1 reply; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:55 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
This has the rest of the provider fixes that the mail server
didn't let through last time.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 01/17] cxgb3: handle global variables properly
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
@ 2016-10-13 19:56 ` Christoph Hellwig
[not found] ` <1476388576-22863-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-13 19:56 ` [PATCH 02/17] cxgb3: mark symbols static where possible Christoph Hellwig
` (16 subsequent siblings)
17 siblings, 1 reply; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
We'll need to define them in one compilation unit and use an extern
declaration in the headers.
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/cxgb3/cxio_wr.h | 6 +++---
providers/cxgb3/iwch.c | 4 ++++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/providers/cxgb3/cxio_wr.h b/providers/cxgb3/cxio_wr.h
index e154795..d56c529 100644
--- a/providers/cxgb3/cxio_wr.h
+++ b/providers/cxgb3/cxio_wr.h
@@ -633,9 +633,9 @@ static inline unsigned t3_cq_depth(struct t3_cq *cq)
return (1UL<<cq->size_log2);
}
-unsigned long iwch_page_size;
-unsigned long iwch_page_shift;
-unsigned long iwch_page_mask;
+extern unsigned long iwch_page_size;
+extern unsigned long iwch_page_shift;
+extern unsigned long iwch_page_mask;
#define PAGE_ALIGN(x) (((x) + iwch_page_mask) & ~iwch_page_mask)
diff --git a/providers/cxgb3/iwch.c b/providers/cxgb3/iwch.c
index aa9b108..804726c 100644
--- a/providers/cxgb3/iwch.c
+++ b/providers/cxgb3/iwch.c
@@ -105,6 +105,10 @@ static struct ibv_context_ops iwch_ctx_ops = {
.req_notify_cq = iwch_arm_cq,
};
+unsigned long iwch_page_size;
+unsigned long iwch_page_shift;
+unsigned long iwch_page_mask;
+
static struct ibv_context *iwch_alloc_context(struct ibv_device *ibdev,
int cmd_fd)
{
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 02/17] cxgb3: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-13 19:56 ` [PATCH 01/17] cxgb3: handle global variables properly Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
[not found] ` <1476388576-22863-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-13 19:56 ` [PATCH 03/17] hfi1verbs: " Christoph Hellwig
` (15 subsequent siblings)
17 siblings, 1 reply; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/cxgb3/cq.c | 2 +-
providers/cxgb3/iwch.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/providers/cxgb3/cq.c b/providers/cxgb3/cq.c
index 1510d1e..a6158ce 100644
--- a/providers/cxgb3/cq.c
+++ b/providers/cxgb3/cq.c
@@ -255,7 +255,7 @@ skip_cqe:
* -EAGAIN caller must try again
* any other -errno fatal error
*/
-int iwch_poll_cq_one(struct iwch_device *rhp, struct iwch_cq *chp,
+static int iwch_poll_cq_one(struct iwch_device *rhp, struct iwch_cq *chp,
struct ibv_wc *wc)
{
struct iwch_qp *qhp = NULL;
diff --git a/providers/cxgb3/iwch.c b/providers/cxgb3/iwch.c
index 804726c..a03bced 100644
--- a/providers/cxgb3/iwch.c
+++ b/providers/cxgb3/iwch.c
@@ -61,7 +61,7 @@
.device = PCI_DEVICE_ID_CHELSIO_##d, \
.type = CHELSIO_##t }
-struct {
+static struct {
unsigned vendor;
unsigned device;
enum iwch_hca_type type;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 03/17] hfi1verbs: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-13 19:56 ` [PATCH 01/17] cxgb3: handle global variables properly Christoph Hellwig
2016-10-13 19:56 ` [PATCH 02/17] cxgb3: mark symbols static where possible Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
[not found] ` <1476388576-22863-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-13 19:56 ` [PATCH 04/17] ipathverbs: " Christoph Hellwig
` (14 subsequent siblings)
17 siblings, 1 reply; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/hfi1verbs/hfiverbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/hfi1verbs/hfiverbs.c b/providers/hfi1verbs/hfiverbs.c
index e28afc7..7605347 100644
--- a/providers/hfi1verbs/hfiverbs.c
+++ b/providers/hfi1verbs/hfiverbs.c
@@ -81,7 +81,7 @@
{ .vendor = PCI_VENDOR_ID_##v, \
.device = PCI_DEVICE_ID_HFI_##d }
-struct {
+static struct {
unsigned vendor;
unsigned device;
} hca_table[] = {
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 04/17] ipathverbs: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (2 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 03/17] hfi1verbs: " Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
[not found] ` <1476388576-22863-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-13 19:56 ` [PATCH 05/17] i40iw: " Christoph Hellwig
` (13 subsequent siblings)
17 siblings, 1 reply; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/ipathverbs/ipathverbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/ipathverbs/ipathverbs.c b/providers/ipathverbs/ipathverbs.c
index 4b945f6..e953864 100644
--- a/providers/ipathverbs/ipathverbs.c
+++ b/providers/ipathverbs/ipathverbs.c
@@ -77,7 +77,7 @@
{ .vendor = PCI_VENDOR_ID_##v, \
.device = PCI_DEVICE_ID_INFINIPATH_##d }
-struct {
+static struct {
unsigned vendor;
unsigned device;
} hca_table[] = {
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 05/17] i40iw: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (3 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 04/17] ipathverbs: " Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 06/17] i40iw: remove unused variable i40iw_debug_level Christoph Hellwig
` (12 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/i40iw/i40iw_umain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/i40iw/i40iw_umain.c b/providers/i40iw/i40iw_umain.c
index 1756e65..0540ee7 100644
--- a/providers/i40iw/i40iw_umain.c
+++ b/providers/i40iw/i40iw_umain.c
@@ -57,7 +57,7 @@ unsigned int i40iw_debug_level;
.device = d, \
.type = INTEL_ ## t }
-struct {
+static struct {
unsigned int vendor;
unsigned int device;
enum i40iw_uhca_type type;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 06/17] i40iw: remove unused variable i40iw_debug_level
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (4 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 05/17] i40iw: " Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 07/17] mlx4: mark symbols static where possible Christoph Hellwig
` (11 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/i40iw/i40iw_umain.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/providers/i40iw/i40iw_umain.c b/providers/i40iw/i40iw_umain.c
index 0540ee7..8d7b655 100644
--- a/providers/i40iw/i40iw_umain.c
+++ b/providers/i40iw/i40iw_umain.c
@@ -46,8 +46,6 @@
#include "i40iw_umain.h"
#include "i40iw-abi.h"
-unsigned int i40iw_debug_level;
-
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 07/17] mlx4: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (5 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 06/17] i40iw: remove unused variable i40iw_debug_level Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 08/17] mthca: " Christoph Hellwig
` (10 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/mlx4/mlx4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/mlx4/mlx4.c b/providers/mlx4/mlx4.c
index 326ead4..b59c202 100644
--- a/providers/mlx4/mlx4.c
+++ b/providers/mlx4/mlx4.c
@@ -51,7 +51,7 @@
{ .vendor = PCI_VENDOR_ID_##v, \
.device = d }
-struct {
+static struct {
unsigned vendor;
unsigned device;
} hca_table[] = {
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 08/17] mthca: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (6 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 07/17] mlx4: mark symbols static where possible Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 09/17] rxe: " Christoph Hellwig
` (9 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/mthca/mthca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/mthca/mthca.c b/providers/mthca/mthca.c
index d5660ce..4103a3a 100644
--- a/providers/mthca/mthca.c
+++ b/providers/mthca/mthca.c
@@ -77,7 +77,7 @@
.device = PCI_DEVICE_ID_MELLANOX_##d, \
.type = MTHCA_##t }
-struct {
+static struct {
unsigned vendor;
unsigned device;
enum mthca_hca_type type;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 09/17] rxe: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (7 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 08/17] mthca: " Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 10/17] ocrdma: " Christoph Hellwig
` (8 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/rxe/rxe.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/providers/rxe/rxe.c b/providers/rxe/rxe.c
index 8f8cc91..5aa77ea 100644
--- a/providers/rxe/rxe.c
+++ b/providers/rxe/rxe.c
@@ -305,7 +305,7 @@ static struct ibv_srq *rxe_create_srq(struct ibv_pd *pd,
return &srq->ibv_srq;
}
-int rxe_modify_srq(struct ibv_srq *ibsrq,
+static int rxe_modify_srq(struct ibv_srq *ibsrq,
struct ibv_srq_attr *attr, int attr_mask)
{
struct rxe_srq *srq = to_rsrq(ibsrq);
@@ -553,7 +553,7 @@ static int validate_send_wr(struct rxe_wq *sq, struct ibv_send_wr *ibwr,
return 0;
}
-void convert_send_wr(struct rxe_send_wr *kwr, struct ibv_send_wr *uwr)
+static void convert_send_wr(struct rxe_send_wr *kwr, struct ibv_send_wr *uwr)
{
memset(kwr, 0, sizeof(*kwr));
@@ -593,7 +593,7 @@ void convert_send_wr(struct rxe_send_wr *kwr, struct ibv_send_wr *uwr)
}
}
-int init_send_wqe(struct rxe_qp *qp, struct rxe_wq *sq,
+static int init_send_wqe(struct rxe_qp *qp, struct rxe_wq *sq,
struct ibv_send_wr *ibwr, unsigned int length,
struct rxe_send_wqe *wqe)
{
@@ -668,7 +668,7 @@ static int post_one_send(struct rxe_qp *qp, struct rxe_wq *sq,
}
/* send a null post send as a doorbell */
-int post_send_db(struct ibv_qp *ibqp)
+static int post_send_db(struct ibv_qp *ibqp)
{
struct ibv_post_send cmd;
struct ibv_post_send_resp resp;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 10/17] ocrdma: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (8 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 09/17] rxe: " Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 11/17] ocrdma: use NULL instead of 0 for NULL pointers Christoph Hellwig
` (7 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/ocrdma/ocrdma_main.c | 2 +-
providers/ocrdma/ocrdma_verbs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/providers/ocrdma/ocrdma_main.c b/providers/ocrdma/ocrdma_main.c
index f3830d9..39da8f0 100644
--- a/providers/ocrdma/ocrdma_main.c
+++ b/providers/ocrdma/ocrdma_main.c
@@ -59,7 +59,7 @@
{ .vendor = PCI_VENDOR_ID_##v, \
.device = PCI_DEVICE_ID_EMULEX_##d }
-struct {
+static struct {
unsigned vendor;
unsigned device;
} ucna_table[] = {
diff --git a/providers/ocrdma/ocrdma_verbs.c b/providers/ocrdma/ocrdma_verbs.c
index 163bf23..c5dd74b 100644
--- a/providers/ocrdma/ocrdma_verbs.c
+++ b/providers/ocrdma/ocrdma_verbs.c
@@ -608,7 +608,7 @@ mbx_err:
return NULL;
}
-enum ocrdma_qp_state get_ocrdma_qp_state(enum ibv_qp_state qps)
+static enum ocrdma_qp_state get_ocrdma_qp_state(enum ibv_qp_state qps)
{
switch (qps) {
case IBV_QPS_RESET:
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 11/17] ocrdma: use NULL instead of 0 for NULL pointers
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (9 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 10/17] ocrdma: " Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 12/17] nes: move external declaration to nes_umain.h Christoph Hellwig
` (6 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/ocrdma/ocrdma_verbs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/providers/ocrdma/ocrdma_verbs.c b/providers/ocrdma/ocrdma_verbs.c
index c5dd74b..7e066dc 100644
--- a/providers/ocrdma/ocrdma_verbs.c
+++ b/providers/ocrdma/ocrdma_verbs.c
@@ -455,7 +455,7 @@ int ocrdma_destroy_srq(struct ibv_srq *ibsrq)
free(srq->rqe_wr_id_tbl);
if (srq->db_va) {
munmap((void *)srq->db_va, srq->db_size);
- srq->db_va = 0;
+ srq->db_va = NULL;
}
if (srq->rq.va) {
munmap(srq->rq.va, srq->rq.len);
@@ -591,7 +591,7 @@ struct ibv_qp *ocrdma_create_qp(struct ibv_pd *pd,
} else {
if (qp->dpp_cq) {
ocrdma_destroy_cq(&qp->dpp_cq->ibv_cq);
- qp->dpp_cq = 0;
+ qp->dpp_cq = NULL;
}
}
qp->state = OCRDMA_QPS_RST;
@@ -1789,7 +1789,7 @@ static void ocrdma_update_free_srq_cqe(struct ibv_wc *ibwc,
struct ocrdma_cqe *cqe,
struct ocrdma_qp *qp)
{
- struct ocrdma_srq *srq = 0;
+ struct ocrdma_srq *srq = NULL;
uint32_t wqe_idx;
srq = get_ocrdma_srq(qp->ibv_qp.srq);
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 12/17] nes: move external declaration to nes_umain.h
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (10 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 11/17] ocrdma: use NULL instead of 0 for NULL pointers Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 13/17] nes: mark symbols static where possible Christoph Hellwig
` (5 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/nes/nes_umain.h | 2 ++
providers/nes/nes_uverbs.c | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/providers/nes/nes_umain.h b/providers/nes/nes_umain.h
index f3cc348..093956a 100644
--- a/providers/nes/nes_umain.h
+++ b/providers/nes/nes_umain.h
@@ -400,4 +400,6 @@ static inline uint32_t le32_to_cpu(uint32_t x)
return le32toh(x);
}
+extern long int page_size;
+
#endif /* nes_umain_H */
diff --git a/providers/nes/nes_uverbs.c b/providers/nes/nes_uverbs.c
index aa9c2b9..287e773 100644
--- a/providers/nes/nes_uverbs.c
+++ b/providers/nes/nes_uverbs.c
@@ -49,8 +49,6 @@
#include "nes_umain.h"
#include "nes-abi.h"
-extern long int page_size;
-
#define STATIC static
#define INLINE inline
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 13/17] nes: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (11 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 12/17] nes: move external declaration to nes_umain.h Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 14/17] nes: use NULL instead of 0 for NULL pointers Christoph Hellwig
` (4 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/nes/nes_umain.c | 2 +-
providers/nes/nes_uverbs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/providers/nes/nes_umain.c b/providers/nes/nes_umain.c
index b4e0bc1..4b19dd7 100644
--- a/providers/nes/nes_umain.c
+++ b/providers/nes/nes_umain.c
@@ -60,7 +60,7 @@ long int page_size;
.device = d, \
.type = NETEFFECT_##t }
-struct {
+static struct {
unsigned vendor;
unsigned device;
enum nes_uhca_type type;
diff --git a/providers/nes/nes_uverbs.c b/providers/nes/nes_uverbs.c
index 287e773..f404ffd 100644
--- a/providers/nes/nes_uverbs.c
+++ b/providers/nes/nes_uverbs.c
@@ -759,7 +759,7 @@ int nes_upoll_cq_no_db_read(struct ibv_cq *cq, int num_entries, struct ibv_wc *e
/**
* nes_arm_cq
*/
-void nes_arm_cq(struct nes_ucq *nesucq, struct nes_uvcontext *nesvctx, int sol)
+static void nes_arm_cq(struct nes_ucq *nesucq, struct nes_uvcontext *nesvctx, int sol)
{
uint32_t cq_arm;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 14/17] nes: use NULL instead of 0 for NULL pointers
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (12 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 13/17] nes: mark symbols static where possible Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 15/17] mlx5: mark symbols static where possible Christoph Hellwig
` (3 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/nes/nes_uverbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/nes/nes_uverbs.c b/providers/nes/nes_uverbs.c
index f404ffd..7e7bb90 100644
--- a/providers/nes/nes_uverbs.c
+++ b/providers/nes/nes_uverbs.c
@@ -324,7 +324,7 @@ int nes_ima_upoll_cq(struct ibv_cq *cq, int num_entries, struct ibv_wc *entry)
uint32_t head;
uint32_t cq_size;
- volatile struct nes_hw_nic_cqe *cqe = 0;
+ volatile struct nes_hw_nic_cqe *cqe = NULL;
volatile struct nes_hw_nic_cqe *cqes;
struct nes_uqp *nesuqp = nesucq->udqp;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 15/17] mlx5: mark symbols static where possible
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (13 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 14/17] nes: use NULL instead of 0 for NULL pointers Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 16/17] mlx5: use NULL instead of 0 for NULL pointers Christoph Hellwig
` (2 subsequent siblings)
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/mlx5/mlx5.c | 2 +-
providers/mlx5/verbs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/providers/mlx5/mlx5.c b/providers/mlx5/mlx5.c
index f24e504..4b05dc4 100644
--- a/providers/mlx5/mlx5.c
+++ b/providers/mlx5/mlx5.c
@@ -62,7 +62,7 @@
{ .vendor = PCI_VENDOR_ID_##v, \
.device = d }
-struct {
+static struct {
unsigned vendor;
unsigned device;
} hca_table[] = {
diff --git a/providers/mlx5/verbs.c b/providers/mlx5/verbs.c
index ef85a63..e288ebf 100644
--- a/providers/mlx5/verbs.c
+++ b/providers/mlx5/verbs.c
@@ -1184,7 +1184,7 @@ enum {
IBV_QP_INIT_ATTR_RX_HASH),
};
-struct ibv_qp *create_qp(struct ibv_context *context,
+static struct ibv_qp *create_qp(struct ibv_context *context,
struct ibv_qp_init_attr_ex *attr)
{
struct mlx5_create_qp cmd;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 16/17] mlx5: use NULL instead of 0 for NULL pointers
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (14 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 15/17] mlx5: mark symbols static where possible Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-13 19:56 ` [PATCH 17/17] mlx5: use proper ANSI-C prototypes for functions without arguments Christoph Hellwig
2016-10-14 4:06 ` sparse fixes, part2 Jason Gunthorpe
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/mlx5/mlx5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/providers/mlx5/mlx5.c b/providers/mlx5/mlx5.c
index 4b05dc4..747e242 100644
--- a/providers/mlx5/mlx5.c
+++ b/providers/mlx5/mlx5.c
@@ -310,7 +310,7 @@ static void mlx5_local_cpu_set(struct ibv_device *ibdev, cpu_set_t *cpu_set)
p ++;
}
- word = strtoul(p, 0, 16);
+ word = strtoul(p, NULL, 16);
for (k = 0; word; ++k, word >>= 1)
if (word & 1)
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 17/17] mlx5: use proper ANSI-C prototypes for functions without arguments
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (15 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 16/17] mlx5: use NULL instead of 0 for NULL pointers Christoph Hellwig
@ 2016-10-13 19:56 ` Christoph Hellwig
2016-10-14 4:06 ` sparse fixes, part2 Jason Gunthorpe
17 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-13 19:56 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
providers/mlx5/cq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/providers/mlx5/cq.c b/providers/mlx5/cq.c
index 2a53c89..ecfd6eb 100644
--- a/providers/mlx5/cq.c
+++ b/providers/mlx5/cq.c
@@ -384,7 +384,7 @@ static enum ibv_wc_status mlx5_handle_error_cqe(struct mlx5_err_cqe *cqe)
}
#if defined(__x86_64__) || defined (__i386__)
-static inline unsigned long get_cycles()
+static inline unsigned long get_cycles(void)
{
uint32_t low, high;
uint64_t val;
@@ -394,7 +394,7 @@ static inline unsigned long get_cycles()
return val;
}
-static void mlx5_stall_poll_cq()
+static void mlx5_stall_poll_cq(void)
{
int i;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 24+ messages in thread
* RE: [PATCH 01/17] cxgb3: handle global variables properly
[not found] ` <1476388576-22863-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
@ 2016-10-13 21:58 ` Steve Wise
0 siblings, 0 replies; 24+ messages in thread
From: Steve Wise @ 2016-10-13 21:58 UTC (permalink / raw)
To: 'Christoph Hellwig', linux-rdma-u79uwXL29TY76Z2rM5mHXA
>
> We'll need to define them in one compilation unit and use an extern
> declaration in the headers.
>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> ---
Looks good.
Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH 02/17] cxgb3: mark symbols static where possible
[not found] ` <1476388576-22863-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
@ 2016-10-13 21:59 ` Steve Wise
0 siblings, 0 replies; 24+ messages in thread
From: Steve Wise @ 2016-10-13 21:59 UTC (permalink / raw)
To: 'Christoph Hellwig', linux-rdma-u79uwXL29TY76Z2rM5mHXA
>
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Fine.
Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: sparse fixes, part2
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
` (16 preceding siblings ...)
2016-10-13 19:56 ` [PATCH 17/17] mlx5: use proper ANSI-C prototypes for functions without arguments Christoph Hellwig
@ 2016-10-14 4:06 ` Jason Gunthorpe
[not found] ` <20161014040602.GA5726-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
17 siblings, 1 reply; 24+ messages in thread
From: Jason Gunthorpe @ 2016-10-14 4:06 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Thu, Oct 13, 2016 at 09:55:59PM +0200, Christoph Hellwig wrote:
> This has the rest of the provider fixes that the mail server
> didn't let through last time.
I tested these and added them to the PR.
I also tacked on two more commits to enable similar gcc warnings, gcc noticed
a few more cases which I also fixed..
https://github.com/linux-rdma/rdma-core/pull/19/commits/2e20ef09914a47e5be35d3e1587697a7337aa93a
https://github.com/linux-rdma/rdma-core/pull/19/commits/2808a6142146576036ca36e7b527ff0c8f2da3ce
Though, I had to use '#pragma GCC diagnostic ignored
"-Wmissing-prototypes"' to deal with the symver stuff.. Couldn't find
a better way..
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: sparse fixes, part2
[not found] ` <20161014040602.GA5726-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
@ 2016-10-14 5:31 ` Christoph Hellwig
0 siblings, 0 replies; 24+ messages in thread
From: Christoph Hellwig @ 2016-10-14 5:31 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: Christoph Hellwig, linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Thu, Oct 13, 2016 at 10:06:02PM -0600, Jason Gunthorpe wrote:
> Though, I had to use '#pragma GCC diagnostic ignored
> "-Wmissing-prototypes"' to deal with the symver stuff.. Couldn't find
> a better way..
I was planning on adding a header to define them just to shut up
sparse. This is one of the bigger sets or remaining warnings, the
other beeing pthread macros abusing 0 as NULL (probably unfixable by us),
direct use of __sync_* builting (we should move over to C99 atomics or
something similar) nad various misc issues. But as non of them are trivial
I didn't want to send that with the patch bomb.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 03/17] hfi1verbs: mark symbols static where possible
[not found] ` <1476388576-22863-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
@ 2016-10-14 10:31 ` Dalessandro, Dennis
0 siblings, 0 replies; 24+ messages in thread
From: Dalessandro, Dennis @ 2016-10-14 10:31 UTC (permalink / raw)
To: hch-jcswGhMUV9g, linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Thu, 2016-10-13 at 21:56 +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> providers/hfi1verbs/hfiverbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/providers/hfi1verbs/hfiverbs.c
> b/providers/hfi1verbs/hfiverbs.c
> index e28afc7..7605347 100644
> --- a/providers/hfi1verbs/hfiverbs.c
> +++ b/providers/hfi1verbs/hfiverbs.c
> @@ -81,7 +81,7 @@
> { .vendor = PCI_VENDOR_ID_##v, \
> .device = PCI_DEVICE_ID_HFI_##d }
>
> -struct {
> +static struct {
> unsigned vendor;
> unsigned device;
> } hca_table[] = {
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH 04/17] ipathverbs: mark symbols static where possible
[not found] ` <1476388576-22863-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
@ 2016-10-14 10:32 ` Dalessandro, Dennis
0 siblings, 0 replies; 24+ messages in thread
From: Dalessandro, Dennis @ 2016-10-14 10:32 UTC (permalink / raw)
To: hch-jcswGhMUV9g, linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Thu, 2016-10-13 at 21:56 +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> providers/ipathverbs/ipathverbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/providers/ipathverbs/ipathverbs.c
> b/providers/ipathverbs/ipathverbs.c
> index 4b945f6..e953864 100644
> --- a/providers/ipathverbs/ipathverbs.c
> +++ b/providers/ipathverbs/ipathverbs.c
> @@ -77,7 +77,7 @@
> { .vendor = PCI_VENDOR_ID_##v, \
> .device = PCI_DEVICE_ID_INFINIPATH_##d }
>
> -struct {
> +static struct {
> unsigned vendor;
> unsigned device;
> } hca_table[] = {
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2016-10-14 10:32 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-13 19:55 sparse fixes, part2 Christoph Hellwig
[not found] ` <1476388576-22863-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-13 19:56 ` [PATCH 01/17] cxgb3: handle global variables properly Christoph Hellwig
[not found] ` <1476388576-22863-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-13 21:58 ` Steve Wise
2016-10-13 19:56 ` [PATCH 02/17] cxgb3: mark symbols static where possible Christoph Hellwig
[not found] ` <1476388576-22863-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-13 21:59 ` Steve Wise
2016-10-13 19:56 ` [PATCH 03/17] hfi1verbs: " Christoph Hellwig
[not found] ` <1476388576-22863-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-14 10:31 ` Dalessandro, Dennis
2016-10-13 19:56 ` [PATCH 04/17] ipathverbs: " Christoph Hellwig
[not found] ` <1476388576-22863-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-10-14 10:32 ` Dalessandro, Dennis
2016-10-13 19:56 ` [PATCH 05/17] i40iw: " Christoph Hellwig
2016-10-13 19:56 ` [PATCH 06/17] i40iw: remove unused variable i40iw_debug_level Christoph Hellwig
2016-10-13 19:56 ` [PATCH 07/17] mlx4: mark symbols static where possible Christoph Hellwig
2016-10-13 19:56 ` [PATCH 08/17] mthca: " Christoph Hellwig
2016-10-13 19:56 ` [PATCH 09/17] rxe: " Christoph Hellwig
2016-10-13 19:56 ` [PATCH 10/17] ocrdma: " Christoph Hellwig
2016-10-13 19:56 ` [PATCH 11/17] ocrdma: use NULL instead of 0 for NULL pointers Christoph Hellwig
2016-10-13 19:56 ` [PATCH 12/17] nes: move external declaration to nes_umain.h Christoph Hellwig
2016-10-13 19:56 ` [PATCH 13/17] nes: mark symbols static where possible Christoph Hellwig
2016-10-13 19:56 ` [PATCH 14/17] nes: use NULL instead of 0 for NULL pointers Christoph Hellwig
2016-10-13 19:56 ` [PATCH 15/17] mlx5: mark symbols static where possible Christoph Hellwig
2016-10-13 19:56 ` [PATCH 16/17] mlx5: use NULL instead of 0 for NULL pointers Christoph Hellwig
2016-10-13 19:56 ` [PATCH 17/17] mlx5: use proper ANSI-C prototypes for functions without arguments Christoph Hellwig
2016-10-14 4:06 ` sparse fixes, part2 Jason Gunthorpe
[not found] ` <20161014040602.GA5726-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-14 5:31 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.