From: Jan Beulich <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wl@xen.org>, "Julien Grall" <julien.grall@arm.com>,
Xen-devel <xen-devel@lists.xenproject.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 3/4] xen/percpu: Drop unused asm/percpu.h includes
Date: Mon, 29 Jul 2019 12:53:41 +0000 [thread overview]
Message-ID: <0452c476-3194-6465-baab-b645612fe2c8@suse.com> (raw)
In-Reply-To: <20190726210854.6408-4-andrew.cooper3@citrix.com>
On 26.07.2019 23:08, Andrew Cooper wrote:
> These files either don't use any PER_CPU() infrastructure at all, or use
> DEFINE_PER_CPU_*(). This is declared in xen/percpu.h, not asm/percpu.h, which
> means that xen/percpu.h is included via a different path.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
with a remark:
> --- a/xen/common/core_parking.c
> +++ b/xen/common/core_parking.c
> @@ -19,7 +19,7 @@
> #include <xen/cpu.h>
> #include <xen/init.h>
> #include <xen/cpumask.h>
> -#include <asm/percpu.h>
> +
> #include <asm/smp.h>
I don't believe in such blank lines to be overly useful,
especially when ...
> --- a/xen/include/xen/kexec.h
> +++ b/xen/include/xen/kexec.h
> @@ -4,7 +4,6 @@
> #ifdef CONFIG_KEXEC
>
> #include <public/kexec.h>
> -#include <asm/percpu.h>
> #include <xen/elfcore.h>
> #include <xen/kimage.h>
... this model isn't being followed consistently.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-29 13:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 21:08 [Xen-devel] [PATCH 0/4] xen/percpu: Cleanup Andrew Cooper
2019-07-26 21:08 ` [Xen-devel] [PATCH 1/4] arm/percpu: Move {get, set}_processor_id() into smp.h Andrew Cooper
2019-07-26 22:30 ` Julien Grall
2019-07-26 22:37 ` Andrew Cooper
2019-07-27 12:41 ` Julien Grall
2019-07-26 21:08 ` [Xen-devel] [PATCH 2/4] xen/percpu: Drop unused xen/percpu.h includes Andrew Cooper
2019-07-29 8:55 ` Roger Pau Monné
2019-07-29 12:50 ` Jan Beulich
2019-07-26 21:08 ` [Xen-devel] [PATCH 3/4] xen/percpu: Drop unused asm/percpu.h includes Andrew Cooper
2019-07-26 22:32 ` Julien Grall
2019-07-29 8:56 ` Roger Pau Monné
2019-07-29 12:53 ` Jan Beulich [this message]
2019-07-26 21:08 ` [Xen-devel] [PATCH 4/4] xen/percpu: Make DECLARE_PER_CPU() and __DEFINE_PER_CPU() common Andrew Cooper
2019-07-26 22:34 ` Julien Grall
2019-07-29 8:58 ` Roger Pau Monné
2019-07-29 13:00 ` Jan Beulich
2019-07-29 13:23 ` Andrew Cooper
2019-07-29 13:54 ` Jan Beulich
2019-07-29 18:03 ` Andrew Cooper
2019-07-30 8:11 ` Jan Beulich
2019-07-31 4:58 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0452c476-3194-6465-baab-b645612fe2c8@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.