Re: [Xen-devel] [PATCH 1/4] arm/percpu: Move {get, set}_processor_id() into smp.h

[Julien Grall <julien.grall@arm.com>]

Hi Andrew,

On 7/26/19 11:37 PM, Andrew Cooper wrote:
> On 26/07/2019 23:30, Julien Grall wrote:
>> Hi Andrew,
>>
>> Thank you for looking into this.
>>
>> On 7/26/19 10:08 PM, Andrew Cooper wrote:
>>> For cleanup purposes, it is necessary for asm/percpu.h to not use
>>> DECLARE_PER_CPU() itself.  asm/smp.h is arguably a better place for it to
>>> live anyway.
>> I have noticed that a lot of arch helpers called by common code
>> are defined in different headers. The most offenders are in mm.h
>> and page.h.
> 
> Those are massive rats nests.  At least we're slowly making progress on
> the outskirts.
> 
> Lonterm, I'd like to get to a position where the only time you'd ever
> include an asm/ header is either from the common header itself, or for
> headers unique to the current architecture.  I expect this to simplify
> things massively.
> 
>>
>> Looking at x86, the two helpers are defined in current.h. So I
>> think it would make sense to define them at the same places. I
>> don't have a particular preference between smp.h and current.h,
>> just want some consistency :).
>>
>> FWIW, Xen build nicely when the helpers are moved in current.h:
> 
> I did consider current.h, but couldn't decide and flipped a coin.
> 
> I'm perfectly happy to put it here if that's what you'd prefer.

I would prefer consistency with x86 so, current.h :). Feel free to 
re-use the diff I provided and add my acked-by.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel