[PATCH] drm: drm_memory: fix compiler warning on 32-bit targets

[PATCH] drm: drm_memory: fix compiler warning on 32-bit targets

[David Lechner]

The end field of struct resource is unsigned long, so on 32-bit targets,
this is a 32-bit value. This results in a compiler warning of "warning:
comparison of distinct pointer types lacks a cast". Fix it by making
max_iomem unsigned long to match the end field.

Fixes: (82626363a217 "drm: add func to get max iomem address v2")
Signed-off-by: David Lechner <david@lechnology.com>
---
 drivers/gpu/drm/drm_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
index 7ca500b..597f496 100644
--- a/drivers/gpu/drm/drm_memory.c
+++ b/drivers/gpu/drm/drm_memory.c
@@ -153,7 +153,7 @@ EXPORT_SYMBOL(drm_legacy_ioremapfree);
 u64 drm_get_max_iomem(void)
 {
 	struct resource *tmp;
-	u64 max_iomem = 0;
+	unsigned long max_iomem = 0;
 
 	for (tmp = iomem_resource.child; tmp; tmp = tmp->sibling) {
 		max_iomem = max(max_iomem,  tmp->end);
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: drm_memory: fix compiler warning on 32-bit targets

[David Lechner]

On 02/19/2018 05:00 PM, David Lechner wrote:
> The end field of struct resource is unsigned long, so on 32-bit targets,
> this is a 32-bit value. This results in a compiler warning of "warning:
> comparison of distinct pointer types lacks a cast". Fix it by making
> max_iomem unsigned long to match the end field.
> 
> Fixes: (82626363a217 "drm: add func to get max iomem address v2")
> Signed-off-by: David Lechner <david@lechnology.com>
> ---

Superseded by v2. I also made a mistake :-o
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel