* [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning
@ 2020-02-07 11:57 ` Gerd Hoffmann
0 siblings, 0 replies; 9+ messages in thread
From: Gerd Hoffmann @ 2020-02-07 11:57 UTC (permalink / raw)
To: dri-devel
Cc: marmarek, Gerd Hoffmann, David Airlie, Daniel Vetter,
open list:DRM DRIVER FOR BOCHS VIRTUAL GPU, open list
Shutdown of firmware framebuffer has a bunch of problems. Because
of this the framebuffer region might still be reserved even after
drm_fb_helper_remove_conflicting_pci_framebuffers() returned.
Don't consider pci_request_region() failure for the framebuffer
region as fatal error to workaround this issue.
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
drivers/gpu/drm/bochs/bochs_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c
index b615b7dfdd9d..a387efa9e559 100644
--- a/drivers/gpu/drm/bochs/bochs_hw.c
+++ b/drivers/gpu/drm/bochs/bochs_hw.c
@@ -157,8 +157,7 @@ int bochs_hw_init(struct drm_device *dev)
}
if (pci_request_region(pdev, 0, "bochs-drm") != 0) {
- DRM_ERROR("Cannot request framebuffer\n");
- return -EBUSY;
+ DRM_WARN("Cannot request framebuffer, boot framebuffer still active?\n");
}
bochs->fb_map = ioremap(addr, size);
--
2.18.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning
@ 2020-02-07 11:57 ` Gerd Hoffmann
0 siblings, 0 replies; 9+ messages in thread
From: Gerd Hoffmann @ 2020-02-07 11:57 UTC (permalink / raw)
To: dri-devel
Cc: marmarek, Gerd Hoffmann, David Airlie, Daniel Vetter,
open list:DRM DRIVER FOR BOCHS VIRTUAL GPU, open list
Shutdown of firmware framebuffer has a bunch of problems. Because
of this the framebuffer region might still be reserved even after
drm_fb_helper_remove_conflicting_pci_framebuffers() returned.
Don't consider pci_request_region() failure for the framebuffer
region as fatal error to workaround this issue.
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
drivers/gpu/drm/bochs/bochs_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c
index b615b7dfdd9d..a387efa9e559 100644
--- a/drivers/gpu/drm/bochs/bochs_hw.c
+++ b/drivers/gpu/drm/bochs/bochs_hw.c
@@ -157,8 +157,7 @@ int bochs_hw_init(struct drm_device *dev)
}
if (pci_request_region(pdev, 0, "bochs-drm") != 0) {
- DRM_ERROR("Cannot request framebuffer\n");
- return -EBUSY;
+ DRM_WARN("Cannot request framebuffer, boot framebuffer still active?\n");
}
bochs->fb_map = ioremap(addr, size);
--
2.18.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning
@ 2020-02-07 11:57 ` Gerd Hoffmann
0 siblings, 0 replies; 9+ messages in thread
From: Gerd Hoffmann @ 2020-02-07 11:57 UTC (permalink / raw)
To: dri-devel
Cc: marmarek, David Airlie, open list,
open list:DRM DRIVER FOR BOCHS VIRTUAL GPU, Gerd Hoffmann
Shutdown of firmware framebuffer has a bunch of problems. Because
of this the framebuffer region might still be reserved even after
drm_fb_helper_remove_conflicting_pci_framebuffers() returned.
Don't consider pci_request_region() failure for the framebuffer
region as fatal error to workaround this issue.
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
drivers/gpu/drm/bochs/bochs_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c
index b615b7dfdd9d..a387efa9e559 100644
--- a/drivers/gpu/drm/bochs/bochs_hw.c
+++ b/drivers/gpu/drm/bochs/bochs_hw.c
@@ -157,8 +157,7 @@ int bochs_hw_init(struct drm_device *dev)
}
if (pci_request_region(pdev, 0, "bochs-drm") != 0) {
- DRM_ERROR("Cannot request framebuffer\n");
- return -EBUSY;
+ DRM_WARN("Cannot request framebuffer, boot framebuffer still active?\n");
}
bochs->fb_map = ioremap(addr, size);
--
2.18.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning
2020-02-07 11:57 ` Gerd Hoffmann
(?)
@ 2020-02-07 12:06 ` Thomas Zimmermann
-1 siblings, 0 replies; 9+ messages in thread
From: Thomas Zimmermann @ 2020-02-07 12:06 UTC (permalink / raw)
To: Gerd Hoffmann, dri-devel
Cc: marmarek, David Airlie, open list,
open list:DRM DRIVER FOR BOCHS VIRTUAL GPU
[-- Attachment #1.1: Type: text/plain, Size: 1444 bytes --]
Hi
Am 07.02.20 um 12:57 schrieb Gerd Hoffmann:
> Shutdown of firmware framebuffer has a bunch of problems. Because
> of this the framebuffer region might still be reserved even after
> drm_fb_helper_remove_conflicting_pci_framebuffers() returned.
Out of curiosity: what's going wrong here?
Best regards
Thomas
>
> Don't consider pci_request_region() failure for the framebuffer
> region as fatal error to workaround this issue.
>
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> drivers/gpu/drm/bochs/bochs_hw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c
> index b615b7dfdd9d..a387efa9e559 100644
> --- a/drivers/gpu/drm/bochs/bochs_hw.c
> +++ b/drivers/gpu/drm/bochs/bochs_hw.c
> @@ -157,8 +157,7 @@ int bochs_hw_init(struct drm_device *dev)
> }
>
> if (pci_request_region(pdev, 0, "bochs-drm") != 0) {
> - DRM_ERROR("Cannot request framebuffer\n");
> - return -EBUSY;
> + DRM_WARN("Cannot request framebuffer, boot framebuffer still active?\n");
> }
>
> bochs->fb_map = ioremap(addr, size);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning
@ 2020-02-07 12:06 ` Thomas Zimmermann
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Zimmermann @ 2020-02-07 12:06 UTC (permalink / raw)
To: Gerd Hoffmann, dri-devel
Cc: marmarek, David Airlie, open list,
open list:DRM DRIVER FOR BOCHS VIRTUAL GPU
[-- Attachment #1.1: Type: text/plain, Size: 1444 bytes --]
Hi
Am 07.02.20 um 12:57 schrieb Gerd Hoffmann:
> Shutdown of firmware framebuffer has a bunch of problems. Because
> of this the framebuffer region might still be reserved even after
> drm_fb_helper_remove_conflicting_pci_framebuffers() returned.
Out of curiosity: what's going wrong here?
Best regards
Thomas
>
> Don't consider pci_request_region() failure for the framebuffer
> region as fatal error to workaround this issue.
>
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> drivers/gpu/drm/bochs/bochs_hw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c
> index b615b7dfdd9d..a387efa9e559 100644
> --- a/drivers/gpu/drm/bochs/bochs_hw.c
> +++ b/drivers/gpu/drm/bochs/bochs_hw.c
> @@ -157,8 +157,7 @@ int bochs_hw_init(struct drm_device *dev)
> }
>
> if (pci_request_region(pdev, 0, "bochs-drm") != 0) {
> - DRM_ERROR("Cannot request framebuffer\n");
> - return -EBUSY;
> + DRM_WARN("Cannot request framebuffer, boot framebuffer still active?\n");
> }
>
> bochs->fb_map = ioremap(addr, size);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning
@ 2020-02-07 12:06 ` Thomas Zimmermann
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Zimmermann @ 2020-02-07 12:06 UTC (permalink / raw)
To: Gerd Hoffmann, dri-devel
Cc: David Airlie, open list:DRM DRIVER FOR BOCHS VIRTUAL GPU,
marmarek, open list
[-- Attachment #1.1.1: Type: text/plain, Size: 1444 bytes --]
Hi
Am 07.02.20 um 12:57 schrieb Gerd Hoffmann:
> Shutdown of firmware framebuffer has a bunch of problems. Because
> of this the framebuffer region might still be reserved even after
> drm_fb_helper_remove_conflicting_pci_framebuffers() returned.
Out of curiosity: what's going wrong here?
Best regards
Thomas
>
> Don't consider pci_request_region() failure for the framebuffer
> region as fatal error to workaround this issue.
>
> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> drivers/gpu/drm/bochs/bochs_hw.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bochs/bochs_hw.c b/drivers/gpu/drm/bochs/bochs_hw.c
> index b615b7dfdd9d..a387efa9e559 100644
> --- a/drivers/gpu/drm/bochs/bochs_hw.c
> +++ b/drivers/gpu/drm/bochs/bochs_hw.c
> @@ -157,8 +157,7 @@ int bochs_hw_init(struct drm_device *dev)
> }
>
> if (pci_request_region(pdev, 0, "bochs-drm") != 0) {
> - DRM_ERROR("Cannot request framebuffer\n");
> - return -EBUSY;
> + DRM_WARN("Cannot request framebuffer, boot framebuffer still active?\n");
> }
>
> bochs->fb_map = ioremap(addr, size);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning
2020-02-07 12:06 ` Thomas Zimmermann
(?)
@ 2020-02-07 12:39 ` Gerd Hoffmann
-1 siblings, 0 replies; 9+ messages in thread
From: Gerd Hoffmann @ 2020-02-07 12:39 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: dri-devel, marmarek, David Airlie, open list,
open list:DRM DRIVER FOR BOCHS VIRTUAL GPU
On Fri, Feb 07, 2020 at 01:06:00PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 07.02.20 um 12:57 schrieb Gerd Hoffmann:
> > Shutdown of firmware framebuffer has a bunch of problems. Because
> > of this the framebuffer region might still be reserved even after
> > drm_fb_helper_remove_conflicting_pci_framebuffers() returned.
>
> Out of curiosity: what's going wrong here?
Very short version: userspace keeping /dev/fb0 open delays
firmware framebuffer deinit.
Long version by Daniel Vetter:
https://www.spinics.net/lists/linux-fbdev/msg28178.html
cheers,
Gerd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning
@ 2020-02-07 12:39 ` Gerd Hoffmann
0 siblings, 0 replies; 9+ messages in thread
From: Gerd Hoffmann @ 2020-02-07 12:39 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: dri-devel, marmarek, David Airlie, open list,
open list:DRM DRIVER FOR BOCHS VIRTUAL GPU
On Fri, Feb 07, 2020 at 01:06:00PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 07.02.20 um 12:57 schrieb Gerd Hoffmann:
> > Shutdown of firmware framebuffer has a bunch of problems. Because
> > of this the framebuffer region might still be reserved even after
> > drm_fb_helper_remove_conflicting_pci_framebuffers() returned.
>
> Out of curiosity: what's going wrong here?
Very short version: userspace keeping /dev/fb0 open delays
firmware framebuffer deinit.
Long version by Daniel Vetter:
https://www.spinics.net/lists/linux-fbdev/msg28178.html
cheers,
Gerd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning
@ 2020-02-07 12:39 ` Gerd Hoffmann
0 siblings, 0 replies; 9+ messages in thread
From: Gerd Hoffmann @ 2020-02-07 12:39 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: David Airlie, open list:DRM DRIVER FOR BOCHS VIRTUAL GPU,
marmarek, dri-devel, open list
On Fri, Feb 07, 2020 at 01:06:00PM +0100, Thomas Zimmermann wrote:
> Hi
>
> Am 07.02.20 um 12:57 schrieb Gerd Hoffmann:
> > Shutdown of firmware framebuffer has a bunch of problems. Because
> > of this the framebuffer region might still be reserved even after
> > drm_fb_helper_remove_conflicting_pci_framebuffers() returned.
>
> Out of curiosity: what's going wrong here?
Very short version: userspace keeping /dev/fb0 open delays
firmware framebuffer deinit.
Long version by Daniel Vetter:
https://www.spinics.net/lists/linux-fbdev/msg28178.html
cheers,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-02-07 12:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-07 11:57 [PATCH v2] drm/bochs: downgrade pci_request_region failure from error to warning Gerd Hoffmann
2020-02-07 11:57 ` Gerd Hoffmann
2020-02-07 11:57 ` Gerd Hoffmann
2020-02-07 12:06 ` Thomas Zimmermann
2020-02-07 12:06 ` Thomas Zimmermann
2020-02-07 12:06 ` Thomas Zimmermann
2020-02-07 12:39 ` Gerd Hoffmann
2020-02-07 12:39 ` Gerd Hoffmann
2020-02-07 12:39 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.