* [PATCH 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller
[not found] <CGME20220328014857epcms2p7d8cfd98d60f059916ef35ccc385bc004@epcms2p7>
@ 2022-03-28 1:48 ` 이왕석
0 siblings, 0 replies; 4+ messages in thread
From: 이왕석 @ 2022-03-28 1:48 UTC (permalink / raw)
To: robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson,
lars.persson
Cc: bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi,
kw, linux-arm-kernel, kernel, 전문기
Add description to support Axis, ARTPEC-8 SoC.
ARTPEC-8 is the SoC platform of Axis Communications
and PCIe controller is designed based on Design-Ware PCIe controller.
Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com>
---
.../bindings/pci/axis,artpec8-pcie-ep.yaml | 110 +++++++++++++++++++
.../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 117 +++++++++++++++++++++
2 files changed, 227 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml
diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
new file mode 100644
index 0000000..dc66965
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
@@ -0,0 +1,110 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie-ep.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ARTPEC-8 SoC PCIe Controller Device Tree Bindings
+
+maintainers:
+ - Jesper Nilsson <jesper.nilsson@axis.com>
+
+description: |+
+ This PCIe end-point controller is based on the Synopsys DesignWare PCIe IP
+ and thus inherits all the common properties defined in snps,dw-pcie-ep.yaml.
+
+allOf:
+ - $ref: /schemas/pci/snps,dw-pcie-ep.yaml#
+
+properties:
+ compatible:
+ const: axis,artpec8-pcie-ep
+
+ reg:
+ items:
+ - description: Data Bus Interface (DBI) registers.
+ - description: Data Bus Interface (DBI2) registers.
+ - description: PCIe address space region.
+
+ reg-names:
+ items:
+ - const: dbi
+ - const: dbi2
+ - const: addr_space
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: PIPE clock, used by the controller to clock the PIPE
+ - description: PCIe dbi clock, ungated version
+ - description: PCIe master clock, ungated version
+ - description: PCIe slave clock, ungated version
+
+ clock-names:
+ items:
+ - const: pipe_clk
+ - const: dbi_clk
+ - const: mstr_clk
+ - const: slv_clk
+
+ phys:
+ maxItems: 1
+
+ num-lanes:
+ const: 2
+
+required:
+ - clocks
+ - clock-names
+ - reg
+ - reg-names
+ - num-lanes
+ - bus-range
+ - interrupts
+ - interrupt-names
+ - samsung,fsys-sysreg
+ - samsung,syscon-phandle
+ - samsung,syscon-bus-s-fsys
+ - samsung,syscon-bus-p-fsys
+ - phys
+ - phy-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ artec8 {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ pcie_ep: pcie-ep@17200000 {
+ compatible = "axis,artpec8-pcie-ep";
+ clocks = <&clock_cmu_fsys 39>,
+ <&clock_cmu_fsys 38>,
+ <&clock_cmu_fsys 37>,
+ <&clock_cmu_fsys 36>;
+ clock-names = "pipe_clk", "dbi_clk", "mstr_clk", "slv_clk";
+ reg = <0x0 0x17200000 0x0 0x1000>,
+ <0x0 0x17201000 0x0 0x1000>,
+ <0x2 0x00000000 0x6 0x00000000>;
+ reg-names = "dbi", "dbi2", "addr_space";
+ num-lanes = <2>;
+ bus-range = <0x00 0xff>;
+ interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "intr";
+ #interrupt-cells = <1>;
+ num-ib-windows = <16>;
+ num-ob-windows = <16>;
+ samsung,fsys-sysreg = <&syscon_fsys>;
+ samsung,syscon-phandle = <&pmu_system_controller>;
+ samsung,syscon-bus-s-fsys = <&syscon_bus_s_fsys>;
+ samsung,syscon-bus-p-fsys = <&syscon_bus_p_fsys>;
+ phys = <&pcie_phy>;
+ phy-names = "pcie_phy";
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml
new file mode 100644
index 0000000..b2cff0a
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml
@@ -0,0 +1,117 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Artpec-8 SoC PCIe Controller Device Tree Bindings
+
+maintainers:
+ - Jesper Nilsson <jesper.nilsson@axis.com>
+
+description: |+
+ This PCIe host controller is based on the Synopsys DesignWare PCIe IP
+ and thus inherits all the common properties defined in snps,dw-pcie.yaml.
+
+allOf:
+ - $ref: /schemas/pci/snps,dw-pcie.yaml#
+
+properties:
+ compatible:
+ const: axis,artpec8-pcie
+
+ reg:
+ items:
+ - description: Data Bus Interface (DBI) registers.
+ - description: External Local Bus interface (ELBI) registers.
+ - description: PCIe configuration space region.
+
+ reg-names:
+ items:
+ - const: dbi
+ - const: elbi
+ - const: config
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: PIPE clock, used by the controller to clock the PIPE
+ - description: PCIe dbi clock, ungated version
+ - description: PCIe master clock, ungated version
+ - description: PCIe slave clock, ungated version
+
+ clock-names:
+ items:
+ - const: pipe_clk
+ - const: dbi_clk
+ - const: mstr_clk
+ - const: slv_clk
+
+ phys:
+ maxItems: 1
+
+ num-lanes:
+ const: 2
+
+required:
+ - clocks
+ - clock-names
+ - reg
+ - reg-names
+ - device_type
+ - ranges
+ - num-lanes
+ - bus-range
+ - interrupts
+ - interrupt-names
+ - samsung,fsys-sysreg
+ - samsung,syscon-phandle
+ - samsung,syscon-bus-s-fsys
+ - samsung,syscon-bus-p-fsys
+ - phys
+ - phy-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ artec8 {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ pcie: pcie@17200000 {
+ compatible = "axis,artpec8-pcie";
+ reg = <0x0 0x17200000 0x0 0x1000>,
+ <0x0 0x16ca0000 0x0 0x2000>,
+ <0x7 0x0001e000 0x0 0x2000>;
+ reg-names = "dbi", "elbi", "config";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ device_type = "pci";
+ ranges = </* non-prefetchable memory */
+ 0x83000000 0x0 0x0000000 0x2 0x00000000 0x5 0x00000000
+ /* downstream I/O */
+ 0x81000000 0x0 0x0000000 0x7 0x00000000 0x0 0x00010000>;
+ num-lanes = <2>;
+ bus-range = <0x00 0xff>;
+ interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "intr";
+ #interrupt-cells = <1>;
+ samsung,fsys-sysreg = <&syscon_fsys>;
+ samsung,syscon-phandle = <&pmu_system_controller>;
+ samsung,syscon-bus-s-fsys = <&syscon_bus_s_fsys>;
+ samsung,syscon-bus-p-fsys = <&syscon_bus_p_fsys>;
+ clocks = <&cmu_fsys 39>,
+ <&cmu_fsys 38>,
+ <&cmu_fsys 37>,
+ <&cmu_fsys 36>;
+ clock-names = "pipe_clk", "dbi_clk", "mstr_clk", "slv_clk";
+ phys = <&pcie_phy>;
+ phy-names = "pcie_phy";
+ };
+ };
+...
--
2.9.5
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller
@ 2022-03-28 1:48 ` 이왕석
0 siblings, 0 replies; 4+ messages in thread
From: 이왕석 @ 2022-03-28 1:48 UTC (permalink / raw)
To: robh+dt, krzk+dt, kishon, vkoul, linux-kernel, jesper.nilsson,
lars.persson
Cc: bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi,
kw, linux-arm-kernel, kernel, 전문기
Add description to support Axis, ARTPEC-8 SoC.
ARTPEC-8 is the SoC platform of Axis Communications
and PCIe controller is designed based on Design-Ware PCIe controller.
Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com>
---
.../bindings/pci/axis,artpec8-pcie-ep.yaml | 110 +++++++++++++++++++
.../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 117 +++++++++++++++++++++
2 files changed, 227 insertions(+)
create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml
diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
new file mode 100644
index 0000000..dc66965
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
@@ -0,0 +1,110 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie-ep.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ARTPEC-8 SoC PCIe Controller Device Tree Bindings
+
+maintainers:
+ - Jesper Nilsson <jesper.nilsson@axis.com>
+
+description: |+
+ This PCIe end-point controller is based on the Synopsys DesignWare PCIe IP
+ and thus inherits all the common properties defined in snps,dw-pcie-ep.yaml.
+
+allOf:
+ - $ref: /schemas/pci/snps,dw-pcie-ep.yaml#
+
+properties:
+ compatible:
+ const: axis,artpec8-pcie-ep
+
+ reg:
+ items:
+ - description: Data Bus Interface (DBI) registers.
+ - description: Data Bus Interface (DBI2) registers.
+ - description: PCIe address space region.
+
+ reg-names:
+ items:
+ - const: dbi
+ - const: dbi2
+ - const: addr_space
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: PIPE clock, used by the controller to clock the PIPE
+ - description: PCIe dbi clock, ungated version
+ - description: PCIe master clock, ungated version
+ - description: PCIe slave clock, ungated version
+
+ clock-names:
+ items:
+ - const: pipe_clk
+ - const: dbi_clk
+ - const: mstr_clk
+ - const: slv_clk
+
+ phys:
+ maxItems: 1
+
+ num-lanes:
+ const: 2
+
+required:
+ - clocks
+ - clock-names
+ - reg
+ - reg-names
+ - num-lanes
+ - bus-range
+ - interrupts
+ - interrupt-names
+ - samsung,fsys-sysreg
+ - samsung,syscon-phandle
+ - samsung,syscon-bus-s-fsys
+ - samsung,syscon-bus-p-fsys
+ - phys
+ - phy-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ artec8 {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ pcie_ep: pcie-ep@17200000 {
+ compatible = "axis,artpec8-pcie-ep";
+ clocks = <&clock_cmu_fsys 39>,
+ <&clock_cmu_fsys 38>,
+ <&clock_cmu_fsys 37>,
+ <&clock_cmu_fsys 36>;
+ clock-names = "pipe_clk", "dbi_clk", "mstr_clk", "slv_clk";
+ reg = <0x0 0x17200000 0x0 0x1000>,
+ <0x0 0x17201000 0x0 0x1000>,
+ <0x2 0x00000000 0x6 0x00000000>;
+ reg-names = "dbi", "dbi2", "addr_space";
+ num-lanes = <2>;
+ bus-range = <0x00 0xff>;
+ interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "intr";
+ #interrupt-cells = <1>;
+ num-ib-windows = <16>;
+ num-ob-windows = <16>;
+ samsung,fsys-sysreg = <&syscon_fsys>;
+ samsung,syscon-phandle = <&pmu_system_controller>;
+ samsung,syscon-bus-s-fsys = <&syscon_bus_s_fsys>;
+ samsung,syscon-bus-p-fsys = <&syscon_bus_p_fsys>;
+ phys = <&pcie_phy>;
+ phy-names = "pcie_phy";
+ };
+ };
+...
diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml
new file mode 100644
index 0000000..b2cff0a
--- /dev/null
+++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml
@@ -0,0 +1,117 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Artpec-8 SoC PCIe Controller Device Tree Bindings
+
+maintainers:
+ - Jesper Nilsson <jesper.nilsson@axis.com>
+
+description: |+
+ This PCIe host controller is based on the Synopsys DesignWare PCIe IP
+ and thus inherits all the common properties defined in snps,dw-pcie.yaml.
+
+allOf:
+ - $ref: /schemas/pci/snps,dw-pcie.yaml#
+
+properties:
+ compatible:
+ const: axis,artpec8-pcie
+
+ reg:
+ items:
+ - description: Data Bus Interface (DBI) registers.
+ - description: External Local Bus interface (ELBI) registers.
+ - description: PCIe configuration space region.
+
+ reg-names:
+ items:
+ - const: dbi
+ - const: elbi
+ - const: config
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: PIPE clock, used by the controller to clock the PIPE
+ - description: PCIe dbi clock, ungated version
+ - description: PCIe master clock, ungated version
+ - description: PCIe slave clock, ungated version
+
+ clock-names:
+ items:
+ - const: pipe_clk
+ - const: dbi_clk
+ - const: mstr_clk
+ - const: slv_clk
+
+ phys:
+ maxItems: 1
+
+ num-lanes:
+ const: 2
+
+required:
+ - clocks
+ - clock-names
+ - reg
+ - reg-names
+ - device_type
+ - ranges
+ - num-lanes
+ - bus-range
+ - interrupts
+ - interrupt-names
+ - samsung,fsys-sysreg
+ - samsung,syscon-phandle
+ - samsung,syscon-bus-s-fsys
+ - samsung,syscon-bus-p-fsys
+ - phys
+ - phy-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ artec8 {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ pcie: pcie@17200000 {
+ compatible = "axis,artpec8-pcie";
+ reg = <0x0 0x17200000 0x0 0x1000>,
+ <0x0 0x16ca0000 0x0 0x2000>,
+ <0x7 0x0001e000 0x0 0x2000>;
+ reg-names = "dbi", "elbi", "config";
+ #address-cells = <3>;
+ #size-cells = <2>;
+ device_type = "pci";
+ ranges = </* non-prefetchable memory */
+ 0x83000000 0x0 0x0000000 0x2 0x00000000 0x5 0x00000000
+ /* downstream I/O */
+ 0x81000000 0x0 0x0000000 0x7 0x00000000 0x0 0x00010000>;
+ num-lanes = <2>;
+ bus-range = <0x00 0xff>;
+ interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "intr";
+ #interrupt-cells = <1>;
+ samsung,fsys-sysreg = <&syscon_fsys>;
+ samsung,syscon-phandle = <&pmu_system_controller>;
+ samsung,syscon-bus-s-fsys = <&syscon_bus_s_fsys>;
+ samsung,syscon-bus-p-fsys = <&syscon_bus_p_fsys>;
+ clocks = <&cmu_fsys 39>,
+ <&cmu_fsys 38>,
+ <&cmu_fsys 37>,
+ <&cmu_fsys 36>;
+ clock-names = "pipe_clk", "dbi_clk", "mstr_clk", "slv_clk";
+ phys = <&pcie_phy>;
+ phy-names = "pcie_phy";
+ };
+ };
+...
--
2.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller
2022-03-28 1:48 ` 이왕석
@ 2022-03-28 18:41 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-28 18:41 UTC (permalink / raw)
To: wangseok.lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel,
jesper.nilsson, lars.persson
Cc: bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi,
kw, linux-arm-kernel, kernel, 전문기
On 28/03/2022 03:48, 이왕석 wrote:
> Add description to support Axis, ARTPEC-8 SoC.
> ARTPEC-8 is the SoC platform of Axis Communications
> and PCIe controller is designed based on Design-Ware PCIe controller.
>
> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com>
> ---
> .../bindings/pci/axis,artpec8-pcie-ep.yaml | 110 +++++++++++++++++++
> .../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 117 +++++++++++++++++++++
> 2 files changed, 227 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml
>
> diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
> new file mode 100644
> index 0000000..dc66965
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
> @@ -0,0 +1,110 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie-ep.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARTPEC-8 SoC PCIe Controller Device Tree Bindings
> +
> +maintainers:
> + - Jesper Nilsson <jesper.nilsson@axis.com>
> +
> +description: |+
> + This PCIe end-point controller is based on the Synopsys DesignWare PCIe IP
> + and thus inherits all the common properties defined in snps,dw-pcie-ep.yaml.
> +
> +allOf:
> + - $ref: /schemas/pci/snps,dw-pcie-ep.yaml#
> +
> +properties:
> + compatible:
> + const: axis,artpec8-pcie-ep
> +
> + reg:
> + items:
> + - description: Data Bus Interface (DBI) registers.
> + - description: Data Bus Interface (DBI2) registers.
> + - description: PCIe address space region.
> +
> + reg-names:
> + items:
> + - const: dbi
> + - const: dbi2
> + - const: addr_space
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: PIPE clock, used by the controller to clock the PIPE
> + - description: PCIe dbi clock, ungated version
> + - description: PCIe master clock, ungated version
> + - description: PCIe slave clock, ungated version
> +
> + clock-names:
> + items:
> + - const: pipe_clk
> + - const: dbi_clk
> + - const: mstr_clk
> + - const: slv_clk
> +
> + phys:
> + maxItems: 1
> +
> + num-lanes:
> + const: 2
> +
> +required:
compatible
> + - clocks
> + - clock-names
> + - reg
> + - reg-names
> + - num-lanes
> + - bus-range
> + - interrupts
> + - interrupt-names
> + - samsung,fsys-sysreg
> + - samsung,syscon-phandle
> + - samsung,syscon-bus-s-fsys
> + - samsung,syscon-bus-p-fsys
Why are they here but not in properties? Other properties are also
present here but not in properties.
> + - phys
> + - phy-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + artec8 {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + pcie_ep: pcie-ep@17200000 {
> + compatible = "axis,artpec8-pcie-ep";
> + clocks = <&clock_cmu_fsys 39>,
> + <&clock_cmu_fsys 38>,
> + <&clock_cmu_fsys 37>,
> + <&clock_cmu_fsys 36>;
Align the indentation of continued lines/entries.
> + clock-names = "pipe_clk", "dbi_clk", "mstr_clk", "slv_clk";
> + reg = <0x0 0x17200000 0x0 0x1000>,
Put reg after compatible.
> + <0x0 0x17201000 0x0 0x1000>,
> + <0x2 0x00000000 0x6 0x00000000>;
> + reg-names = "dbi", "dbi2", "addr_space";
> + num-lanes = <2>;
> + bus-range = <0x00 0xff>;
> + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "intr";
> + #interrupt-cells = <1>;
> + num-ib-windows = <16>;
> + num-ob-windows = <16>;
Did you test the bindings with `make dt_binding_check`?
All comments apply also to your second file.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller
@ 2022-03-28 18:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-28 18:41 UTC (permalink / raw)
To: wangseok.lee, robh+dt, krzk+dt, kishon, vkoul, linux-kernel,
jesper.nilsson, lars.persson
Cc: bhelgaas, linux-phy, linux-pci, devicetree, lorenzo.pieralisi,
kw, linux-arm-kernel, kernel, 전문기
On 28/03/2022 03:48, 이왕석 wrote:
> Add description to support Axis, ARTPEC-8 SoC.
> ARTPEC-8 is the SoC platform of Axis Communications
> and PCIe controller is designed based on Design-Ware PCIe controller.
>
> Signed-off-by: Wangseok Lee <wangseok.lee@samsung.com>
> ---
> .../bindings/pci/axis,artpec8-pcie-ep.yaml | 110 +++++++++++++++++++
> .../devicetree/bindings/pci/axis,artpec8-pcie.yaml | 117 +++++++++++++++++++++
> 2 files changed, 227 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
> create mode 100644 Documentation/devicetree/bindings/pci/axis,artpec8-pcie.yaml
>
> diff --git a/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
> new file mode 100644
> index 0000000..dc66965
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/axis,artpec8-pcie-ep.yaml
> @@ -0,0 +1,110 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pci/axis,artpec8-pcie-ep.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARTPEC-8 SoC PCIe Controller Device Tree Bindings
> +
> +maintainers:
> + - Jesper Nilsson <jesper.nilsson@axis.com>
> +
> +description: |+
> + This PCIe end-point controller is based on the Synopsys DesignWare PCIe IP
> + and thus inherits all the common properties defined in snps,dw-pcie-ep.yaml.
> +
> +allOf:
> + - $ref: /schemas/pci/snps,dw-pcie-ep.yaml#
> +
> +properties:
> + compatible:
> + const: axis,artpec8-pcie-ep
> +
> + reg:
> + items:
> + - description: Data Bus Interface (DBI) registers.
> + - description: Data Bus Interface (DBI2) registers.
> + - description: PCIe address space region.
> +
> + reg-names:
> + items:
> + - const: dbi
> + - const: dbi2
> + - const: addr_space
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: PIPE clock, used by the controller to clock the PIPE
> + - description: PCIe dbi clock, ungated version
> + - description: PCIe master clock, ungated version
> + - description: PCIe slave clock, ungated version
> +
> + clock-names:
> + items:
> + - const: pipe_clk
> + - const: dbi_clk
> + - const: mstr_clk
> + - const: slv_clk
> +
> + phys:
> + maxItems: 1
> +
> + num-lanes:
> + const: 2
> +
> +required:
compatible
> + - clocks
> + - clock-names
> + - reg
> + - reg-names
> + - num-lanes
> + - bus-range
> + - interrupts
> + - interrupt-names
> + - samsung,fsys-sysreg
> + - samsung,syscon-phandle
> + - samsung,syscon-bus-s-fsys
> + - samsung,syscon-bus-p-fsys
Why are they here but not in properties? Other properties are also
present here but not in properties.
> + - phys
> + - phy-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + artec8 {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + pcie_ep: pcie-ep@17200000 {
> + compatible = "axis,artpec8-pcie-ep";
> + clocks = <&clock_cmu_fsys 39>,
> + <&clock_cmu_fsys 38>,
> + <&clock_cmu_fsys 37>,
> + <&clock_cmu_fsys 36>;
Align the indentation of continued lines/entries.
> + clock-names = "pipe_clk", "dbi_clk", "mstr_clk", "slv_clk";
> + reg = <0x0 0x17200000 0x0 0x1000>,
Put reg after compatible.
> + <0x0 0x17201000 0x0 0x1000>,
> + <0x2 0x00000000 0x6 0x00000000>;
> + reg-names = "dbi", "dbi2", "addr_space";
> + num-lanes = <2>;
> + bus-range = <0x00 0xff>;
> + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "intr";
> + #interrupt-cells = <1>;
> + num-ib-windows = <16>;
> + num-ob-windows = <16>;
Did you test the bindings with `make dt_binding_check`?
All comments apply also to your second file.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-28 18:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20220328014857epcms2p7d8cfd98d60f059916ef35ccc385bc004@epcms2p7>
2022-03-28 1:48 ` [PATCH 1/5] dt-bindings: pci: Add ARTPEC-8 PCIe controller 이왕석
2022-03-28 1:48 ` 이왕석
2022-03-28 18:41 ` Krzysztof Kozlowski
2022-03-28 18:41 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.