All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: davinci: board-dm355-evm: fix broken networking
@ 2018-04-25  9:23 Sekhar Nori
  2018-05-01 11:50 ` Sekhar Nori
  0 siblings, 1 reply; 2+ messages in thread
From: Sekhar Nori @ 2018-04-25  9:23 UTC (permalink / raw)
  To: linux-arm-kernel

Since commit 09f3756bb9a8 ("dm9000: Return an ERR_PTR() in all
error conditions of dm9000_parse_dt()"), passing either non-NULL
platform data or device-tree for dm9000 driver to probe is
mandatory.

DM335 board was using none, so networking failed to initialize.
Fix it by passing non-NULL (but empty) platform data.

Fixes: 09f3756bb9a8 ("dm9000: Return an ERR_PTR() in all error conditions of dm9000_parse_dt()")
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/mach-davinci/board-dm355-evm.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
index 14557f893798..d04381d3f05b 100644
--- a/arch/arm/mach-davinci/board-dm355-evm.c
+++ b/arch/arm/mach-davinci/board-dm355-evm.c
@@ -19,6 +19,7 @@
 #include <linux/gpio.h>
 #include <linux/gpio/machine.h>
 #include <linux/clk.h>
+#include <linux/dm9000.h>
 #include <linux/videodev2.h>
 #include <media/i2c/tvp514x.h>
 #include <linux/spi/spi.h>
@@ -179,11 +180,16 @@ static struct resource dm355evm_dm9000_rsrc[] = {
 	},
 };
 
+static struct dm9000_plat_data dm335evm_dm9000_platdata;
+
 static struct platform_device dm355evm_dm9000 = {
 	.name		= "dm9000",
 	.id		= -1,
 	.resource	= dm355evm_dm9000_rsrc,
 	.num_resources	= ARRAY_SIZE(dm355evm_dm9000_rsrc),
+	.dev		= {
+		.platform_data = &dm335evm_dm9000_platdata,
+	},
 };
 
 static struct tvp514x_platform_data tvp5146_pdata = {
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: davinci: board-dm355-evm: fix broken networking
  2018-04-25  9:23 [PATCH] ARM: davinci: board-dm355-evm: fix broken networking Sekhar Nori
@ 2018-05-01 11:50 ` Sekhar Nori
  0 siblings, 0 replies; 2+ messages in thread
From: Sekhar Nori @ 2018-05-01 11:50 UTC (permalink / raw)
  To: linux-arm-kernel

On Wednesday 25 April 2018 02:53 PM, Sekhar Nori wrote:
> Since commit 09f3756bb9a8 ("dm9000: Return an ERR_PTR() in all
> error conditions of dm9000_parse_dt()"), passing either non-NULL
> platform data or device-tree for dm9000 driver to probe is
> mandatory.
> 
> DM335 board was using none, so networking failed to initialize.
> Fix it by passing non-NULL (but empty) platform data.
> 
> Fixes: 09f3756bb9a8 ("dm9000: Return an ERR_PTR() in all error conditions of dm9000_parse_dt()")
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

Applied to fixes.

Thanks,
Sekhar

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-01 11:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-25  9:23 [PATCH] ARM: davinci: board-dm355-evm: fix broken networking Sekhar Nori
2018-05-01 11:50 ` Sekhar Nori

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.