From: Julien Grall <julien.grall@arm.com>
To: Dario Faggioli <dfaggioli@suse.com>,
Andrii Anisov <andrii.anisov@gmail.com>,
xen-devel@lists.xen.org
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Andrii Anisov <andrii_anisov@epam.com>
Subject: Re: [PATCH] xen:arm: we never get into schedule_tail() with prev==current
Date: Thu, 16 May 2019 16:48:38 +0100 [thread overview]
Message-ID: <0493d376-43a5-7b57-4c69-6040f260ff7e@arm.com> (raw)
In-Reply-To: <d4876c22d85f1af7bac22213942c611b1043acf4.camel@suse.com>
Hi,
On 08/05/2019 12:25, Dario Faggioli wrote:
> On Wed, 2019-05-08 at 12:59 +0300, Andrii Anisov wrote:
>> From: Andrii Anisov <andrii_anisov@epam.com>
>>
>> ARM's schedule_tail() is called from two places: context_switch() and
>> continue_new_vcpu(). Both functions are always called with
>> prev!=current. So replace the correspondent check in schedule_tail()
>> with ASSERT() which is the development (debug) build guard.
>>
>> Signed-off-by: Andrii Anisov <andrii_anisov@epam.com>
>>
> FWIW,
>
> Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
Acked-by: Julien Grall <julien.grall@arm.com>
I have now committed the patch.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Dario Faggioli <dfaggioli@suse.com>,
Andrii Anisov <andrii.anisov@gmail.com>,
xen-devel@lists.xen.org
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Andrii Anisov <andrii_anisov@epam.com>
Subject: Re: [Xen-devel] [PATCH] xen:arm: we never get into schedule_tail() with prev==current
Date: Thu, 16 May 2019 16:48:38 +0100 [thread overview]
Message-ID: <0493d376-43a5-7b57-4c69-6040f260ff7e@arm.com> (raw)
Message-ID: <20190516154838.w11oEFAhkBYp2jc_GkOe4ucxWgCoxB52RyCbK1I0s4E@z> (raw)
In-Reply-To: <d4876c22d85f1af7bac22213942c611b1043acf4.camel@suse.com>
Hi,
On 08/05/2019 12:25, Dario Faggioli wrote:
> On Wed, 2019-05-08 at 12:59 +0300, Andrii Anisov wrote:
>> From: Andrii Anisov <andrii_anisov@epam.com>
>>
>> ARM's schedule_tail() is called from two places: context_switch() and
>> continue_new_vcpu(). Both functions are always called with
>> prev!=current. So replace the correspondent check in schedule_tail()
>> with ASSERT() which is the development (debug) build guard.
>>
>> Signed-off-by: Andrii Anisov <andrii_anisov@epam.com>
>>
> FWIW,
>
> Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
Acked-by: Julien Grall <julien.grall@arm.com>
I have now committed the patch.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-16 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 9:59 [PATCH] xen:arm: we never get into schedule_tail() with prev==current Andrii Anisov
2019-05-08 9:59 ` [Xen-devel] " Andrii Anisov
2019-05-08 11:25 ` Dario Faggioli
2019-05-08 11:25 ` [Xen-devel] " Dario Faggioli
2019-05-16 15:48 ` Julien Grall [this message]
2019-05-16 15:48 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0493d376-43a5-7b57-4c69-6040f260ff7e@arm.com \
--to=julien.grall@arm.com \
--cc=andrii.anisov@gmail.com \
--cc=andrii_anisov@epam.com \
--cc=dfaggioli@suse.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.