* [U-Boot] [PATCH] led: bcm6328: read base address in the parent node
@ 2018-06-28 13:26 Philippe Reynes
2018-06-29 15:31 ` Daniel Schwierzeck
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Reynes @ 2018-06-28 13:26 UTC (permalink / raw)
To: u-boot
In the device tree, the address for the led is located
in the parent node (for exemple leds), not in the led node
(for exemple led at 0).
The commit "led: bcm6328: convert to use live dt"
(sha1: 899455176058d673887a762aa38853188a030af4)
change this behaviour and read the address in the led node.
We fix this by reading the base address for led
in the parent node.
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
---
drivers/led/led_bcm6328.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/led/led_bcm6328.c b/drivers/led/led_bcm6328.c
index a29e5a0..7be4bad 100644
--- a/drivers/led/led_bcm6328.c
+++ b/drivers/led/led_bcm6328.c
@@ -173,7 +173,7 @@ static int bcm6328_led_probe(struct udevice *dev)
struct bcm6328_led_priv *priv = dev_get_priv(dev);
unsigned int pin;
- priv->regs = dev_remap_addr(dev);
+ priv->regs = dev_remap_addr(dev_get_parent(dev));
if (!priv->regs)
return -EINVAL;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] led: bcm6328: read base address in the parent node
2018-06-28 13:26 [U-Boot] [PATCH] led: bcm6328: read base address in the parent node Philippe Reynes
@ 2018-06-29 15:31 ` Daniel Schwierzeck
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Schwierzeck @ 2018-06-29 15:31 UTC (permalink / raw)
To: u-boot
On 28.06.2018 15:26, Philippe Reynes wrote:
> In the device tree, the address for the led is located
> in the parent node (for exemple leds), not in the led node
> (for exemple led at 0).
>
> The commit "led: bcm6328: convert to use live dt"
> (sha1: 899455176058d673887a762aa38853188a030af4)
> change this behaviour and read the address in the led node.
>
> We fix this by reading the base address for led
> in the parent node.
>
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
> ---
> drivers/led/led_bcm6328.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
applied to u-boot-mips, thanks.
--
- Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180629/279e8c37/attachment.sig>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-29 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-28 13:26 [U-Boot] [PATCH] led: bcm6328: read base address in the parent node Philippe Reynes
2018-06-29 15:31 ` Daniel Schwierzeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.