[PATCH v2 0/4] Reenable VFIO support on POWER systems

[PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

This patch series reenables VFIO support on POWER systems.  It
is based on Alexey Kardashevskiys's patch series, rebased and
successfully tested under QEMU with a Marvell PCIe SATA controller
on a POWER9 Blackbird host.

Alexey Kardashevskiy (3):
  powerpc/iommu: Add "borrowing" iommu_table_group_ops
  powerpc/pci_64: Init pcibios subsys a bit later
  powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
    domains

Timothy Pearson (1):
  Add myself to MAINTAINERS for Power VFIO support

 MAINTAINERS                               |   5 +
 arch/powerpc/include/asm/iommu.h          |   6 +-
 arch/powerpc/include/asm/pci-bridge.h     |   7 +
 arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
 arch/powerpc/kernel/pci_64.c              |   2 +-
 arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
 arch/powerpc/platforms/pseries/iommu.c    |  27 +++
 arch/powerpc/platforms/pseries/pseries.h  |   4 +
 arch/powerpc/platforms/pseries/setup.c    |   3 +
 drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
 10 files changed, 338 insertions(+), 94 deletions(-)

-- 
2.30.2

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Alex Williamson]

On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
Timothy Pearson <tpearson@raptorengineering.com> wrote:

> This patch series reenables VFIO support on POWER systems.  It
> is based on Alexey Kardashevskiys's patch series, rebased and
> successfully tested under QEMU with a Marvell PCIe SATA controller
> on a POWER9 Blackbird host.
> 
> Alexey Kardashevskiy (3):
>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>   powerpc/pci_64: Init pcibios subsys a bit later
>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>     domains
> 
> Timothy Pearson (1):
>   Add myself to MAINTAINERS for Power VFIO support
> 
>  MAINTAINERS                               |   5 +
>  arch/powerpc/include/asm/iommu.h          |   6 +-
>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>  arch/powerpc/kernel/pci_64.c              |   2 +-
>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>  10 files changed, 338 insertions(+), 94 deletions(-)
> 

For vfio and MAINTAINERS portions,

Acked-by: Alex Williamson <alex.williamson@redhat.com>

I'll note though that spapr_tce_take_ownership() looks like it copied a
bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
are tested before calling iommu_take_ownership() but not in the unwind
loop, ie. tables we might have skipped on setup are unconditionally
released on unwind.  Thanks,

Alex

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Alex Williamson]

On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
Timothy Pearson <tpearson@raptorengineering.com> wrote:

> This patch series reenables VFIO support on POWER systems.  It
> is based on Alexey Kardashevskiys's patch series, rebased and
> successfully tested under QEMU with a Marvell PCIe SATA controller
> on a POWER9 Blackbird host.
> 
> Alexey Kardashevskiy (3):
>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>   powerpc/pci_64: Init pcibios subsys a bit later
>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>     domains
> 
> Timothy Pearson (1):
>   Add myself to MAINTAINERS for Power VFIO support
> 
>  MAINTAINERS                               |   5 +
>  arch/powerpc/include/asm/iommu.h          |   6 +-
>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>  arch/powerpc/kernel/pci_64.c              |   2 +-
>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>  10 files changed, 338 insertions(+), 94 deletions(-)
> 

For vfio and MAINTAINERS portions,

Acked-by: Alex Williamson <alex.williamson@redhat.com>

I'll note though that spapr_tce_take_ownership() looks like it copied a
bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
are tested before calling iommu_take_ownership() but not in the unwind
loop, ie. tables we might have skipped on setup are unconditionally
released on unwind.  Thanks,

Alex

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Alex Williamson" <alex.williamson@redhat.com>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Monday, March 6, 2023 5:46:07 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
> 
>> This patch series reenables VFIO support on POWER systems.  It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>> 
>> Alexey Kardashevskiy (3):
>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>   powerpc/pci_64: Init pcibios subsys a bit later
>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>     domains
>> 
>> Timothy Pearson (1):
>>   Add myself to MAINTAINERS for Power VFIO support
>> 
>>  MAINTAINERS                               |   5 +
>>  arch/powerpc/include/asm/iommu.h          |   6 +-
>>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>>  arch/powerpc/kernel/pci_64.c              |   2 +-
>>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>>  10 files changed, 338 insertions(+), 94 deletions(-)
>> 
> 
> For vfio and MAINTAINERS portions,
> 
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
> 
> I'll note though that spapr_tce_take_ownership() looks like it copied a
> bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
> are tested before calling iommu_take_ownership() but not in the unwind
> loop, ie. tables we might have skipped on setup are unconditionally
> released on unwind.  Thanks,
> 
> Alex

Thanks for that.  I'll put together a patch to get rid of that potential bug that can be applied after this series is merged, unless you'd rather I resubmit a v3 with the issue fixed?

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Alex Williamson" <alex.williamson@redhat.com>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Monday, March 6, 2023 5:46:07 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
> 
>> This patch series reenables VFIO support on POWER systems.  It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>> 
>> Alexey Kardashevskiy (3):
>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>   powerpc/pci_64: Init pcibios subsys a bit later
>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>     domains
>> 
>> Timothy Pearson (1):
>>   Add myself to MAINTAINERS for Power VFIO support
>> 
>>  MAINTAINERS                               |   5 +
>>  arch/powerpc/include/asm/iommu.h          |   6 +-
>>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>>  arch/powerpc/kernel/pci_64.c              |   2 +-
>>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>>  10 files changed, 338 insertions(+), 94 deletions(-)
>> 
> 
> For vfio and MAINTAINERS portions,
> 
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
> 
> I'll note though that spapr_tce_take_ownership() looks like it copied a
> bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
> are tested before calling iommu_take_ownership() but not in the unwind
> loop, ie. tables we might have skipped on setup are unconditionally
> released on unwind.  Thanks,
> 
> Alex

Thanks for that.  I'll put together a patch to get rid of that potential bug that can be applied after this series is merged, unless you'd rather I resubmit a v3 with the issue fixed?

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Alexey Kardashevskiy]

On 07/03/2023 10:46, Alex Williamson wrote:
> On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
> 
>> This patch series reenables VFIO support on POWER systems.  It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>>
>> Alexey Kardashevskiy (3):
>>    powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>    powerpc/pci_64: Init pcibios subsys a bit later
>>    powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>      domains
>>
>> Timothy Pearson (1):
>>    Add myself to MAINTAINERS for Power VFIO support
>>
>>   MAINTAINERS                               |   5 +
>>   arch/powerpc/include/asm/iommu.h          |   6 +-
>>   arch/powerpc/include/asm/pci-bridge.h     |   7 +
>>   arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>>   arch/powerpc/kernel/pci_64.c              |   2 +-
>>   arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>>   arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>>   arch/powerpc/platforms/pseries/pseries.h  |   4 +
>>   arch/powerpc/platforms/pseries/setup.c    |   3 +
>>   drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>>   10 files changed, 338 insertions(+), 94 deletions(-)
>>
> 
> For vfio and MAINTAINERS portions,
> 
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
> 
> I'll note though that spapr_tce_take_ownership() looks like it copied a
> bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
> are tested before calling iommu_take_ownership() but not in the unwind
> loop, ie. tables we might have skipped on setup are unconditionally
> released on unwind.  Thanks,


Ah, true, a bug. Thanks for pointing out.


-- 
Alexey

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Alex Williamson]

On Mon, 6 Mar 2023 18:35:22 -0600 (CST)
Timothy Pearson <tpearson@raptorengineering.com> wrote:

> ----- Original Message -----
> > From: "Alex Williamson" <alex.williamson@redhat.com>
> > To: "Timothy Pearson" <tpearson@raptorengineering.com>
> > Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> > Sent: Monday, March 6, 2023 5:46:07 PM
> > Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems  
> 
> > On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> > Timothy Pearson <tpearson@raptorengineering.com> wrote:
> >   
> >> This patch series reenables VFIO support on POWER systems.  It
> >> is based on Alexey Kardashevskiys's patch series, rebased and
> >> successfully tested under QEMU with a Marvell PCIe SATA controller
> >> on a POWER9 Blackbird host.
> >> 
> >> Alexey Kardashevskiy (3):
> >>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
> >>   powerpc/pci_64: Init pcibios subsys a bit later
> >>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
> >>     domains
> >> 
> >> Timothy Pearson (1):
> >>   Add myself to MAINTAINERS for Power VFIO support
> >> 
> >>  MAINTAINERS                               |   5 +
> >>  arch/powerpc/include/asm/iommu.h          |   6 +-
> >>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
> >>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
> >>  arch/powerpc/kernel/pci_64.c              |   2 +-
> >>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
> >>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
> >>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
> >>  arch/powerpc/platforms/pseries/setup.c    |   3 +
> >>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
> >>  10 files changed, 338 insertions(+), 94 deletions(-)
> >>   
> > 
> > For vfio and MAINTAINERS portions,
> > 
> > Acked-by: Alex Williamson <alex.williamson@redhat.com>
> > 
> > I'll note though that spapr_tce_take_ownership() looks like it copied a
> > bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
> > are tested before calling iommu_take_ownership() but not in the unwind
> > loop, ie. tables we might have skipped on setup are unconditionally
> > released on unwind.  Thanks,
> > 
> > Alex  
> 
> Thanks for that.  I'll put together a patch to get rid of that
> potential bug that can be applied after this series is merged, unless
> you'd rather I resubmit a v3 with the issue fixed?

Follow-up fix is fine by me.  Thanks,

Alex

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Alex Williamson]

On Mon, 6 Mar 2023 18:35:22 -0600 (CST)
Timothy Pearson <tpearson@raptorengineering.com> wrote:

> ----- Original Message -----
> > From: "Alex Williamson" <alex.williamson@redhat.com>
> > To: "Timothy Pearson" <tpearson@raptorengineering.com>
> > Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> > Sent: Monday, March 6, 2023 5:46:07 PM
> > Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems  
> 
> > On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> > Timothy Pearson <tpearson@raptorengineering.com> wrote:
> >   
> >> This patch series reenables VFIO support on POWER systems.  It
> >> is based on Alexey Kardashevskiys's patch series, rebased and
> >> successfully tested under QEMU with a Marvell PCIe SATA controller
> >> on a POWER9 Blackbird host.
> >> 
> >> Alexey Kardashevskiy (3):
> >>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
> >>   powerpc/pci_64: Init pcibios subsys a bit later
> >>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
> >>     domains
> >> 
> >> Timothy Pearson (1):
> >>   Add myself to MAINTAINERS for Power VFIO support
> >> 
> >>  MAINTAINERS                               |   5 +
> >>  arch/powerpc/include/asm/iommu.h          |   6 +-
> >>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
> >>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
> >>  arch/powerpc/kernel/pci_64.c              |   2 +-
> >>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
> >>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
> >>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
> >>  arch/powerpc/platforms/pseries/setup.c    |   3 +
> >>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
> >>  10 files changed, 338 insertions(+), 94 deletions(-)
> >>   
> > 
> > For vfio and MAINTAINERS portions,
> > 
> > Acked-by: Alex Williamson <alex.williamson@redhat.com>
> > 
> > I'll note though that spapr_tce_take_ownership() looks like it copied a
> > bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
> > are tested before calling iommu_take_ownership() but not in the unwind
> > loop, ie. tables we might have skipped on setup are unconditionally
> > released on unwind.  Thanks,
> > 
> > Alex  
> 
> Thanks for that.  I'll put together a patch to get rid of that
> potential bug that can be applied after this series is merged, unless
> you'd rather I resubmit a v3 with the issue fixed?

Follow-up fix is fine by me.  Thanks,

Alex

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Alex Williamson" <alex.williamson@redhat.com>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Monday, March 6, 2023 6:59:41 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> On Mon, 6 Mar 2023 18:35:22 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
> 
>> ----- Original Message -----
>> > From: "Alex Williamson" <alex.williamson@redhat.com>
>> > To: "Timothy Pearson" <tpearson@raptorengineering.com>
>> > Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> > Sent: Monday, March 6, 2023 5:46:07 PM
>> > Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>> 
>> > On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
>> > Timothy Pearson <tpearson@raptorengineering.com> wrote:
>> >   
>> >> This patch series reenables VFIO support on POWER systems.  It
>> >> is based on Alexey Kardashevskiys's patch series, rebased and
>> >> successfully tested under QEMU with a Marvell PCIe SATA controller
>> >> on a POWER9 Blackbird host.
>> >> 
>> >> Alexey Kardashevskiy (3):
>> >>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>> >>   powerpc/pci_64: Init pcibios subsys a bit later
>> >>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>> >>     domains
>> >> 
>> >> Timothy Pearson (1):
>> >>   Add myself to MAINTAINERS for Power VFIO support
>> >> 
>> >>  MAINTAINERS                               |   5 +
>> >>  arch/powerpc/include/asm/iommu.h          |   6 +-
>> >>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>> >>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>> >>  arch/powerpc/kernel/pci_64.c              |   2 +-
>> >>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>> >>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>> >>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>> >>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>> >>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>> >>  10 files changed, 338 insertions(+), 94 deletions(-)
>> >>   
>> > 
>> > For vfio and MAINTAINERS portions,
>> > 
>> > Acked-by: Alex Williamson <alex.williamson@redhat.com>
>> > 
>> > I'll note though that spapr_tce_take_ownership() looks like it copied a
>> > bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
>> > are tested before calling iommu_take_ownership() but not in the unwind
>> > loop, ie. tables we might have skipped on setup are unconditionally
>> > released on unwind.  Thanks,
>> > 
>> > Alex
>> 
>> Thanks for that.  I'll put together a patch to get rid of that
>> potential bug that can be applied after this series is merged, unless
>> you'd rather I resubmit a v3 with the issue fixed?
> 
> Follow-up fix is fine by me.  Thanks,
> 
> Alex

Just sent that patch in.  Thanks!

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Alex Williamson" <alex.williamson@redhat.com>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Monday, March 6, 2023 6:59:41 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> On Mon, 6 Mar 2023 18:35:22 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
> 
>> ----- Original Message -----
>> > From: "Alex Williamson" <alex.williamson@redhat.com>
>> > To: "Timothy Pearson" <tpearson@raptorengineering.com>
>> > Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> > Sent: Monday, March 6, 2023 5:46:07 PM
>> > Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>> 
>> > On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
>> > Timothy Pearson <tpearson@raptorengineering.com> wrote:
>> >   
>> >> This patch series reenables VFIO support on POWER systems.  It
>> >> is based on Alexey Kardashevskiys's patch series, rebased and
>> >> successfully tested under QEMU with a Marvell PCIe SATA controller
>> >> on a POWER9 Blackbird host.
>> >> 
>> >> Alexey Kardashevskiy (3):
>> >>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>> >>   powerpc/pci_64: Init pcibios subsys a bit later
>> >>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>> >>     domains
>> >> 
>> >> Timothy Pearson (1):
>> >>   Add myself to MAINTAINERS for Power VFIO support
>> >> 
>> >>  MAINTAINERS                               |   5 +
>> >>  arch/powerpc/include/asm/iommu.h          |   6 +-
>> >>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>> >>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>> >>  arch/powerpc/kernel/pci_64.c              |   2 +-
>> >>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>> >>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>> >>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>> >>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>> >>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>> >>  10 files changed, 338 insertions(+), 94 deletions(-)
>> >>   
>> > 
>> > For vfio and MAINTAINERS portions,
>> > 
>> > Acked-by: Alex Williamson <alex.williamson@redhat.com>
>> > 
>> > I'll note though that spapr_tce_take_ownership() looks like it copied a
>> > bug from the old tce_iommu_take_ownership() where tbl and tbl->it_map
>> > are tested before calling iommu_take_ownership() but not in the unwind
>> > loop, ie. tables we might have skipped on setup are unconditionally
>> > released on unwind.  Thanks,
>> > 
>> > Alex
>> 
>> Thanks for that.  I'll put together a patch to get rid of that
>> potential bug that can be applied after this series is merged, unless
>> you'd rather I resubmit a v3 with the issue fixed?
> 
> Follow-up fix is fine by me.  Thanks,
> 
> Alex

Just sent that patch in.  Thanks!

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Michael Ellerman]

Alex Williamson <alex.williamson@redhat.com> writes:
> On Mon, 6 Mar 2023 11:29:53 -0600 (CST)
> Timothy Pearson <tpearson@raptorengineering.com> wrote:
>
>> This patch series reenables VFIO support on POWER systems.  It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>> 
>> Alexey Kardashevskiy (3):
>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>   powerpc/pci_64: Init pcibios subsys a bit later
>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>     domains
>> 
>> Timothy Pearson (1):
>>   Add myself to MAINTAINERS for Power VFIO support
>> 
>>  MAINTAINERS                               |   5 +
>>  arch/powerpc/include/asm/iommu.h          |   6 +-
>>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>>  arch/powerpc/kernel/pci_64.c              |   2 +-
>>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>>  10 files changed, 338 insertions(+), 94 deletions(-)
>> 
>
> For vfio and MAINTAINERS portions,
>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>

Thanks.

cheers

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Michael Ellerman]

Timothy Pearson <tpearson@raptorengineering.com> writes:
> This patch series reenables VFIO support on POWER systems.  It
> is based on Alexey Kardashevskiys's patch series, rebased and
> successfully tested under QEMU with a Marvell PCIe SATA controller
> on a POWER9 Blackbird host.
>
> Alexey Kardashevskiy (3):
>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>   powerpc/pci_64: Init pcibios subsys a bit later
>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>     domains

As sent the patches had lost Alexey's authorship (no From: line), I
fixed it up when applying so the first 3 are authored by Alexey.

cheers

> Timothy Pearson (1):
>   Add myself to MAINTAINERS for Power VFIO support
>
>  MAINTAINERS                               |   5 +
>  arch/powerpc/include/asm/iommu.h          |   6 +-
>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>  arch/powerpc/kernel/pci_64.c              |   2 +-
>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>  10 files changed, 338 insertions(+), 94 deletions(-)
>
> -- 
> 2.30.2

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Michael Ellerman" <mpe@ellerman.id.au>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm" <kvm@vger.kernel.org>
> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Thursday, March 9, 2023 5:40:01 AM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> Timothy Pearson <tpearson@raptorengineering.com> writes:
>> This patch series reenables VFIO support on POWER systems.  It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>>
>> Alexey Kardashevskiy (3):
>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>   powerpc/pci_64: Init pcibios subsys a bit later
>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>     domains
> 
> As sent the patches had lost Alexey's authorship (no From: line), I
> fixed it up when applying so the first 3 are authored by Alexey.
> 
> cheers

Thanks for catching that, it wasn't intentional.  Probably used a wrong Git command...

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Michael Ellerman" <mpe@ellerman.id.au>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm" <kvm@vger.kernel.org>
> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Thursday, March 9, 2023 5:40:01 AM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> Timothy Pearson <tpearson@raptorengineering.com> writes:
>> This patch series reenables VFIO support on POWER systems.  It
>> is based on Alexey Kardashevskiys's patch series, rebased and
>> successfully tested under QEMU with a Marvell PCIe SATA controller
>> on a POWER9 Blackbird host.
>>
>> Alexey Kardashevskiy (3):
>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>   powerpc/pci_64: Init pcibios subsys a bit later
>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>     domains
> 
> As sent the patches had lost Alexey's authorship (no From: line), I
> fixed it up when applying so the first 3 are authored by Alexey.
> 
> cheers

Thanks for catching that, it wasn't intentional.  Probably used a wrong Git command...

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Timothy Pearson" <tpearson@raptorengineering.com>
> To: "Michael Ellerman" <mpe@ellerman.id.au>
> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm" <kvm@vger.kernel.org>, "linuxppc-dev"
> <linuxppc-dev@lists.ozlabs.org>
> Sent: Thursday, March 9, 2023 1:28:20 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> ----- Original Message -----
>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>> <kvm@vger.kernel.org>
>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> Sent: Thursday, March 9, 2023 5:40:01 AM
>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
> 
>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>> This patch series reenables VFIO support on POWER systems.  It
>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>> on a POWER9 Blackbird host.
>>>
>>> Alexey Kardashevskiy (3):
>>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>   powerpc/pci_64: Init pcibios subsys a bit later
>>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>     domains
>> 
>> As sent the patches had lost Alexey's authorship (no From: line), I
>> fixed it up when applying so the first 3 are authored by Alexey.
>> 
>> cheers
> 
> Thanks for catching that, it wasn't intentional.  Probably used a wrong Git
> command...

Just wanted to touch base on the patches, since they're still listed as Under Review on patchwork.  Are we good to go for the 6.4 merge window?

Thanks!

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Timothy Pearson" <tpearson@raptorengineering.com>
> To: "Michael Ellerman" <mpe@ellerman.id.au>
> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm" <kvm@vger.kernel.org>, "linuxppc-dev"
> <linuxppc-dev@lists.ozlabs.org>
> Sent: Thursday, March 9, 2023 1:28:20 PM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> ----- Original Message -----
>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>> <kvm@vger.kernel.org>
>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> Sent: Thursday, March 9, 2023 5:40:01 AM
>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
> 
>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>> This patch series reenables VFIO support on POWER systems.  It
>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>> on a POWER9 Blackbird host.
>>>
>>> Alexey Kardashevskiy (3):
>>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>   powerpc/pci_64: Init pcibios subsys a bit later
>>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>     domains
>> 
>> As sent the patches had lost Alexey's authorship (no From: line), I
>> fixed it up when applying so the first 3 are authored by Alexey.
>> 
>> cheers
> 
> Thanks for catching that, it wasn't intentional.  Probably used a wrong Git
> command...

Just wanted to touch base on the patches, since they're still listed as Under Review on patchwork.  Are we good to go for the 6.4 merge window?

Thanks!

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Michael Ellerman]

Timothy Pearson <tpearson@raptorengineering.com> writes:
> ----- Original Message -----
>> From: "Timothy Pearson" <tpearson@raptorengineering.com>
>> To: "Michael Ellerman" <mpe@ellerman.id.au>
>> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm" <kvm@vger.kernel.org>, "linuxppc-dev"
>> <linuxppc-dev@lists.ozlabs.org>
>> Sent: Thursday, March 9, 2023 1:28:20 PM
>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>
>> ----- Original Message -----
>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>> <kvm@vger.kernel.org>
>>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>>> Sent: Thursday, March 9, 2023 5:40:01 AM
>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>> 
>>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>>> This patch series reenables VFIO support on POWER systems.  It
>>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>>> on a POWER9 Blackbird host.
>>>>
>>>> Alexey Kardashevskiy (3):
>>>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>>   powerpc/pci_64: Init pcibios subsys a bit later
>>>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>>     domains
>>> 
>>> As sent the patches had lost Alexey's authorship (no From: line), I
>>> fixed it up when applying so the first 3 are authored by Alexey.
>>> 
>>> cheers
>> 
>> Thanks for catching that, it wasn't intentional.  Probably used a wrong Git
>> command...
>
> Just wanted to touch base on the patches, since they're still listed as Under Review on patchwork.  Are we good to go for the 6.4 merge window?

They've been in my next (and so linux-next), since last week. I just
haven't updated patchwork yet.

So yeah they are on track to go into mainline during the v6.4 merge window.

cheers

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Michael Ellerman]

Timothy Pearson <tpearson@raptorengineering.com> writes:
> ----- Original Message -----
>> From: "Timothy Pearson" <tpearson@raptorengineering.com>
>> To: "Michael Ellerman" <mpe@ellerman.id.au>
>> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm" <kvm@vger.kernel.org>, "linuxppc-dev"
>> <linuxppc-dev@lists.ozlabs.org>
>> Sent: Thursday, March 9, 2023 1:28:20 PM
>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>
>> ----- Original Message -----
>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>> <kvm@vger.kernel.org>
>>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>>> Sent: Thursday, March 9, 2023 5:40:01 AM
>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>> 
>>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>>> This patch series reenables VFIO support on POWER systems.  It
>>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>>> on a POWER9 Blackbird host.
>>>>
>>>> Alexey Kardashevskiy (3):
>>>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>>   powerpc/pci_64: Init pcibios subsys a bit later
>>>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>>     domains
>>> 
>>> As sent the patches had lost Alexey's authorship (no From: line), I
>>> fixed it up when applying so the first 3 are authored by Alexey.
>>> 
>>> cheers
>> 
>> Thanks for catching that, it wasn't intentional.  Probably used a wrong Git
>> command...
>
> Just wanted to touch base on the patches, since they're still listed as Under Review on patchwork.  Are we good to go for the 6.4 merge window?

They've been in my next (and so linux-next), since last week. I just
haven't updated patchwork yet.

So yeah they are on track to go into mainline during the v6.4 merge window.

cheers

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Michael Ellerman" <mpe@ellerman.id.au>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Tuesday, March 21, 2023 5:33:57 AM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> Timothy Pearson <tpearson@raptorengineering.com> writes:
>> ----- Original Message -----
>>> From: "Timothy Pearson" <tpearson@raptorengineering.com>
>>> To: "Michael Ellerman" <mpe@ellerman.id.au>
>>> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>> <kvm@vger.kernel.org>, "linuxppc-dev"
>>> <linuxppc-dev@lists.ozlabs.org>
>>> Sent: Thursday, March 9, 2023 1:28:20 PM
>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>
>>> ----- Original Message -----
>>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>>> <kvm@vger.kernel.org>
>>>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>>>> Sent: Thursday, March 9, 2023 5:40:01 AM
>>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>> 
>>>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>>>> This patch series reenables VFIO support on POWER systems.  It
>>>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>>>> on a POWER9 Blackbird host.
>>>>>
>>>>> Alexey Kardashevskiy (3):
>>>>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>>>   powerpc/pci_64: Init pcibios subsys a bit later
>>>>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>>>     domains
>>>> 
>>>> As sent the patches had lost Alexey's authorship (no From: line), I
>>>> fixed it up when applying so the first 3 are authored by Alexey.
>>>> 
>>>> cheers
>>> 
>>> Thanks for catching that, it wasn't intentional.  Probably used a wrong Git
>>> command...
>>
>> Just wanted to touch base on the patches, since they're still listed as Under
>> Review on patchwork.  Are we good to go for the 6.4 merge window?
> 
> They've been in my next (and so linux-next), since last week. I just
> haven't updated patchwork yet.
> 
> So yeah they are on track to go into mainline during the v6.4 merge window.
> 
> cheers

Sounds great, thanks!  Saw them in the next tree but wasn't sure if the patchwork status was more reflective of overall status.

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Timothy Pearson]

----- Original Message -----
> From: "Michael Ellerman" <mpe@ellerman.id.au>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
> Sent: Tuesday, March 21, 2023 5:33:57 AM
> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

> Timothy Pearson <tpearson@raptorengineering.com> writes:
>> ----- Original Message -----
>>> From: "Timothy Pearson" <tpearson@raptorengineering.com>
>>> To: "Michael Ellerman" <mpe@ellerman.id.au>
>>> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>> <kvm@vger.kernel.org>, "linuxppc-dev"
>>> <linuxppc-dev@lists.ozlabs.org>
>>> Sent: Thursday, March 9, 2023 1:28:20 PM
>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>
>>> ----- Original Message -----
>>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>>> <kvm@vger.kernel.org>
>>>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>>>> Sent: Thursday, March 9, 2023 5:40:01 AM
>>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>> 
>>>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>>>> This patch series reenables VFIO support on POWER systems.  It
>>>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>>>> on a POWER9 Blackbird host.
>>>>>
>>>>> Alexey Kardashevskiy (3):
>>>>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>>>   powerpc/pci_64: Init pcibios subsys a bit later
>>>>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>>>     domains
>>>> 
>>>> As sent the patches had lost Alexey's authorship (no From: line), I
>>>> fixed it up when applying so the first 3 are authored by Alexey.
>>>> 
>>>> cheers
>>> 
>>> Thanks for catching that, it wasn't intentional.  Probably used a wrong Git
>>> command...
>>
>> Just wanted to touch base on the patches, since they're still listed as Under
>> Review on patchwork.  Are we good to go for the 6.4 merge window?
> 
> They've been in my next (and so linux-next), since last week. I just
> haven't updated patchwork yet.
> 
> So yeah they are on track to go into mainline during the v6.4 merge window.
> 
> cheers

Sounds great, thanks!  Saw them in the next tree but wasn't sure if the patchwork status was more reflective of overall status.

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Michael Ellerman]

Timothy Pearson <tpearson@raptorengineering.com> writes:
> ----- Original Message -----
>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Timothy Pearson" <tpearson@raptorengineering.com>
>> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> Sent: Tuesday, March 21, 2023 5:33:57 AM
>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>
>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>> ----- Original Message -----
>>>> From: "Timothy Pearson" <tpearson@raptorengineering.com>
>>>> To: "Michael Ellerman" <mpe@ellerman.id.au>
>>>> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>>> <kvm@vger.kernel.org>, "linuxppc-dev"
>>>> <linuxppc-dev@lists.ozlabs.org>
>>>> Sent: Thursday, March 9, 2023 1:28:20 PM
>>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>>
>>>> ----- Original Message -----
>>>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>>>> <kvm@vger.kernel.org>
>>>>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>>>>> Sent: Thursday, March 9, 2023 5:40:01 AM
>>>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>>> 
>>>>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>>>>> This patch series reenables VFIO support on POWER systems.  It
>>>>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>>>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>>>>> on a POWER9 Blackbird host.
>>>>>>
>>>>>> Alexey Kardashevskiy (3):
>>>>>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>>>>   powerpc/pci_64: Init pcibios subsys a bit later
>>>>>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>>>>     domains
>>>>> 
>>>>> As sent the patches had lost Alexey's authorship (no From: line), I
>>>>> fixed it up when applying so the first 3 are authored by Alexey.
>>>>> 
>>>>> cheers
>>>> 
>>>> Thanks for catching that, it wasn't intentional.  Probably used a wrong Git
>>>> command...
>>>
>>> Just wanted to touch base on the patches, since they're still listed as Under
>>> Review on patchwork.  Are we good to go for the 6.4 merge window?
>> 
>> They've been in my next (and so linux-next), since last week. I just
>> haven't updated patchwork yet.
>> 
>> So yeah they are on track to go into mainline during the v6.4 merge window.
>> 
>> cheers
>
> Sounds great, thanks!  Saw them in the next tree but wasn't sure if the patchwork status was more reflective of overall status.

Yeah I guess patchwork is more reflective.

I sometimes put things in next for a few days to see if any issues shake
out, before I update patchwork. Mainly because it's a pain to un-update
patchwork if the patch needs to be backed out, but also as a signal that
the patch isn't quite locked into next yet.

cheers

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Michael Ellerman]

Timothy Pearson <tpearson@raptorengineering.com> writes:
> ----- Original Message -----
>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "Timothy Pearson" <tpearson@raptorengineering.com>
>> Cc: "kvm" <kvm@vger.kernel.org>, "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>> Sent: Tuesday, March 21, 2023 5:33:57 AM
>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>
>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>> ----- Original Message -----
>>>> From: "Timothy Pearson" <tpearson@raptorengineering.com>
>>>> To: "Michael Ellerman" <mpe@ellerman.id.au>
>>>> Cc: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>>> <kvm@vger.kernel.org>, "linuxppc-dev"
>>>> <linuxppc-dev@lists.ozlabs.org>
>>>> Sent: Thursday, March 9, 2023 1:28:20 PM
>>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>>
>>>> ----- Original Message -----
>>>>> From: "Michael Ellerman" <mpe@ellerman.id.au>
>>>>> To: "Timothy Pearson" <tpearson@raptorengineering.com>, "kvm"
>>>>> <kvm@vger.kernel.org>
>>>>> Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>
>>>>> Sent: Thursday, March 9, 2023 5:40:01 AM
>>>>> Subject: Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems
>>>> 
>>>>> Timothy Pearson <tpearson@raptorengineering.com> writes:
>>>>>> This patch series reenables VFIO support on POWER systems.  It
>>>>>> is based on Alexey Kardashevskiys's patch series, rebased and
>>>>>> successfully tested under QEMU with a Marvell PCIe SATA controller
>>>>>> on a POWER9 Blackbird host.
>>>>>>
>>>>>> Alexey Kardashevskiy (3):
>>>>>>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>>>>>>   powerpc/pci_64: Init pcibios subsys a bit later
>>>>>>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>>>>>>     domains
>>>>> 
>>>>> As sent the patches had lost Alexey's authorship (no From: line), I
>>>>> fixed it up when applying so the first 3 are authored by Alexey.
>>>>> 
>>>>> cheers
>>>> 
>>>> Thanks for catching that, it wasn't intentional.  Probably used a wrong Git
>>>> command...
>>>
>>> Just wanted to touch base on the patches, since they're still listed as Under
>>> Review on patchwork.  Are we good to go for the 6.4 merge window?
>> 
>> They've been in my next (and so linux-next), since last week. I just
>> haven't updated patchwork yet.
>> 
>> So yeah they are on track to go into mainline during the v6.4 merge window.
>> 
>> cheers
>
> Sounds great, thanks!  Saw them in the next tree but wasn't sure if the patchwork status was more reflective of overall status.

Yeah I guess patchwork is more reflective.

I sometimes put things in next for a few days to see if any issues shake
out, before I update patchwork. Mainly because it's a pain to un-update
patchwork if the patch needs to be backed out, but also as a signal that
the patch isn't quite locked into next yet.

cheers

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Narayana Murty]

On Mon, Mar 06, 2023 at 11:29:53AM -0600, Timothy Pearson wrote:
> This patch series reenables VFIO support on POWER systems.  It
> is based on Alexey Kardashevskiys's patch series, rebased and
> successfully tested under QEMU with a Marvell PCIe SATA controller
> on a POWER9 Blackbird host.
> 
> Alexey Kardashevskiy (3):
>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>   powerpc/pci_64: Init pcibios subsys a bit later
>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>     domains
> 
> Timothy Pearson (1):
>   Add myself to MAINTAINERS for Power VFIO support
> 
>  MAINTAINERS                               |   5 +
>  arch/powerpc/include/asm/iommu.h          |   6 +-
>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>  arch/powerpc/kernel/pci_64.c              |   2 +-
>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>  10 files changed, 338 insertions(+), 94 deletions(-)
> 
> -- 
> 2.30.2
The Alexey Kardashevskiy (3) patchs  series tested on powerNV denali power9 system with 
NetXtreme BCM5719 Gigabit Ethernet PCIe  card.The vfio passthrough 
is working fine 

Tested-by : Narayana Murty <nnmlinux@linux.vnet.ibm.com>

Re: [PATCH v2 0/4] Reenable VFIO support on POWER systems

[Narayana Murty]

On Mon, Mar 06, 2023 at 11:29:53AM -0600, Timothy Pearson wrote:
> This patch series reenables VFIO support on POWER systems.  It
> is based on Alexey Kardashevskiys's patch series, rebased and
> successfully tested under QEMU with a Marvell PCIe SATA controller
> on a POWER9 Blackbird host.
> 
> Alexey Kardashevskiy (3):
>   powerpc/iommu: Add "borrowing" iommu_table_group_ops
>   powerpc/pci_64: Init pcibios subsys a bit later
>   powerpc/iommu: Add iommu_ops to report capabilities and allow blocking
>     domains
> 
> Timothy Pearson (1):
>   Add myself to MAINTAINERS for Power VFIO support
> 
>  MAINTAINERS                               |   5 +
>  arch/powerpc/include/asm/iommu.h          |   6 +-
>  arch/powerpc/include/asm/pci-bridge.h     |   7 +
>  arch/powerpc/kernel/iommu.c               | 246 +++++++++++++++++++++-
>  arch/powerpc/kernel/pci_64.c              |   2 +-
>  arch/powerpc/platforms/powernv/pci-ioda.c |  36 +++-
>  arch/powerpc/platforms/pseries/iommu.c    |  27 +++
>  arch/powerpc/platforms/pseries/pseries.h  |   4 +
>  arch/powerpc/platforms/pseries/setup.c    |   3 +
>  drivers/vfio/vfio_iommu_spapr_tce.c       |  96 ++-------
>  10 files changed, 338 insertions(+), 94 deletions(-)
> 
> -- 
> 2.30.2
The Alexey Kardashevskiy (3) patchs  series tested on powerNV denali power9 system with 
NetXtreme BCM5719 Gigabit Ethernet PCIe  card.The vfio passthrough 
is working fine 

Tested-by : Narayana Murty <nnmlinux@linux.vnet.ibm.com>