* [PATCH net-next v1 1/1] net: phy: at803x: Replace of_gpio.h with what indeed is used
@ 2023-03-16 12:08 Andy Shevchenko
2023-03-16 20:03 ` Andrew Lunn
2023-03-19 10:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-03-16 12:08 UTC (permalink / raw)
To: netdev, linux-kernel
Cc: Andrew Lunn, Heiner Kallweit, Russell King, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andy Shevchenko
of_gpio.h in this driver is solely used as a proxy to other headers.
This is incorrect usage of the of_gpio.h. Replace it .h with what
indeed is used in the code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/phy/at803x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 22f4458274aa..656136628ffd 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -13,12 +13,11 @@
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
#include <linux/ethtool_netlink.h>
-#include <linux/of_gpio.h>
#include <linux/bitfield.h>
-#include <linux/gpio/consumer.h>
#include <linux/regulator/of_regulator.h>
#include <linux/regulator/driver.h>
#include <linux/regulator/consumer.h>
+#include <linux/of.h>
#include <linux/phylink.h>
#include <linux/sfp.h>
#include <dt-bindings/net/qca-ar803x.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] net: phy: at803x: Replace of_gpio.h with what indeed is used
2023-03-16 12:08 [PATCH net-next v1 1/1] net: phy: at803x: Replace of_gpio.h with what indeed is used Andy Shevchenko
@ 2023-03-16 20:03 ` Andrew Lunn
2023-03-19 10:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2023-03-16 20:03 UTC (permalink / raw)
To: Andy Shevchenko
Cc: netdev, linux-kernel, Heiner Kallweit, Russell King,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
On Thu, Mar 16, 2023 at 02:08:26PM +0200, Andy Shevchenko wrote:
> of_gpio.h in this driver is solely used as a proxy to other headers.
> This is incorrect usage of the of_gpio.h. Replace it .h with what
> indeed is used in the code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] net: phy: at803x: Replace of_gpio.h with what indeed is used
2023-03-16 12:08 [PATCH net-next v1 1/1] net: phy: at803x: Replace of_gpio.h with what indeed is used Andy Shevchenko
2023-03-16 20:03 ` Andrew Lunn
@ 2023-03-19 10:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-19 10:50 UTC (permalink / raw)
To: Andy Shevchenko
Cc: netdev, linux-kernel, andrew, hkallweit1, linux, davem, edumazet,
kuba, pabeni
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 16 Mar 2023 14:08:26 +0200 you wrote:
> of_gpio.h in this driver is solely used as a proxy to other headers.
> This is incorrect usage of the of_gpio.h. Replace it .h with what
> indeed is used in the code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/net/phy/at803x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
- [net-next,v1,1/1] net: phy: at803x: Replace of_gpio.h with what indeed is used
https://git.kernel.org/netdev/net-next/c/a593a2fcfdfb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-19 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 12:08 [PATCH net-next v1 1/1] net: phy: at803x: Replace of_gpio.h with what indeed is used Andy Shevchenko
2023-03-16 20:03 ` Andrew Lunn
2023-03-19 10:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.