From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
tbm@cyrius.com, Oliver Hartkopp <socketcan@hartkopp.net>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC
Date: Tue, 23 Jul 2019 22:24:18 +0200 [thread overview]
Message-ID: <04efe868-ffaf-8b50-f52f-ce86aa2f3a38@kleine-koenig.org> (raw)
In-Reply-To: <20190723200321.GN24911@piout.net>
[-- Attachment #1.1: Type: text/plain, Size: 1176 bytes --]
On 7/23/19 10:03 PM, Alexandre Belloni wrote:
> On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote:
>> The internal RTC doesn't work, loading the driver only yields
>>
>> rtc-mv f1010300.rtc: internal RTC not ticking
>>
>> . So disable it.
>>
>> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
>> ---
>> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
>> index a88eb22070a1..994cabcf4b51 100644
>> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
>> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
>> @@ -104,3 +104,11 @@
>> &pcie0 {
>> status = "okay";
>> };
>> +
>> +&rtc {
>> + /*
>> + * There is a s35390a available on the i2c bus, the internal rtc isn't
>> + * working (probably no crystal assembled).
>> + */
>> + status = "disabled";
>> +};
>
> You could also use the aliases to ensure rtc0 is the s35390a. This would
> solve the initial issue.
What do you assume is my initial issue? Adding the alias doesn't make
the above message disappear from the boot log.
Best regards
Uwe
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Andrew Lunn <andrew@lunn.ch>,
Oliver Hartkopp <socketcan@hartkopp.net>,
tbm@cyrius.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC
Date: Tue, 23 Jul 2019 22:24:18 +0200 [thread overview]
Message-ID: <04efe868-ffaf-8b50-f52f-ce86aa2f3a38@kleine-koenig.org> (raw)
In-Reply-To: <20190723200321.GN24911@piout.net>
[-- Attachment #1.1.1: Type: text/plain, Size: 1176 bytes --]
On 7/23/19 10:03 PM, Alexandre Belloni wrote:
> On 23/07/2019 21:45:05+0200, Uwe Kleine-König wrote:
>> The internal RTC doesn't work, loading the driver only yields
>>
>> rtc-mv f1010300.rtc: internal RTC not ticking
>>
>> . So disable it.
>>
>> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
>> ---
>> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
>> index a88eb22070a1..994cabcf4b51 100644
>> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
>> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
>> @@ -104,3 +104,11 @@
>> &pcie0 {
>> status = "okay";
>> };
>> +
>> +&rtc {
>> + /*
>> + * There is a s35390a available on the i2c bus, the internal rtc isn't
>> + * working (probably no crystal assembled).
>> + */
>> + status = "disabled";
>> +};
>
> You could also use the aliases to ensure rtc0 is the s35390a. This would
> solve the initial issue.
What do you assume is my initial issue? Adding the alias doesn't make
the above message disappear from the boot log.
Best regards
Uwe
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-23 20:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 19:45 [PATCH] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
2019-07-23 19:45 ` Uwe Kleine-König
2019-07-23 20:03 ` Alexandre Belloni
2019-07-23 20:03 ` Alexandre Belloni
2019-07-23 20:24 ` Uwe Kleine-König [this message]
2019-07-23 20:24 ` Uwe Kleine-König
2019-07-24 8:57 ` Alexandre Belloni
2019-07-24 8:57 ` Alexandre Belloni
2019-07-23 22:20 ` Andrew Lunn
2019-07-23 22:20 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04efe868-ffaf-8b50-f52f-ce86aa2f3a38@kleine-koenig.org \
--to=uwe@kleine-koenig.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.