[MPTCP] Re: [MPTCP][PATCH] Squash-to: "mptcp: implement mptcp_pm_remove_subflow v9"

[MPTCP] Re: [MPTCP][PATCH] Squash-to: "mptcp: implement mptcp_pm_remove_subflow v9"

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

Hi Geliang, Paolo,

On 08/09/2020 08:32, Geliang Tang wrote:
> Commit message should be rewritten enterily:
> '''
> This patch implemented the local subflow removing function,
> mptcp_pm_remove_subflow, it simply called mptcp_pm_nl_rm_subflow_received
> under the PM spin lock.
> 
> We use mptcp_pm_remove_subflow to remove a local subflow, so change it's
> argument from remote_id to local_id.
> 
> We check subflow->local_id in mptcp_pm_nl_rm_subflow_received to remove
> a subflow.
> '''

As described in my previous message, I also applied this patch (without 
Paolo's ACK) because this was needed for the patch modifying the MIB.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [MPTCP][PATCH] Squash-to: "mptcp: implement mptcp_pm_remove_subflow v9"

[Geliang Tang]

[-- Attachment #1: Type: text/plain, Size: 1582 bytes --]

Hi Matt, Paolo,

Matthieu Baerts <matthieu.baerts(a)tessares.net> 于2020年9月11日周五 下午2:45写道：
>
> Hi Geliang, Paolo,
>
> On 08/09/2020 08:32, Geliang Tang wrote:
> > Commit message should be rewritten enterily:
> > '''
> > This patch implemented the local subflow removing function,
> > mptcp_pm_remove_subflow, it simply called mptcp_pm_nl_rm_subflow_received
> > under the PM spin lock.
> >
> > We use mptcp_pm_remove_subflow to remove a local subflow, so change it's
> > argument from remote_id to local_id.
> >
> > We check subflow->local_id in mptcp_pm_nl_rm_subflow_received to remove
> > a subflow.
> > '''
>
> As described in my previous message, I also applied this patch (without
> Paolo's ACK) because this was needed for the patch modifying the MIB.

This squash-to patch is fine, and I'm very confident about it. The new function
mptcp_pm_nl_rm_subflow_received is copied from mptcp_pm_nl_rm_addr_received,
there are only three differences between them:

1. mptcp_pm_nl_rm_subflow_received use rm_id as an input parameter, but
mptcp_pm_nl_rm_addr_received get rm_id from msk->pm.rm_id.

2. mptcp_pm_nl_rm_subflow_received check if the rm_id equals subflow's
local_id, but
mptcp_pm_nl_rm_addr_received check if it equals subflow's remote_id.

3. mptcp_pm_nl_rm_subflow_received reduce local_addr_used number, but
mptcp_pm_nl_rm_addr_received reduce add_addr_accepted number and set
accept_addr to true.

-Geliang



>
> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net