All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Huang, Ying'" <ying.huang@intel.com>,
	"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: <tim.c.chen@intel.com>, <dave.hansen@intel.com>,
	<andi.kleen@intel.com>, <aaron.lu@intel.com>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	"'Andrea Arcangeli'" <aarcange@redhat.com>,
	"'Kirill A . Shutemov'" <kirill.shutemov@linux.intel.com>,
	"'Ebru Akagunduz'" <ebru.akagunduz@gmail.com>
Subject: Re: [PATCH -v4 RESEND 8/9] mm, THP, swap: Support to split THP in swap cache
Date: Fri, 28 Oct 2016 18:18:34 +0800	[thread overview]
Message-ID: <052901d23104$a6473380$f2d59a80$@alibaba-inc.com> (raw)
In-Reply-To: <20161028055608.1736-9-ying.huang@intel.com>

On Friday, October 28, 2016 1:56 PM Huang, Ying wrote: 
> @@ -2016,10 +2021,12 @@ int page_trans_huge_mapcount(struct page *page, int *total_mapcount)
>  /* Racy check whether the huge page can be split */
>  bool can_split_huge_page(struct page *page)
>  {
> -	int extra_pins = 0;
> +	int extra_pins;
> 
>  	/* Additional pins from radix tree */
> -	if (!PageAnon(page))
> +	if (PageAnon(page))
> +		extra_pins = PageSwapCache(page) ? HPAGE_PMD_NR : 0;
> +	else
>  		extra_pins = HPAGE_PMD_NR;

extra_pins is computed in this newly added helper.

>  	return total_mapcount(page) == page_count(page) - extra_pins - 1;
>  }
> @@ -2072,7 +2079,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list)
>  			ret = -EBUSY;
>  			goto out;
>  		}
> -		extra_pins = 0;
> +		extra_pins = PageSwapCache(head) ? HPAGE_PMD_NR : 0;

It is also computed at the call site, so can we fold them into one?

>  		mapping = NULL;
>  		anon_vma_lock_write(anon_vma);
>  	} else {
> --
> 2.9.3

WARNING: multiple messages have this Message-ID (diff)
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Huang, Ying'" <ying.huang@intel.com>,
	'Andrew Morton' <akpm@linux-foundation.org>
Cc: tim.c.chen@intel.com, dave.hansen@intel.com,
	andi.kleen@intel.com, aaron.lu@intel.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	'Andrea Arcangeli' <aarcange@redhat.com>,
	"'Kirill A . Shutemov'" <kirill.shutemov@linux.intel.com>,
	'Ebru Akagunduz' <ebru.akagunduz@gmail.com>
Subject: Re: [PATCH -v4 RESEND 8/9] mm, THP, swap: Support to split THP in swap cache
Date: Fri, 28 Oct 2016 18:18:34 +0800	[thread overview]
Message-ID: <052901d23104$a6473380$f2d59a80$@alibaba-inc.com> (raw)
In-Reply-To: <20161028055608.1736-9-ying.huang@intel.com>

On Friday, October 28, 2016 1:56 PM Huang, Ying wrote: 
> @@ -2016,10 +2021,12 @@ int page_trans_huge_mapcount(struct page *page, int *total_mapcount)
>  /* Racy check whether the huge page can be split */
>  bool can_split_huge_page(struct page *page)
>  {
> -	int extra_pins = 0;
> +	int extra_pins;
> 
>  	/* Additional pins from radix tree */
> -	if (!PageAnon(page))
> +	if (PageAnon(page))
> +		extra_pins = PageSwapCache(page) ? HPAGE_PMD_NR : 0;
> +	else
>  		extra_pins = HPAGE_PMD_NR;

extra_pins is computed in this newly added helper.

>  	return total_mapcount(page) == page_count(page) - extra_pins - 1;
>  }
> @@ -2072,7 +2079,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list)
>  			ret = -EBUSY;
>  			goto out;
>  		}
> -		extra_pins = 0;
> +		extra_pins = PageSwapCache(head) ? HPAGE_PMD_NR : 0;

It is also computed at the call site, so can we fold them into one?

>  		mapping = NULL;
>  		anon_vma_lock_write(anon_vma);
>  	} else {
> --
> 2.9.3

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-10-28 10:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28  5:55 [PATCH -v4 RESEND 0/9] THP swap: Delay splitting THP during swapping out Huang, Ying
2016-10-28  5:55 ` Huang, Ying
2016-10-28  5:56 ` [PATCH -v4 RESEND 1/9] mm, swap: Make swap cluster size same of THP size on x86_64 Huang, Ying
2016-10-28  5:56   ` Huang, Ying
2016-10-28  5:56 ` [PATCH -v4 RESEND 2/9] mm, memcg: Support to charge/uncharge multiple swap entries Huang, Ying
2016-10-28  5:56   ` Huang, Ying
2016-10-28  5:56 ` [PATCH -v4 RESEND 3/9] mm, THP, swap: Add swap cluster allocate/free functions Huang, Ying
2016-10-28  5:56   ` Huang, Ying
2016-10-28  5:56 ` [PATCH -v4 RESEND 4/9] mm, THP, swap: Add get_huge_swap_page() Huang, Ying
2016-10-28  5:56   ` Huang, Ying
2016-10-28  5:56 ` [PATCH -v4 RESEND 5/9] mm, THP, swap: Support to clear SWAP_HAS_CACHE for huge page Huang, Ying
2016-10-28  5:56   ` Huang, Ying
2016-10-28  5:56 ` [PATCH -v4 RESEND 6/9] mm, THP, swap: Support to add/delete THP to/from swap cache Huang, Ying
2016-10-28  5:56   ` Huang, Ying
2016-10-28  8:08   ` Hillf Danton
2016-10-28  8:08     ` Hillf Danton
2016-10-28  8:30     ` Huang, Ying
2016-10-28  8:30       ` Huang, Ying
2016-10-28  5:56 ` [PATCH -v4 RESEND 7/9] mm, THP: Add can_split_huge_page() Huang, Ying
2016-10-28  5:56   ` Huang, Ying
2016-10-28  5:56 ` [PATCH -v4 RESEND 8/9] mm, THP, swap: Support to split THP in swap cache Huang, Ying
2016-10-28  5:56   ` Huang, Ying
2016-10-28 10:18   ` Hillf Danton [this message]
2016-10-28 10:18     ` Hillf Danton
2016-10-31  1:26     ` Huang, Ying
2016-10-31  1:26       ` Huang, Ying
2016-10-28  5:56 ` [PATCH -v4 RESEND 9/9] mm, THP, swap: Delay splitting THP during swap out Huang, Ying
2016-10-28  5:56   ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='052901d23104$a6473380$f2d59a80$@alibaba-inc.com' \
    --to=hillf.zj@alibaba-inc.com \
    --cc=aarcange@redhat.com \
    --cc=aaron.lu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi.kleen@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=ebru.akagunduz@gmail.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tim.c.chen@intel.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.