* [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops
@ 2017-06-02 11:36 ` Henri Roosen
0 siblings, 0 replies; 5+ messages in thread
From: Henri Roosen @ 2017-06-02 11:36 UTC (permalink / raw)
To: linux-remoteproc; +Cc: Henri Roosen, Ohad Ben-Cohen, Bjorn Andersson, open list
Trivial cleanup: the .ops pointer is assigned twice. This patch removes the
first assignment.
Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
---
drivers/rpmsg/virtio_rpmsg_bus.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
index 3c582f2..35b8379 100644
--- a/drivers/rpmsg/virtio_rpmsg_bus.c
+++ b/drivers/rpmsg/virtio_rpmsg_bus.c
@@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
/* Link the channel to our vrp */
vch->vrp = vrp;
- /* Assign callbacks for rpmsg_channel */
- vch->rpdev.ops = &virtio_rpmsg_ops;
-
/* Assign public information to the rpmsg_device */
rpdev = &vch->rpdev;
rpdev->src = chinfo->src;
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops
@ 2017-06-02 11:36 ` Henri Roosen
0 siblings, 0 replies; 5+ messages in thread
From: Henri Roosen @ 2017-06-02 11:36 UTC (permalink / raw)
To: linux-remoteproc; +Cc: Henri Roosen, Ohad Ben-Cohen, Bjorn Andersson, open list
Trivial cleanup: the .ops pointer is assigned twice. This patch removes the
first assignment.
Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
---
drivers/rpmsg/virtio_rpmsg_bus.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
index 3c582f2..35b8379 100644
--- a/drivers/rpmsg/virtio_rpmsg_bus.c
+++ b/drivers/rpmsg/virtio_rpmsg_bus.c
@@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
/* Link the channel to our vrp */
vch->vrp = vrp;
- /* Assign callbacks for rpmsg_channel */
- vch->rpdev.ops = &virtio_rpmsg_ops;
-
/* Assign public information to the rpmsg_device */
rpdev = &vch->rpdev;
rpdev->src = chinfo->src;
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops
2017-06-02 11:36 ` Henri Roosen
@ 2017-06-02 21:40 ` Suman Anna
-1 siblings, 0 replies; 5+ messages in thread
From: Suman Anna @ 2017-06-02 21:40 UTC (permalink / raw)
To: Henri Roosen, linux-remoteproc; +Cc: Ohad Ben-Cohen, Bjorn Andersson, open list
On 06/02/2017 06:36 AM, Henri Roosen wrote:
> Trivial cleanup: the .ops pointer is assigned twice. This patch removes the
> first assignment.
>
> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
Acked-by: Suman Anna <s-anna@ti.com>
> ---
> drivers/rpmsg/virtio_rpmsg_bus.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index 3c582f2..35b8379 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
> /* Link the channel to our vrp */
> vch->vrp = vrp;
>
> - /* Assign callbacks for rpmsg_channel */
> - vch->rpdev.ops = &virtio_rpmsg_ops;
> -
> /* Assign public information to the rpmsg_device */
> rpdev = &vch->rpdev;
> rpdev->src = chinfo->src;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops
@ 2017-06-02 21:40 ` Suman Anna
0 siblings, 0 replies; 5+ messages in thread
From: Suman Anna @ 2017-06-02 21:40 UTC (permalink / raw)
To: Henri Roosen, linux-remoteproc; +Cc: Ohad Ben-Cohen, Bjorn Andersson, open list
On 06/02/2017 06:36 AM, Henri Roosen wrote:
> Trivial cleanup: the .ops pointer is assigned twice. This patch removes the
> first assignment.
>
> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
Acked-by: Suman Anna <s-anna@ti.com>
> ---
> drivers/rpmsg/virtio_rpmsg_bus.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index 3c582f2..35b8379 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
> /* Link the channel to our vrp */
> vch->vrp = vrp;
>
> - /* Assign callbacks for rpmsg_channel */
> - vch->rpdev.ops = &virtio_rpmsg_ops;
> -
> /* Assign public information to the rpmsg_device */
> rpdev = &vch->rpdev;
> rpdev->src = chinfo->src;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops
2017-06-02 11:36 ` Henri Roosen
(?)
(?)
@ 2017-06-25 21:43 ` Bjorn Andersson
-1 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2017-06-25 21:43 UTC (permalink / raw)
To: Henri Roosen; +Cc: linux-remoteproc, Ohad Ben-Cohen, open list
On Fri 02 Jun 04:36 PDT 2017, Henri Roosen wrote:
> Trivial cleanup: the .ops pointer is assigned twice. This patch removes the
> first assignment.
>
> Signed-off-by: Henri Roosen <henri.roosen@ginzinger.com>
Applied, thanks
> ---
> drivers/rpmsg/virtio_rpmsg_bus.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c
> index 3c582f2..35b8379 100644
> --- a/drivers/rpmsg/virtio_rpmsg_bus.c
> +++ b/drivers/rpmsg/virtio_rpmsg_bus.c
> @@ -390,9 +390,6 @@ static struct rpmsg_device *rpmsg_create_channel(struct virtproc_info *vrp,
> /* Link the channel to our vrp */
> vch->vrp = vrp;
>
> - /* Assign callbacks for rpmsg_channel */
> - vch->rpdev.ops = &virtio_rpmsg_ops;
> -
> /* Assign public information to the rpmsg_device */
> rpdev = &vch->rpdev;
> rpdev->src = chinfo->src;
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-25 21:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-02 11:36 [PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops Henri Roosen
2017-06-02 11:36 ` Henri Roosen
2017-06-02 21:40 ` Suman Anna
2017-06-02 21:40 ` Suman Anna
2017-06-25 21:43 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.