All of lore.kernel.org
 help / color / mirror / Atom feed
* RTL8822BE Bluetooth device
@ 2017-08-23  2:09 Alex Deucher
  2017-08-23  2:21 ` 答复: " 陆朱伟
  0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2017-08-23  2:09 UTC (permalink / raw)
  To: linux-bluetooth, alex_lu, Larry.Finger

I have this device, but the driver requires a firmware file
(rtl8821a_config.bin) which does not seem to exist.  Looking at the
code[1], there appear to be several firmware config files for variants
of this device:
+ switch (lmp_subver) {
+ case RTL_ROM_LMP_8723B:
+ cfg_name = "rtl_bt/rtl8723b_config.bin";
+ break;
+ case RTL_ROM_LMP_8821A:
+ cfg_name = "rtl_bt/rtl8821a_config.bin";
+ break;
+ case RTL_ROM_LMP_8761A:
+ cfg_name = "rtl_bt/rtl8761a_config.bin";
+ break;
+ case RTL_ROM_LMP_8822B:
+ cfg_name = "rtl_bt/rtl8822b_config.bin";
+ break;
However, the only file that seem to actually exist is
rtl8822b_config.bin.  Does anyone know where to get the others?

Thanks,

Alex

[1] https://patchwork.kernel.org/patch/9323749/

^ permalink raw reply	[flat|nested] 4+ messages in thread

* 答复: RTL8822BE Bluetooth device
  2017-08-23  2:09 RTL8822BE Bluetooth device Alex Deucher
@ 2017-08-23  2:21 ` 陆朱伟
  2017-08-23  2:53   ` Alex Deucher
  0 siblings, 1 reply; 4+ messages in thread
From: 陆朱伟 @ 2017-08-23  2:21 UTC (permalink / raw)
  To: Alex Deucher, linux-bluetooth, Larry.Finger

SGkgQWxleCBEZXVjaGVyLA0KVGhlIHJ0bDg4MjFhX2NvbmZpZy5iaW4gaXMgbm90IG5lY2Vzc2Fy
eS4NCkl0IGlzIHVzZWQgZm9yIHNvbWUgc3BlY2lhbCBzZXR0aW5ncywgc3VjaCBhcyBiZGFkZHIs
IHNjbyBvdmVyIHBjbS9oY2ksIGV0Yy4NCg0KVGhhbmtzLA0KQlJzLA0KQWxleCBMdS4NCg0KLS0t
LS3pgq7ku7bljp/ku7YtLS0tLQ0K5Y+R5Lu25Lq6OiBBbGV4IERldWNoZXIgW21haWx0bzphbGV4
ZGV1Y2hlckBnbWFpbC5jb21dIA0K5Y+R6YCB5pe26Ze0OiAyMDE35bm0OOaciDIz5pelIDEwOjA5
DQrmlLbku7bkuro6IGxpbnV4LWJsdWV0b290aEB2Z2VyLmtlcm5lbC5vcmc7IOmZhuacseS8nzsg
TGFycnkuRmluZ2VyQGx3ZmluZ2VyLm5ldA0K5Li76aKYOiBSVEw4ODIyQkUgQmx1ZXRvb3RoIGRl
dmljZQ0KDQpJIGhhdmUgdGhpcyBkZXZpY2UsIGJ1dCB0aGUgZHJpdmVyIHJlcXVpcmVzIGEgZmly
bXdhcmUgZmlsZQ0KKHJ0bDg4MjFhX2NvbmZpZy5iaW4pIHdoaWNoIGRvZXMgbm90IHNlZW0gdG8g
ZXhpc3QuICBMb29raW5nIGF0IHRoZSBjb2RlWzFdLCB0aGVyZSBhcHBlYXIgdG8gYmUgc2V2ZXJh
bCBmaXJtd2FyZSBjb25maWcgZmlsZXMgZm9yIHZhcmlhbnRzIG9mIHRoaXMgZGV2aWNlOg0KKyBz
d2l0Y2ggKGxtcF9zdWJ2ZXIpIHsNCisgY2FzZSBSVExfUk9NX0xNUF84NzIzQjoNCisgY2ZnX25h
bWUgPSAicnRsX2J0L3J0bDg3MjNiX2NvbmZpZy5iaW4iOyBicmVhazsgY2FzZSANCisgUlRMX1JP
TV9MTVBfODgyMUE6DQorIGNmZ19uYW1lID0gInJ0bF9idC9ydGw4ODIxYV9jb25maWcuYmluIjsg
YnJlYWs7IGNhc2UgDQorIFJUTF9ST01fTE1QXzg3NjFBOg0KKyBjZmdfbmFtZSA9ICJydGxfYnQv
cnRsODc2MWFfY29uZmlnLmJpbiI7IGJyZWFrOyBjYXNlIA0KKyBSVExfUk9NX0xNUF84ODIyQjoN
CisgY2ZnX25hbWUgPSAicnRsX2J0L3J0bDg4MjJiX2NvbmZpZy5iaW4iOyBicmVhazsNCkhvd2V2
ZXIsIHRoZSBvbmx5IGZpbGUgdGhhdCBzZWVtIHRvIGFjdHVhbGx5IGV4aXN0IGlzIHJ0bDg4MjJi
X2NvbmZpZy5iaW4uICBEb2VzIGFueW9uZSBrbm93IHdoZXJlIHRvIGdldCB0aGUgb3RoZXJzPw0K
DQpUaGFua3MsDQoNCkFsZXgNCg0KWzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0
Y2gvOTMyMzc0OS8NCg0KLS0tLS0tUGxlYXNlIGNvbnNpZGVyIHRoZSBlbnZpcm9ubWVudCBiZWZv
cmUgcHJpbnRpbmcgdGhpcyBlLW1haWwuDQo=

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: 答复: RTL8822BE Bluetooth device
  2017-08-23  2:21 ` 答复: " 陆朱伟
@ 2017-08-23  2:53   ` Alex Deucher
  2017-08-23  3:22     ` 答复: " 陆朱伟
  0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2017-08-23  2:53 UTC (permalink / raw)
  To: 陆朱伟; +Cc: linux-bluetooth, Larry.Finger

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

On Tue, Aug 22, 2017 at 10:21 PM, 陆朱伟 <alex_lu@realsil.com.cn> wrote:
> Hi Alex Deucher,
> The rtl8821a_config.bin is not necessary.
> It is used for some special settings, such as bdaddr, sco over pcm/hci, etc.

Thanks for clarifying.  How about the attached patch to make it clear
which config firmwares are optional?


Alex

>
> Thanks,
> BRs,
> Alex Lu.
>
> -----邮件原件-----
> 发件人: Alex Deucher [mailto:alexdeucher@gmail.com]
> 发送时间: 2017年8月23日 10:09
> 收件人: linux-bluetooth@vger.kernel.org; 陆朱伟; Larry.Finger@lwfinger.net
> 主题: RTL8822BE Bluetooth device
>
> I have this device, but the driver requires a firmware file
> (rtl8821a_config.bin) which does not seem to exist.  Looking at the code[1], there appear to be several firmware config files for variants of this device:
> + switch (lmp_subver) {
> + case RTL_ROM_LMP_8723B:
> + cfg_name = "rtl_bt/rtl8723b_config.bin"; break; case
> + RTL_ROM_LMP_8821A:
> + cfg_name = "rtl_bt/rtl8821a_config.bin"; break; case
> + RTL_ROM_LMP_8761A:
> + cfg_name = "rtl_bt/rtl8761a_config.bin"; break; case
> + RTL_ROM_LMP_8822B:
> + cfg_name = "rtl_bt/rtl8822b_config.bin"; break;
> However, the only file that seem to actually exist is rtl8822b_config.bin.  Does anyone know where to get the others?
>
> Thanks,
>
> Alex
>
> [1] https://patchwork.kernel.org/patch/9323749/
>
> ------Please consider the environment before printing this e-mail.

[-- Attachment #2: 0001-btrtl-Make-it-clear-what-config-firmware-is-optional.patch --]
[-- Type: text/x-patch, Size: 1561 bytes --]

From b277ddea83e4da99949fa40aee587ccdba807e43 Mon Sep 17 00:00:00 2001
From: Alex Deucher <alexdeucher@gmail.com>
Date: Tue, 22 Aug 2017 22:45:48 -0400
Subject: [PATCH] btrtl: Make it clear what config firmware is optional

Some of the bt config firmwares are optional.  They are
only used for special settings.  Make it clear if the
firmware is optional or not during loading.

Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
---
 drivers/bluetooth/btrtl.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 8279094..ec9a0d1 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -268,12 +268,14 @@ static int rtl_download_firmware(struct hci_dev *hdev,
 	return ret;
 }
 
-static int rtl_load_config(struct hci_dev *hdev, const char *name, u8 **buff)
+static int rtl_load_config(struct hci_dev *hdev, const char *name, u8 **buff,
+			   bool config_needed)
 {
 	const struct firmware *fw;
 	int ret;
 
-	BT_INFO("%s: rtl: loading %s", hdev->name, name);
+	BT_INFO("%s: rtl: loading %s config %s", hdev->name,
+		config_needed ? "required" : "optional", name);
 	ret = request_firmware(&fw, name, &hdev->dev);
 	if (ret < 0)
 		return ret;
@@ -351,7 +353,7 @@ static int btrtl_setup_rtl8723b(struct hci_dev *hdev, u16 lmp_subver,
 	}
 
 	if (cfg_name) {
-		cfg_sz = rtl_load_config(hdev, cfg_name, &cfg_buff);
+		cfg_sz = rtl_load_config(hdev, cfg_name, &cfg_buff, config_needed);
 		if (cfg_sz < 0) {
 			cfg_sz = 0;
 			if (config_needed)
-- 
2.5.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* 答复: 答复: RTL8822BE Bluetooth device
  2017-08-23  2:53   ` Alex Deucher
@ 2017-08-23  3:22     ` 陆朱伟
  0 siblings, 0 replies; 4+ messages in thread
From: 陆朱伟 @ 2017-08-23  3:22 UTC (permalink / raw)
  To: Alex Deucher; +Cc: linux-bluetooth, Larry.Finger

SSBoYXZlIG5vIHByb2JsZW0gd2l0aCBpdC4NCg0KVGhhbmtzLA0KQlJzLA0KQWxleCBMdQ0KDQot
LS0tLemCruS7tuWOn+S7ti0tLS0tDQrlj5Hku7bkuro6IEFsZXggRGV1Y2hlciBbbWFpbHRvOmFs
ZXhkZXVjaGVyQGdtYWlsLmNvbV0gDQrlj5HpgIHml7bpl7Q6IDIwMTflubQ45pyIMjPml6UgMTA6
NTMNCuaUtuS7tuS6ujog6ZmG5pyx5LyfDQrmioTpgIE6IGxpbnV4LWJsdWV0b290aEB2Z2VyLmtl
cm5lbC5vcmc7IExhcnJ5LkZpbmdlckBsd2Zpbmdlci5uZXQNCuS4u+mimDogUmU6IOetlOWkjTog
UlRMODgyMkJFIEJsdWV0b290aCBkZXZpY2UNCg0KT24gVHVlLCBBdWcgMjIsIDIwMTcgYXQgMTA6
MjEgUE0sIOmZhuacseS8nyA8YWxleF9sdUByZWFsc2lsLmNvbS5jbj4gd3JvdGU6DQo+IEhpIEFs
ZXggRGV1Y2hlciwNCj4gVGhlIHJ0bDg4MjFhX2NvbmZpZy5iaW4gaXMgbm90IG5lY2Vzc2FyeS4N
Cj4gSXQgaXMgdXNlZCBmb3Igc29tZSBzcGVjaWFsIHNldHRpbmdzLCBzdWNoIGFzIGJkYWRkciwg
c2NvIG92ZXIgcGNtL2hjaSwgZXRjLg0KDQpUaGFua3MgZm9yIGNsYXJpZnlpbmcuICBIb3cgYWJv
dXQgdGhlIGF0dGFjaGVkIHBhdGNoIHRvIG1ha2UgaXQgY2xlYXIgd2hpY2ggY29uZmlnIGZpcm13
YXJlcyBhcmUgb3B0aW9uYWw/DQoNCg0KQWxleA0KDQo+DQo+IFRoYW5rcywNCj4gQlJzLA0KPiBB
bGV4IEx1Lg0KPg0KPiAtLS0tLemCruS7tuWOn+S7ti0tLS0tDQo+IOWPkeS7tuS6ujogQWxleCBE
ZXVjaGVyIFttYWlsdG86YWxleGRldWNoZXJAZ21haWwuY29tXQ0KPiDlj5HpgIHml7bpl7Q6IDIw
MTflubQ45pyIMjPml6UgMTA6MDkNCj4g5pS25Lu25Lq6OiBsaW51eC1ibHVldG9vdGhAdmdlci5r
ZXJuZWwub3JnOyDpmYbmnLHkvJ87IExhcnJ5LkZpbmdlckBsd2Zpbmdlci5uZXQNCj4g5Li76aKY
OiBSVEw4ODIyQkUgQmx1ZXRvb3RoIGRldmljZQ0KPg0KPiBJIGhhdmUgdGhpcyBkZXZpY2UsIGJ1
dCB0aGUgZHJpdmVyIHJlcXVpcmVzIGEgZmlybXdhcmUgZmlsZQ0KPiAocnRsODgyMWFfY29uZmln
LmJpbikgd2hpY2ggZG9lcyBub3Qgc2VlbSB0byBleGlzdC4gIExvb2tpbmcgYXQgdGhlIGNvZGVb
MV0sIHRoZXJlIGFwcGVhciB0byBiZSBzZXZlcmFsIGZpcm13YXJlIGNvbmZpZyBmaWxlcyBmb3Ig
dmFyaWFudHMgb2YgdGhpcyBkZXZpY2U6DQo+ICsgc3dpdGNoIChsbXBfc3VidmVyKSB7DQo+ICsg
Y2FzZSBSVExfUk9NX0xNUF84NzIzQjoNCj4gKyBjZmdfbmFtZSA9ICJydGxfYnQvcnRsODcyM2Jf
Y29uZmlnLmJpbiI7IGJyZWFrOyBjYXNlDQo+ICsgUlRMX1JPTV9MTVBfODgyMUE6DQo+ICsgY2Zn
X25hbWUgPSAicnRsX2J0L3J0bDg4MjFhX2NvbmZpZy5iaW4iOyBicmVhazsgY2FzZQ0KPiArIFJU
TF9ST01fTE1QXzg3NjFBOg0KPiArIGNmZ19uYW1lID0gInJ0bF9idC9ydGw4NzYxYV9jb25maWcu
YmluIjsgYnJlYWs7IGNhc2UNCj4gKyBSVExfUk9NX0xNUF84ODIyQjoNCj4gKyBjZmdfbmFtZSA9
ICJydGxfYnQvcnRsODgyMmJfY29uZmlnLmJpbiI7IGJyZWFrOw0KPiBIb3dldmVyLCB0aGUgb25s
eSBmaWxlIHRoYXQgc2VlbSB0byBhY3R1YWxseSBleGlzdCBpcyBydGw4ODIyYl9jb25maWcuYmlu
LiAgRG9lcyBhbnlvbmUga25vdyB3aGVyZSB0byBnZXQgdGhlIG90aGVycz8NCj4NCj4gVGhhbmtz
LA0KPg0KPiBBbGV4DQo+DQo+IFsxXSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNo
LzkzMjM3NDkvDQo+DQo+IC0tLS0tLVBsZWFzZSBjb25zaWRlciB0aGUgZW52aXJvbm1lbnQgYmVm
b3JlIHByaW50aW5nIHRoaXMgZS1tYWlsLg0K

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-08-23  3:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-23  2:09 RTL8822BE Bluetooth device Alex Deucher
2017-08-23  2:21 ` 答复: " 陆朱伟
2017-08-23  2:53   ` Alex Deucher
2017-08-23  3:22     ` 答复: " 陆朱伟

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.