* [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
@ 2016-01-07 7:37 Khem Raj
2016-01-07 9:16 ` Jan Stancek
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-01-07 7:37 UTC (permalink / raw)
To: ltp
sigval_t is glibc only construct, we use a union of sigval
which pretty much is same effect as sigval_t
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
lib/tlibio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/tlibio.c b/lib/tlibio.c
index 6b6103f..b7d9faa 100644
--- a/lib/tlibio.c
+++ b/lib/tlibio.c
@@ -130,7 +130,7 @@
#endif
static void lio_async_signal_handler();
-#ifdef sgi
+#if defined(sgi) || (defined(__linux__) && !defined(__UCLIBC__))
static void lio_async_callback_handler();
#endif
@@ -441,7 +441,7 @@ static void lio_async_signal_handler(int sig)
* If the handler is called, it will increment the Received_callback
* global variable.
***********************************************************************/
-static void lio_async_callback_handler(sigval_t sigval)
+static void lio_async_callback_handler(union sigval sigval)
{
if (Debug_level)
printf
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
2016-01-07 7:37 [LTP] [PATCH] Declare lio_async_callback_handler() for linux too Khem Raj
@ 2016-01-07 9:16 ` Jan Stancek
2016-01-07 9:58 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Jan Stancek @ 2016-01-07 9:16 UTC (permalink / raw)
To: ltp
----- Original Message -----
> From: "Khem Raj" <raj.khem@gmail.com>
> To: ltp@lists.linux.it
> Sent: Thursday, 7 January, 2016 8:37:07 AM
> Subject: [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
Hi,
>
> sigval_t is glibc only construct, we use a union of sigval
> which pretty much is same effect as sigval_t
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> lib/tlibio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/tlibio.c b/lib/tlibio.c
> index 6b6103f..b7d9faa 100644
> --- a/lib/tlibio.c
> +++ b/lib/tlibio.c
> @@ -130,7 +130,7 @@
> #endif
>
> static void lio_async_signal_handler();
> -#ifdef sgi
> +#if defined(sgi) || (defined(__linux__) && !defined(__UCLIBC__))
What difference does this make? Isn't this just a forward declaration,
that's not that useful anyway?
Regards,
Jan
> static void lio_async_callback_handler();
> #endif
>
> @@ -441,7 +441,7 @@ static void lio_async_signal_handler(int sig)
> * If the handler is called, it will increment the Received_callback
> * global variable.
> ***********************************************************************/
> -static void lio_async_callback_handler(sigval_t sigval)
> +static void lio_async_callback_handler(union sigval sigval)
> {
> if (Debug_level)
> printf
> --
> 2.7.0
>
>
> --
> Mailing list info: http://lists.linux.it/listinfo/ltp
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
2016-01-07 9:16 ` Jan Stancek
@ 2016-01-07 9:58 ` Khem Raj
2016-01-07 11:08 ` Jan Stancek
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2016-01-07 9:58 UTC (permalink / raw)
To: ltp
Hi Jan
> On Jan 7, 2016, at 1:16 AM, Jan Stancek <jstancek@redhat.com> wrote:
>
>
>
> ----- Original Message -----
>> From: "Khem Raj" <raj.khem@gmail.com>
>> To: ltp@lists.linux.it
>> Sent: Thursday, 7 January, 2016 8:37:07 AM
>> Subject: [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
>
> Hi,
>
>>
>> sigval_t is glibc only construct, we use a union of sigval
>> which pretty much is same effect as sigval_t
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> lib/tlibio.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/tlibio.c b/lib/tlibio.c
>> index 6b6103f..b7d9faa 100644
>> --- a/lib/tlibio.c
>> +++ b/lib/tlibio.c
>> @@ -130,7 +130,7 @@
>> #endif
>>
>> static void lio_async_signal_handler();
>> -#ifdef sgi
>> +#if defined(sgi) || (defined(__linux__) && !defined(__UCLIBC__))
>
> What difference does this make? Isn't this just a forward declaration,
> that's not that useful anyway?
I am getting undeclared errors e.g.
| tlibio.c:1274:7: error: 'lio_async_callback_handler' undeclared (first use in this function)
| lio_async_callback_handler;
| ^
moreover it makes it consistent with rest of the file.
>
> Regards,
> Jan
>
>> static void lio_async_callback_handler();
>> #endif
>>
>> @@ -441,7 +441,7 @@ static void lio_async_signal_handler(int sig)
>> * If the handler is called, it will increment the Received_callback
>> * global variable.
>> ***********************************************************************/
>> -static void lio_async_callback_handler(sigval_t sigval)
>> +static void lio_async_callback_handler(union sigval sigval)
>> {
>> if (Debug_level)
>> printf
>> --
>> 2.7.0
>>
>>
>> --
>> Mailing list info: http://lists.linux.it/listinfo/ltp
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.linux.it/pipermail/ltp/attachments/20160107/1f3d9fa7/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
2016-01-07 9:58 ` Khem Raj
@ 2016-01-07 11:08 ` Jan Stancek
2016-01-07 11:28 ` Khem Raj
2016-01-07 12:22 ` Khem Raj
0 siblings, 2 replies; 6+ messages in thread
From: Jan Stancek @ 2016-01-07 11:08 UTC (permalink / raw)
To: ltp
----- Original Message -----
> From: "Khem Raj" <raj.khem@gmail.com>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Thursday, 7 January, 2016 10:58:19 AM
> Subject: Re: [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
>
> Hi Jan
>
> > On Jan 7, 2016, at 1:16 AM, Jan Stancek <jstancek@redhat.com> wrote:
> >
> >
> >
> > ----- Original Message -----
> >> From: "Khem Raj" <raj.khem@gmail.com>
> >> To: ltp@lists.linux.it
> >> Sent: Thursday, 7 January, 2016 8:37:07 AM
> >> Subject: [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
> >
> > Hi,
> >
> >>
> >> sigval_t is glibc only construct, we use a union of sigval
> >> which pretty much is same effect as sigval_t
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >> lib/tlibio.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/lib/tlibio.c b/lib/tlibio.c
> >> index 6b6103f..b7d9faa 100644
> >> --- a/lib/tlibio.c
> >> +++ b/lib/tlibio.c
> >> @@ -130,7 +130,7 @@
> >> #endif
> >>
> >> static void lio_async_signal_handler();
> >> -#ifdef sgi
> >> +#if defined(sgi) || (defined(__linux__) && !defined(__UCLIBC__))
> >
> > What difference does this make? Isn't this just a forward declaration,
> > that's not that useful anyway?
>
> I am getting undeclared errors e.g.
>
> | tlibio.c:1274:7: error: 'lio_async_callback_handler' undeclared (first use
> | in this function)
> | lio_async_callback_handler;
> | ^
>
Definition of that function, with same exact ifdef around it,
is way before that, on line 444. Am I missing something?
I can remove both fwd declarations and it still compiles fine.
(I went as far back as gcc version 4.1.2 / rhel5.6)
What distro/arch/compiler/c_library are you using?
>
> moreover it makes it consistent with rest of the file.
>
> >
> > Regards,
> > Jan
> >
> >> static void lio_async_callback_handler();
> >> #endif
> >>
> >> @@ -441,7 +441,7 @@ static void lio_async_signal_handler(int sig)
> >> * If the handler is called, it will increment the Received_callback
> >> * global variable.
> >> ***********************************************************************/
> >> -static void lio_async_callback_handler(sigval_t sigval)
> >> +static void lio_async_callback_handler(union sigval sigval)
> >> {
> >> if (Debug_level)
> >> printf
> >> --
> >> 2.7.0
> >>
> >>
> >> --
> >> Mailing list info: http://lists.linux.it/listinfo/ltp
> >>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
2016-01-07 11:08 ` Jan Stancek
@ 2016-01-07 11:28 ` Khem Raj
2016-01-07 12:22 ` Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2016-01-07 11:28 UTC (permalink / raw)
To: ltp
On Thu, Jan 7, 2016 at 3:08 AM, Jan Stancek <jstancek@redhat.com> wrote:
>
>
> ----- Original Message -----
>> From: "Khem Raj" <raj.khem@gmail.com>
>> To: "Jan Stancek" <jstancek@redhat.com>
>> Cc: ltp@lists.linux.it
>> Sent: Thursday, 7 January, 2016 10:58:19 AM
>> Subject: Re: [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
>>
>> Hi Jan
>>
>> > On Jan 7, 2016, at 1:16 AM, Jan Stancek <jstancek@redhat.com> wrote:
>> >
>> >
>> >
>> > ----- Original Message -----
>> >> From: "Khem Raj" <raj.khem@gmail.com>
>> >> To: ltp@lists.linux.it
>> >> Sent: Thursday, 7 January, 2016 8:37:07 AM
>> >> Subject: [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
>> >
>> > Hi,
>> >
>> >>
>> >> sigval_t is glibc only construct, we use a union of sigval
>> >> which pretty much is same effect as sigval_t
>> >>
>> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> >> ---
>> >> lib/tlibio.c | 4 ++--
>> >> 1 file changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> diff --git a/lib/tlibio.c b/lib/tlibio.c
>> >> index 6b6103f..b7d9faa 100644
>> >> --- a/lib/tlibio.c
>> >> +++ b/lib/tlibio.c
>> >> @@ -130,7 +130,7 @@
>> >> #endif
>> >>
>> >> static void lio_async_signal_handler();
>> >> -#ifdef sgi
>> >> +#if defined(sgi) || (defined(__linux__) && !defined(__UCLIBC__))
>> >
>> > What difference does this make? Isn't this just a forward declaration,
>> > that's not that useful anyway?
>>
>> I am getting undeclared errors e.g.
>>
>> | tlibio.c:1274:7: error: 'lio_async_callback_handler' undeclared (first use
>> | in this function)
>> | lio_async_callback_handler;
>> | ^
>>
>
> Definition of that function, with same exact ifdef around it,
> is way before that, on line 444. Am I missing something?
>
> I can remove both fwd declarations and it still compiles fine.
> (I went as far back as gcc version 4.1.2 / rhel5.6)
>
> What distro/arch/compiler/c_library are you using?
I am using gcc 5.3 on Yocto/OE using musl C library.
>
>>
>> moreover it makes it consistent with rest of the file.
>>
>> >
>> > Regards,
>> > Jan
>> >
>> >> static void lio_async_callback_handler();
>> >> #endif
>> >>
>> >> @@ -441,7 +441,7 @@ static void lio_async_signal_handler(int sig)
>> >> * If the handler is called, it will increment the Received_callback
>> >> * global variable.
>> >> ***********************************************************************/
>> >> -static void lio_async_callback_handler(sigval_t sigval)
>> >> +static void lio_async_callback_handler(union sigval sigval)
>> >> {
>> >> if (Debug_level)
>> >> printf
>> >> --
>> >> 2.7.0
>> >>
>> >>
>> >> --
>> >> Mailing list info: http://lists.linux.it/listinfo/ltp
>> >>
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
2016-01-07 11:08 ` Jan Stancek
2016-01-07 11:28 ` Khem Raj
@ 2016-01-07 12:22 ` Khem Raj
1 sibling, 0 replies; 6+ messages in thread
From: Khem Raj @ 2016-01-07 12:22 UTC (permalink / raw)
To: ltp
> On Jan 7, 2016, at 3:08 AM, Jan Stancek <jstancek@redhat.com> wrote:
>
>
>
> ----- Original Message -----
>> From: "Khem Raj" <raj.khem@gmail.com>
>> To: "Jan Stancek" <jstancek@redhat.com>
>> Cc: ltp@lists.linux.it
>> Sent: Thursday, 7 January, 2016 10:58:19 AM
>> Subject: Re: [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
>>
>> Hi Jan
>>
>>> On Jan 7, 2016, at 1:16 AM, Jan Stancek <jstancek@redhat.com> wrote:
>>>
>>>
>>>
>>> ----- Original Message -----
>>>> From: "Khem Raj" <raj.khem@gmail.com>
>>>> To: ltp@lists.linux.it
>>>> Sent: Thursday, 7 January, 2016 8:37:07 AM
>>>> Subject: [LTP] [PATCH] Declare lio_async_callback_handler() for linux too
>>>
>>> Hi,
>>>
>>>>
>>>> sigval_t is glibc only construct, we use a union of sigval
>>>> which pretty much is same effect as sigval_t
>>>>
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>> lib/tlibio.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/lib/tlibio.c b/lib/tlibio.c
>>>> index 6b6103f..b7d9faa 100644
>>>> --- a/lib/tlibio.c
>>>> +++ b/lib/tlibio.c
>>>> @@ -130,7 +130,7 @@
>>>> #endif
>>>>
>>>> static void lio_async_signal_handler();
>>>> -#ifdef sgi
>>>> +#if defined(sgi) || (defined(__linux__) && !defined(__UCLIBC__))
>>>
>>> What difference does this make? Isn't this just a forward declaration,
>>> that's not that useful anyway?
>>
>> I am getting undeclared errors e.g.
>>
>> | tlibio.c:1274:7: error: 'lio_async_callback_handler' undeclared (first use
>> | in this function)
>> | lio_async_callback_handler;
>> | ^
>>
>
> Definition of that function, with same exact ifdef around it,
> is way before that, on line 444. Am I missing something?
>
> I can remove both fwd declarations and it still compiles fine.
> (I went as far back as gcc version 4.1.2 / rhel5.6)
>
> What distro/arch/compiler/c_library are you using?
I think the first hunk of that patch is not needed. Infact that forward declaration can be removed.
My errors were due to signal_t not being available on
musl once that got covered by changing to 'union signal? thats all was needed to fix the issue with musl
I am sending a v2
>
>>
>> moreover it makes it consistent with rest of the file.
>>
>>>
>>> Regards,
>>> Jan
>>>
>>>> static void lio_async_callback_handler();
>>>> #endif
>>>>
>>>> @@ -441,7 +441,7 @@ static void lio_async_signal_handler(int sig)
>>>> * If the handler is called, it will increment the Received_callback
>>>> * global variable.
>>>> ***********************************************************************/
>>>> -static void lio_async_callback_handler(sigval_t sigval)
>>>> +static void lio_async_callback_handler(union sigval sigval)
>>>> {
>>>> if (Debug_level)
>>>> printf
>>>> --
>>>> 2.7.0
>>>>
>>>>
>>>> --
>>>> Mailing list info: http://lists.linux.it/listinfo/ltp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.linux.it/pipermail/ltp/attachments/20160107/848ded1d/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-07 12:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-07 7:37 [LTP] [PATCH] Declare lio_async_callback_handler() for linux too Khem Raj
2016-01-07 9:16 ` Jan Stancek
2016-01-07 9:58 ` Khem Raj
2016-01-07 11:08 ` Jan Stancek
2016-01-07 11:28 ` Khem Raj
2016-01-07 12:22 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.