* [PATCH] cobalt/arch/arm: fptest: Add missing SIMD register clobbering
@ 2021-10-06 15:19 Jan Kiszka
2021-10-06 21:01 ` Bezdeka, Florian
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2021-10-06 15:19 UTC (permalink / raw)
To: Xenomai
From: Jan Kiszka <jan.kiszka@siemens.com>
This caused troubles with modern gcc that starts to use those regs for
other purposes. Seen with gcc-10 on Debian 11 e.g.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h b/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
index b81d109933..d5c2c7515b 100644
--- a/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
+++ b/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
@@ -32,7 +32,12 @@ static inline void fp_regs_set(int features, unsigned int val)
/* vldm %0!, {d0-d15},
AKA fldmiax %0!, {d0-d15} */
__asm__ __volatile__("ldc p11, cr0, [%0],#32*4":
- "=r"(i): "0"(&e[0]): "memory");
+ "=r"(i)
+ : "0"(&e[0])
+ : "d0", "d1", "d2", "d3", "d4", "d5",
+ "d6", "d7", "d8", "d9", "d10", "d11",
+ "d12", "d13", "d14", "d15",
+ "memory");
}
}
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] cobalt/arch/arm: fptest: Add missing SIMD register clobbering
2021-10-06 15:19 [PATCH] cobalt/arch/arm: fptest: Add missing SIMD register clobbering Jan Kiszka
@ 2021-10-06 21:01 ` Bezdeka, Florian
2021-10-07 7:58 ` Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Bezdeka, Florian @ 2021-10-06 21:01 UTC (permalink / raw)
To: xenomai, jan.kiszka
On Wed, 2021-10-06 at 17:19 +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> This caused troubles with modern gcc that starts to use those regs for
> other purposes. Seen with gcc-10 on Debian 11 e.g.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h b/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
> index b81d109933..d5c2c7515b 100644
> --- a/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
> +++ b/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
> @@ -32,7 +32,12 @@ static inline void fp_regs_set(int features, unsigned int val)
> /* vldm %0!, {d0-d15},
> AKA fldmiax %0!, {d0-d15} */
> __asm__ __volatile__("ldc p11, cr0, [%0],#32*4":
> - "=r"(i): "0"(&e[0]): "memory");
> + "=r"(i)
> + : "0"(&e[0])
> + : "d0", "d1", "d2", "d3", "d4", "d5",
> + "d6", "d7", "d8", "d9", "d10", "d11",
> + "d12", "d13", "d14", "d15",
> + "memory");
> }
> }
>
Is that already applied to next? That should be one of the last missing
pieces for porting xenomai-images to Debian 11.
The last unclear topic (AFAIR) is the ssh-key regeneration taking too
long for some reason on ARM and Debian 11, but that should be a Debian
specific issue and is hopefully not related to Xenomai itself.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cobalt/arch/arm: fptest: Add missing SIMD register clobbering
2021-10-06 21:01 ` Bezdeka, Florian
@ 2021-10-07 7:58 ` Jan Kiszka
2021-10-08 6:46 ` Bezdeka, Florian
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2021-10-07 7:58 UTC (permalink / raw)
To: Bezdeka, Florian (T RDA IOT SES-DE), xenomai
On 06.10.21 23:01, Bezdeka, Florian (T RDA IOT SES-DE) wrote:
> On Wed, 2021-10-06 at 17:19 +0200, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This caused troubles with modern gcc that starts to use those regs for
>> other purposes. Seen with gcc-10 on Debian 11 e.g.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h b/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
>> index b81d109933..d5c2c7515b 100644
>> --- a/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
>> +++ b/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
>> @@ -32,7 +32,12 @@ static inline void fp_regs_set(int features, unsigned int val)
>> /* vldm %0!, {d0-d15},
>> AKA fldmiax %0!, {d0-d15} */
>> __asm__ __volatile__("ldc p11, cr0, [%0],#32*4":
>> - "=r"(i): "0"(&e[0]): "memory");
>> + "=r"(i)
>> + : "0"(&e[0])
>> + : "d0", "d1", "d2", "d3", "d4", "d5",
>> + "d6", "d7", "d8", "d9", "d10", "d11",
>> + "d12", "d13", "d14", "d15",
>> + "memory");
>> }
>> }
>>
>
> Is that already applied to next? That should be one of the last missing
> pieces for porting xenomai-images to Debian 11.
It's in next, right.
>
> The last unclear topic (AFAIR) is the ssh-key regeneration taking too
> long for some reason on ARM and Debian 11, but that should be a Debian
> specific issue and is hopefully not related to Xenomai itself.
>
Right, now I recall. Interestingly, this does not show up on ARM (in
QEMU) with the already ported jailhouse-images.
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] cobalt/arch/arm: fptest: Add missing SIMD register clobbering
2021-10-07 7:58 ` Jan Kiszka
@ 2021-10-08 6:46 ` Bezdeka, Florian
0 siblings, 0 replies; 4+ messages in thread
From: Bezdeka, Florian @ 2021-10-08 6:46 UTC (permalink / raw)
To: xenomai, jan.kiszka
On Thu, 2021-10-07 at 09:58 +0200, Jan Kiszka wrote:
> On 06.10.21 23:01, Bezdeka, Florian (T RDA IOT SES-DE) wrote:
> > On Wed, 2021-10-06 at 17:19 +0200, Jan Kiszka wrote:
> > > From: Jan Kiszka <jan.kiszka@siemens.com>
> > >
> > > This caused troubles with modern gcc that starts to use those regs for
> > > other purposes. Seen with gcc-10 on Debian 11 e.g.
> > >
> > > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > > ---
> > > kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h | 7 ++++++-
> > > 1 file changed, 6 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h b/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
> > > index b81d109933..d5c2c7515b 100644
> > > --- a/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
> > > +++ b/kernel/cobalt/arch/arm/include/asm/xenomai/uapi/fptest.h
> > > @@ -32,7 +32,12 @@ static inline void fp_regs_set(int features, unsigned int val)
> > > /* vldm %0!, {d0-d15},
> > > AKA fldmiax %0!, {d0-d15} */
> > > __asm__ __volatile__("ldc p11, cr0, [%0],#32*4":
> > > - "=r"(i): "0"(&e[0]): "memory");
> > > + "=r"(i)
> > > + : "0"(&e[0])
> > > + : "d0", "d1", "d2", "d3", "d4", "d5",
> > > + "d6", "d7", "d8", "d9", "d10", "d11",
> > > + "d12", "d13", "d14", "d15",
> > > + "memory");
> > > }
> > > }
> > >
> >
> > Is that already applied to next? That should be one of the last missing
> > pieces for porting xenomai-images to Debian 11.
>
> It's in next, right.
Current CI shows me that this one qualifies for stable as well.
Building stable with a recent gcc brings up the same issue.
>
> >
> > The last unclear topic (AFAIR) is the ssh-key regeneration taking too
> > long for some reason on ARM and Debian 11, but that should be a Debian
> > specific issue and is hopefully not related to Xenomai itself.
> >
>
> Right, now I recall. Interestingly, this does not show up on ARM (in
> QEMU) with the already ported jailhouse-images.
>
> Jan
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-08 6:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06 15:19 [PATCH] cobalt/arch/arm: fptest: Add missing SIMD register clobbering Jan Kiszka
2021-10-06 21:01 ` Bezdeka, Florian
2021-10-07 7:58 ` Jan Kiszka
2021-10-08 6:46 ` Bezdeka, Florian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.