All of lore.kernel.org
 help / color / mirror / Atom feed
* why RAID10 doesn't return BB during resync?
@ 2020-12-21 11:52 Tkaczyk, Mariusz
  0 siblings, 0 replies; only message in thread
From: Tkaczyk, Mariusz @ 2020-12-21 11:52 UTC (permalink / raw)
  To: linux-raid

Hi all,
I tested some scenarios with badblocks injected under same offset on each
member drive. For RAID1 and RAID5 IO errors and badblocks were reported
during resync, as expected. For RAID10 with default layout (n=2) I didn't
observe any IO error reported.

According to code, it looks like it was designed this way from the
beginning:

     /* find the first device with a block */
     for (i=0; i<conf->copies; i++)
         if (!r10_bio->devs[i].bio->bi_status)
             break;

     if (i == conf->copies)
         goto done;

There is no attempt to fix read error, it is ignored quietly.
The implementation differs from RAID1. For RAID1, there is
fix_sync_read_error() routine, and errors are well handled.

So my questions at this point are:
Is this a gap or it is intentionally omitted?
If it is a gap, is it worth to be added in the future?

Thanks,
Mariusz

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-21 11:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-21 11:52 why RAID10 doesn't return BB during resync? Tkaczyk, Mariusz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.