From: Hermes Zhang <Hermes.Zhang@axis.com>
To: "pavel@ucw.cz" <pavel@ucw.cz>, "dmurphy@ti.com" <dmurphy@ti.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hermes Zhang <Hermes.Zhang@axis.com>,
"lkml@axis.com" <lkml@axis.com>, kernel <kernel@axis.com>
Subject: Re: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver
Date: Fri, 26 Mar 2021 06:07:26 +0000 [thread overview]
Message-ID: <05c93a739a404e3cb181802619258674@XBOX01.axis.com> (raw)
In-Reply-To: 20210326055559.izdyzb5gwgwthv4i@falbala.internal.home.lespocky.de
On 3/26/21 1:56 PM, Alexander Dahl wrote:
>> +
>> +module_platform_driver(multi_gpio_led_driver);
>> +
>> +MODULE_AUTHOR("Hermes Zhang <chenhui.zhang@axis.com>");
>> +MODULE_DESCRIPTION("Multiple GPIOs LED driver");
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_ALIAS("platform:leds-multi-gpio");
> I did not review thouroughly, but in my mail the indentation looks
> wrong. Did checkpatch complain?
Sorry, I forgot to check the style before commit, but seems one problem
about extra space:
$ chkernel
ERROR: space prohibited before that ',' (ctx:WxW)
#164: FILE: drivers/leds/simple/leds-multi-gpio.c:76:
+ + sizeof(u8) * nr_states , GFP_KERNEL);
^
I will fix it in next commit.
Best Regards,
Hermes
next prev parent reply other threads:[~2021-03-26 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 5:27 [PATCH v2 0/2] New multiple GPIOs LED driver Hermes Zhang
2021-03-26 5:28 ` [PATCH v2 1/2] dt-binding: leds: Document leds-multi-gpio bindings Hermes Zhang
2021-03-27 18:12 ` Rob Herring
2021-03-29 6:03 ` Hermes Zhang
2021-03-26 5:28 ` [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver Hermes Zhang
2021-03-26 5:56 ` Alexander Dahl
2021-03-26 6:07 ` Hermes Zhang [this message]
2021-03-26 13:49 ` Pavel Machek
2021-03-29 6:00 ` Hermes Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c93a739a404e3cb181802619258674@XBOX01.axis.com \
--to=hermes.zhang@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkml@axis.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.