All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hermes Zhang <Hermes.Zhang@axis.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "dmurphy@ti.com" <dmurphy@ti.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Hermes Zhang <Hermes.Zhang@axis.com>,
	"lkml@axis.com" <lkml@axis.com>, kernel <kernel@axis.com>
Subject: Re: [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver
Date: Mon, 29 Mar 2021 06:00:43 +0000	[thread overview]
Message-ID: <314085a9074c4c6db48a1460c42fb2cd@XBOX01.axis.com> (raw)
In-Reply-To: 20210326134939.GA11578@duo.ucw.cz

On 3/26/21 9:49 PM, Pavel Machek wrote:
>> +	of_property_read_string(node, "default-state", &state);
>> +	if (!strcmp(state, "on"))
>> +		multi_gpio_led_set(&priv->cdev, priv->cdev.max_brightness);
>> +	else
>> +		multi_gpio_led_set(&priv->cdev, 0);
> No need for default-state handling, unless you are using it.
>
We will use it, to make the LED default on or off.


Best Regards,

Hermes


      reply	other threads:[~2021-03-29  6:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  5:27 [PATCH v2 0/2] New multiple GPIOs LED driver Hermes Zhang
2021-03-26  5:28 ` [PATCH v2 1/2] dt-binding: leds: Document leds-multi-gpio bindings Hermes Zhang
2021-03-27 18:12   ` Rob Herring
2021-03-29  6:03     ` Hermes Zhang
2021-03-26  5:28 ` [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver Hermes Zhang
2021-03-26  5:56   ` Alexander Dahl
2021-03-26  6:07     ` Hermes Zhang
2021-03-26 13:49   ` Pavel Machek
2021-03-29  6:00     ` Hermes Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=314085a9074c4c6db48a1460c42fb2cd@XBOX01.axis.com \
    --to=hermes.zhang@axis.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=kernel@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=lkml@axis.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.