[U-Boot] [PATCH 1/2 v2] mips: mt76xx: Remove cache workaround and select SYS_MALLOC_CLEAR_ON_INIT

* [U-Boot] [PATCH 1/2 v2] mips: mt76xx: Remove cache workaround and select SYS_MALLOC_CLEAR_ON_INIT
@ 2019-05-23  5:55 Stefan Roese
  2019-05-23  5:55 ` [U-Boot] [PATCH 2/2 v2] mips: mt76xx: gardena-smart-gateway: Enable CONFIG_USE_PREBOOT Stefan Roese
  2019-05-24 14:13 ` [U-Boot] [PATCH 1/2 v2] mips: mt76xx: Remove cache workaround and select SYS_MALLOC_CLEAR_ON_INIT Daniel Schwierzeck
  0 siblings, 2 replies; 4+ messages in thread
From: Stefan Roese @ 2019-05-23  5:55 UTC (permalink / raw)
  To: u-boot

With commit 06985289d452 ("watchdog: Implement generic watchdog_reset()
version") the init sequence has changed in arch_misc_init(), resulting
in a re-appearance of the d-cache issue on MT7688 boards (e.g. gardena).
When this happens, the first (or sometimes later ones as well) TFTP
command hangs and does not complete correctly. This leads to the
assumption that the d-cache is not in a clean state once the ethernet
driver is called (d-cache is used here for the buffers). The old work-
around with the cache flush somehow does not work any more now with
the new code change.

To fix this issue, this patch now removes the old workaround and selects
CONFIG_SYS_MALLOC_CLEAR_ON_INIT for ARCH_MTMIPS. With this option the
complete malloc area is initialized with zeros (cache lines are touched).
Testing has shown that this also fixes the issue on the MT7688 boards.

Signed-off-by: Stefan Roese <sr@denx.de>
Suggested-by: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
---
v2:
- As suggested by Daniel, remove the workaround (hack) and select
  CONFIG_SYS_MALLOC_CLEAR_ON_INIT instead

 arch/mips/Kconfig           |  2 +-
 arch/mips/mach-mtmips/cpu.c | 15 ---------------
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 9cf8e9800d..5cb9bdf2ee 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -84,13 +84,13 @@ config ARCH_MTMIPS
 	select DM_SERIAL
 	imply DM_SPI
 	imply DM_SPI_FLASH
-	select ARCH_MISC_INIT
 	select MIPS_TUNE_24KC
 	select OF_CONTROL
 	select ROM_EXCEPTION_VECTORS
 	select SUPPORTS_CPU_MIPS32_R1
 	select SUPPORTS_CPU_MIPS32_R2
 	select SUPPORTS_LITTLE_ENDIAN
+	select SYS_MALLOC_CLEAR_ON_INIT
 	select SYSRESET
 
 config ARCH_JZ47XX
diff --git a/arch/mips/mach-mtmips/cpu.c b/arch/mips/mach-mtmips/cpu.c
index fcd0484a6d..b0a6397d68 100644
--- a/arch/mips/mach-mtmips/cpu.c
+++ b/arch/mips/mach-mtmips/cpu.c
@@ -68,18 +68,3 @@ int print_cpuinfo(void)
 
 	return 0;
 }
-
-int arch_misc_init(void)
-{
-	/*
-	 * It has been noticed, that sometimes the d-cache is not in a
-	 * "clean-state" when U-Boot is running on MT7688. This was
-	 * detected when using the ethernet driver (which uses d-cache)
-	 * and a TFTP command does not complete. Flushing the complete
-	 * d-cache (again?) here seems to fix this issue.
-	 */
-	flush_dcache_range(gd->bd->bi_memstart,
-			   gd->bd->bi_memstart + gd->ram_size - 1);
-
-	return 0;
-}
-- 
2.21.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread