Re: [PATCH 7/8] ASoC: Intel: sof_ssp_amp: rename driver and support cs35l41 amplifier

["Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>]

On 3/2/2022 4:50 PM, Pierre-Louis Bossart wrote:
> 
> 
> On 3/2/22 8:56 AM, Amadeusz Sławiński wrote:
>> On 3/1/2022 8:49 PM, Pierre-Louis Bossart wrote:
>>> From: Brent Lu <brent.lu@intel.com>
>>>
>>> Add support of CS35L41 amplifier to the machine driver, as well as
>>> the support of HDMI playback and BT offload DAI Link.
>>>
>>> Rename the driver to a generic name to support different amplifiers
>>> from different vendors.
>>>
>>> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>>> Signed-off-by: Brent Lu <brent.lu@intel.com>
>>> Signed-off-by: Pierre-Louis Bossart 
>>> <pierre-louis.bossart@linux.intel.com>
>>> ---
>>
>> Eh... rename should happen in separate patch, as there seems to be 
>> some changes done to the file and it is quite hard to review it, when 
>> whole file is in diff due to being moved.
> 
> that was a conscious decision on my side to keep the patches as is, 
> first add the initial contribution for the rt1308 amp from our embedded 
> Linux team, and show how it was extended to support another amplifier 
> for Chrome.
> 
> Indeed it leads to a bit of a tick-tock patch with the rename but it's 
> not that bad, is it? The alternative would lead to a much bigger patch 
> if I squash the whole thing.

I think you've misunderstood me, I'm not talking about squashing, but 
splitting patch 7 into two separate patches - one doing rename and 
another adding/changing things.

I was looking at:
+	links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) *
+					sof_ssp_amp_card.num_links, GFP_KERNEL);
+	cpus = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link_component) *
+					sof_ssp_amp_card.num_links, GFP_KERNEL);

and wondered where sof_ssp_amp_card.num_links comes from, and it only 
shows up 4 times in removed file, but 6 times in added one, which tells 
me that things changed, but it is hard to see what, when the diff shows 
whole files being moved instead of things that changed.