* [PATCH] wifi: rtl8xxxu: fix error messages
@ 2024-01-31 7:10 Dan Carpenter
2024-02-01 1:09 ` Ping-Ke Shih
2024-02-01 10:21 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-01-31 7:10 UTC (permalink / raw)
To: Martin Kaistra
Cc: Jes Sorensen, Kalle Valo, Ping-Ke Shih, linux-wireless,
linux-kernel, kernel-janitors
The first parameter of WARN_ONCE() is a condition so this code will end
up printing the function name instead of the proper message.
Fixes: 3ff7a05996f9 ("wifi: rtl8xxxu: support setting bssid register for multiple interfaces")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 3b954c2fe448..bd6fd3120562 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -3593,7 +3593,7 @@ static int rtl8xxxu_set_mac(struct rtl8xxxu_priv *priv, int port_num)
reg = REG_MACID1;
break;
default:
- WARN_ONCE("%s: invalid port_num\n", __func__);
+ WARN_ONCE(1, "%s: invalid port_num\n", __func__);
return -EINVAL;
}
@@ -3618,7 +3618,7 @@ static int rtl8xxxu_set_bssid(struct rtl8xxxu_priv *priv, const u8 *bssid, int p
reg = REG_BSSID1;
break;
default:
- WARN_ONCE("%s: invalid port_num\n", __func__);
+ WARN_ONCE(1, "%s: invalid port_num\n", __func__);
return -EINVAL;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] wifi: rtl8xxxu: fix error messages
2024-01-31 7:10 [PATCH] wifi: rtl8xxxu: fix error messages Dan Carpenter
@ 2024-02-01 1:09 ` Ping-Ke Shih
2024-02-01 10:21 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Ping-Ke Shih @ 2024-02-01 1:09 UTC (permalink / raw)
To: Dan Carpenter, Martin Kaistra
Cc: Jes Sorensen, Kalle Valo, linux-wireless, linux-kernel, kernel-janitors
> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@linaro.org>
> Sent: Wednesday, January 31, 2024 3:10 PM
> To: Martin Kaistra <martin.kaistra@linutronix.de>
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih
> <pkshih@realtek.com>; linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kernel-janitors@vger.kernel.org
> Subject: [PATCH] wifi: rtl8xxxu: fix error messages
>
> The first parameter of WARN_ONCE() is a condition so this code will end
> up printing the function name instead of the proper message.
>
> Fixes: 3ff7a05996f9 ("wifi: rtl8xxxu: support setting bssid register for multiple interfaces")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: rtl8xxxu: fix error messages
2024-01-31 7:10 [PATCH] wifi: rtl8xxxu: fix error messages Dan Carpenter
2024-02-01 1:09 ` Ping-Ke Shih
@ 2024-02-01 10:21 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2024-02-01 10:21 UTC (permalink / raw)
To: Dan Carpenter
Cc: Martin Kaistra, Jes Sorensen, Ping-Ke Shih, linux-wireless,
linux-kernel, kernel-janitors
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> The first parameter of WARN_ONCE() is a condition so this code will end
> up printing the function name instead of the proper message.
>
> Fixes: 3ff7a05996f9 ("wifi: rtl8xxxu: support setting bssid register for multiple interfaces")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
17903a283593 wifi: rtl8xxxu: fix error messages
--
https://patchwork.kernel.org/project/linux-wireless/patch/7b144531-a8da-4725-8911-9b614a525a35@moroto.mountain/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-01 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-31 7:10 [PATCH] wifi: rtl8xxxu: fix error messages Dan Carpenter
2024-02-01 1:09 ` Ping-Ke Shih
2024-02-01 10:21 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.