From: David Laight <David.Laight@ACULAB.COM>
To: "'Bjørn Mork'" <bjorn@mork.no>,
"Kristian Evensen" <kristian.evensen@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] rndis_host: Set random MAC for ZTE MF910
Date: Fri, 15 Jul 2016 16:42:02 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D5F4F921C@AcuExch.aculab.com> (raw)
In-Reply-To: <87k2gpnpo5.fsf@miraculix.mork.no>
From: Bjørn Mork
> Sent: 13 July 2016 23:23
...
> Or how about the more generic?:
>
> if (bp[0] & 0x02)
> eth_hw_addr_random(net);
> else
> ether_addr_copy(net->dev_addr, bp);
>
> That would catch similar screwups from other vendors too.
Not really, that disables 'locally administered' addresses. If a vendor
has used the same address on lots of cards it could easily be a 'real' address.
Not only that, there certainly used to be manufacturers that used 'locally
administered' addresses on all their cards (as well as those that used unallocated
address blocks).
Not to mention the bit-revered addresses....
David
next prev parent reply other threads:[~2016-07-15 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 16:39 [PATCH] rndis_host: Set random MAC for ZTE MF910 Kristian Evensen
2016-07-13 16:39 ` Kristian Evensen
2016-07-13 22:23 ` Bjørn Mork
2016-07-13 22:23 ` Bjørn Mork
2016-07-14 7:54 ` Kristian Evensen
2016-07-14 7:54 ` Kristian Evensen
2016-07-14 8:01 ` Kristian Evensen
2016-07-15 16:42 ` David Laight [this message]
2016-07-15 17:42 ` Bjørn Mork
2016-07-17 3:02 ` David Miller
2016-07-17 3:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6D5F4F921C@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=bjorn@mork.no \
--cc=kristian.evensen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.