All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kristian Evensen <kristian.evensen@gmail.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: linux-usb@vger.kernel.org,
	Network Development <netdev@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rndis_host: Set random MAC for ZTE MF910
Date: Thu, 14 Jul 2016 10:01:28 +0200	[thread overview]
Message-ID: <CAKfDRXhDp3heiD75Lat7cr1JmY-kaJ-MS0tt7QXX=s8RFjbpUQ@mail.gmail.com> (raw)
In-Reply-To: <CAKfDRXiP=LpNqPi5nSoMM2BK510edvCoatRWQhnQ8Z66N40_iw@mail.gmail.com>

On Thu, Jul 14, 2016 at 9:54 AM, Kristian Evensen
<kristian.evensen@gmail.com> wrote:
> Hi Bjørn,
>
> On Thu, Jul 14, 2016 at 12:23 AM, Bjørn Mork <bjorn@mork.no> wrote:
>>
>> Or how about the more generic?:
>>
>>         if (bp[0] & 0x02)
>>                 eth_hw_addr_random(net);
>>         else
>>                 ether_addr_copy(net->dev_addr, bp);
>>
>> That would catch similar screwups from other vendors too.
>
> Great idea, thanks. After submitting the patch I found some other
> devices with a similar bug, and there are probably even more out
> there. I will update patch and resubmit.

Oh, and I forgot to say, please ignore this patch. I will change the
title and description to better describe the functionality.

-Kristian

  reply	other threads:[~2016-07-14  8:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13 16:39 [PATCH] rndis_host: Set random MAC for ZTE MF910 Kristian Evensen
2016-07-13 16:39 ` Kristian Evensen
2016-07-13 22:23 ` Bjørn Mork
2016-07-13 22:23   ` Bjørn Mork
2016-07-14  7:54   ` Kristian Evensen
2016-07-14  7:54     ` Kristian Evensen
2016-07-14  8:01     ` Kristian Evensen [this message]
2016-07-15 16:42   ` David Laight
2016-07-15 17:42     ` Bjørn Mork
2016-07-17  3:02       ` David Miller
2016-07-17  3:02         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKfDRXhDp3heiD75Lat7cr1JmY-kaJ-MS0tt7QXX=s8RFjbpUQ@mail.gmail.com' \
    --to=kristian.evensen@gmail.com \
    --cc=bjorn@mork.no \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.