From: Michael Walle <michael@walle.cc> To: Tudor.Ambarus@microchip.com Cc: code@reto-schneider.ch, linux-mtd@lists.infradead.org, sr@denx.de, reto.schneider@husqvarnagroup.com, miquel.raynal@bootlin.com, p.yadav@ti.com, richard@nod.at, vigneshr@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] mtd: spi-nor: Add support for XM25QH64C Date: Wed, 30 Jun 2021 16:15:43 +0200 [thread overview] Message-ID: <064317e561f1ad20282efe778f633723@walle.cc> (raw) In-Reply-To: <0328347c-572d-b636-5542-99cb36e9efa9@microchip.com> Am 2021-06-28 06:55, schrieb Tudor.Ambarus@microchip.com: > On 6/14/21 9:56 AM, Michael Walle wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> the content is safe >> >> Hi Reto, >> >> Am 2021-06-13 14:12, schrieb Reto Schneider: >>> From: Reto Schneider <reto.schneider@husqvarnagroup.com> >>> >>> The data sheets can be found here: >>> http://xmcwh.com/Uploads/2020-12-17/XM25QH64C_Ver1.1.pdf >> >> Could you add that as a "Datasheet:" tag before your Sob tag? >> >>> This chip has been (briefly) tested on the MediaTek MT7688 based >>> GARDENA >>> smart gateway. >> >> Could you also apply my SFDP patch [1] and send the dump? >> Unfortunately, >> I can't think of a good way to do that along with the patch and if >> this >> in some way regarded as copyrighted material. So feel free to send it >> to >> me privately. I'm starting to build a database. >> > > Can the SFDP dump fit in the commit message when introducing a new > flash ID? As ASCII hex dump? I'd guess we need some instructions how to do that. 4k would be 256 lines with 16 byte per line. But yes, I had the same thought. > The SFDP standard is public. SFDP reveals just what the flash > supports, why would that be sensitive information? copyright material must not be sensitive information, no? I'm no laywer, thus I'd played it safe. > Reto, would you please dump the SFDP tables here? FWIW, he already provided me a binary dump for the flash (actually for the former version, too) and its already in my DB which you should have access, too. If we mandate that (and I am all for it) for new flashes, we will have to come up with a common format. Something like echo "-----BEGIN SFDP (JEDEC ID ...)------" cat sfdp | xxd -ps -c 20 echo "-----END SFDP------" I really don't know if such meta data belongs into the commit logs, though. -michael
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc> To: Tudor.Ambarus@microchip.com Cc: code@reto-schneider.ch, linux-mtd@lists.infradead.org, sr@denx.de, reto.schneider@husqvarnagroup.com, miquel.raynal@bootlin.com, p.yadav@ti.com, richard@nod.at, vigneshr@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] mtd: spi-nor: Add support for XM25QH64C Date: Wed, 30 Jun 2021 16:15:43 +0200 [thread overview] Message-ID: <064317e561f1ad20282efe778f633723@walle.cc> (raw) In-Reply-To: <0328347c-572d-b636-5542-99cb36e9efa9@microchip.com> Am 2021-06-28 06:55, schrieb Tudor.Ambarus@microchip.com: > On 6/14/21 9:56 AM, Michael Walle wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> the content is safe >> >> Hi Reto, >> >> Am 2021-06-13 14:12, schrieb Reto Schneider: >>> From: Reto Schneider <reto.schneider@husqvarnagroup.com> >>> >>> The data sheets can be found here: >>> http://xmcwh.com/Uploads/2020-12-17/XM25QH64C_Ver1.1.pdf >> >> Could you add that as a "Datasheet:" tag before your Sob tag? >> >>> This chip has been (briefly) tested on the MediaTek MT7688 based >>> GARDENA >>> smart gateway. >> >> Could you also apply my SFDP patch [1] and send the dump? >> Unfortunately, >> I can't think of a good way to do that along with the patch and if >> this >> in some way regarded as copyrighted material. So feel free to send it >> to >> me privately. I'm starting to build a database. >> > > Can the SFDP dump fit in the commit message when introducing a new > flash ID? As ASCII hex dump? I'd guess we need some instructions how to do that. 4k would be 256 lines with 16 byte per line. But yes, I had the same thought. > The SFDP standard is public. SFDP reveals just what the flash > supports, why would that be sensitive information? copyright material must not be sensitive information, no? I'm no laywer, thus I'd played it safe. > Reto, would you please dump the SFDP tables here? FWIW, he already provided me a binary dump for the flash (actually for the former version, too) and its already in my DB which you should have access, too. If we mandate that (and I am all for it) for new flashes, we will have to come up with a common format. Something like echo "-----BEGIN SFDP (JEDEC ID ...)------" cat sfdp | xxd -ps -c 20 echo "-----END SFDP------" I really don't know if such meta data belongs into the commit logs, though. -michael ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-06-30 14:15 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-13 12:12 [PATCH v1] mtd: spi-nor: Add support for XM25QH64C Reto Schneider 2021-06-13 12:12 ` Reto Schneider 2021-06-14 6:56 ` Michael Walle 2021-06-14 6:56 ` Michael Walle 2021-06-17 11:59 ` Reto Schneider 2021-06-17 11:59 ` Reto Schneider 2021-06-17 14:19 ` Michael Walle 2021-06-17 14:19 ` Michael Walle 2021-06-17 15:06 ` Reto Schneider 2021-06-17 15:06 ` Reto Schneider 2021-06-28 5:17 ` Tudor.Ambarus 2021-06-28 5:17 ` Tudor.Ambarus 2021-06-28 4:55 ` Tudor.Ambarus 2021-06-28 4:55 ` Tudor.Ambarus 2021-06-30 14:15 ` Michael Walle [this message] 2021-06-30 14:15 ` Michael Walle 2021-06-30 18:28 ` Tudor.Ambarus 2021-06-30 18:28 ` Tudor.Ambarus 2021-07-01 5:25 ` Tudor.Ambarus 2021-07-01 5:25 ` Tudor.Ambarus 2021-07-01 6:15 ` Michael Walle 2021-07-01 6:15 ` Michael Walle 2021-06-28 5:32 ` Tudor.Ambarus 2021-06-28 5:32 ` Tudor.Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=064317e561f1ad20282efe778f633723@walle.cc \ --to=michael@walle.cc \ --cc=Tudor.Ambarus@microchip.com \ --cc=code@reto-schneider.ch \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=p.yadav@ti.com \ --cc=reto.schneider@husqvarnagroup.com \ --cc=richard@nod.at \ --cc=sr@denx.de \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.