All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH] usb: dwc3-meson-g12a: add power-on/off of the PHYs
Date: Mon, 20 Apr 2020 15:47:23 +0200	[thread overview]
Message-ID: <06638a20-abe1-6991-8dc9-b24f50d59bfd@denx.de> (raw)
In-Reply-To: <20200420134601.19863-1-narmstrong@baylibre.com>

On 4/20/20 3:46 PM, Neil Armstrong wrote:
> Power on/off the PHYs to enable power to the USB ports, fixing USB support
> on Khadas VIM3/VIM3L boards.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
> index d4453f8784..8f4a2f3f82 100644
> --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> @@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev)
>  			goto err_phy_init;
>  	}
>  
> +	for (i = 0 ; i < PHY_COUNT ; ++i) {

Doesn't checkpatch complain about this extra space before semicolon ?

> +		if (!priv->phys[i].dev)
> +			continue;
> +
> +		ret = generic_phy_power_on(&priv->phys[i]);

Do we really need to turn on all the PHYs ?

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Neil Armstrong <narmstrong@baylibre.com>, u-boot-amlogic@groups.io
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] usb: dwc3-meson-g12a: add power-on/off of the PHYs
Date: Mon, 20 Apr 2020 15:47:23 +0200	[thread overview]
Message-ID: <06638a20-abe1-6991-8dc9-b24f50d59bfd@denx.de> (raw)
In-Reply-To: <20200420134601.19863-1-narmstrong@baylibre.com>

On 4/20/20 3:46 PM, Neil Armstrong wrote:
> Power on/off the PHYs to enable power to the USB ports, fixing USB support
> on Khadas VIM3/VIM3L boards.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/usb/dwc3/dwc3-meson-g12a.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
> index d4453f8784..8f4a2f3f82 100644
> --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> @@ -408,6 +408,15 @@ static int dwc3_meson_g12a_probe(struct udevice *dev)
>  			goto err_phy_init;
>  	}
>  
> +	for (i = 0 ; i < PHY_COUNT ; ++i) {

Doesn't checkpatch complain about this extra space before semicolon ?

> +		if (!priv->phys[i].dev)
> +			continue;
> +
> +		ret = generic_phy_power_on(&priv->phys[i]);

Do we really need to turn on all the PHYs ?

  reply	other threads:[~2020-04-20 13:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 13:46 [PATCH] usb: dwc3-meson-g12a: add power-on/off of the PHYs Neil Armstrong
2020-04-20 13:46 ` Neil Armstrong
2020-04-20 13:47 ` Marek Vasut [this message]
2020-04-20 13:47   ` Marek Vasut
2020-04-20 13:49   ` Neil Armstrong
2020-04-20 13:49     ` Neil Armstrong
2020-04-20 13:52     ` Marek Vasut
2020-04-20 13:52       ` Marek Vasut
2020-04-20 13:56       ` Neil Armstrong
2020-04-20 13:56         ` Neil Armstrong
2020-04-20 14:03         ` Marek Vasut
2020-04-20 14:03           ` Marek Vasut
2020-04-20 14:07           ` Neil Armstrong
2020-04-20 14:07             ` Neil Armstrong
2020-04-20 14:10             ` Marek Vasut
2020-04-20 14:10               ` Marek Vasut
2020-04-20 14:47               ` Neil Armstrong
2020-04-20 14:47                 ` Neil Armstrong
2020-04-20 15:40                 ` Marek Vasut
2020-04-20 15:40                   ` Marek Vasut
2020-04-21  8:09                   ` Neil Armstrong
2020-04-21  8:09                     ` Neil Armstrong
2020-04-21  8:10                     ` Marek Vasut
2020-04-21  8:10                       ` Marek Vasut
     [not found] <16078B20C191ED17.15323@groups.io>
2020-04-24  7:18 ` Neil Armstrong
2020-04-24  7:18   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06638a20-abe1-6991-8dc9-b24f50d59bfd@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.