* [PATCH v2 0/1] MAINTAINERS: Add Python library stanza
@ 2020-09-22 23:05 John Snow
2020-09-22 23:05 ` [PATCH v2 1/1] " John Snow
0 siblings, 1 reply; 11+ messages in thread
From: John Snow @ 2020-09-22 23:05 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, peter.maydell, alex.bennee, ehabkost, crosa
John Snow (1):
MAINTAINERS: Add Python library stanza
MAINTAINERS | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--
2.26.2
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-09-22 23:05 [PATCH v2 0/1] MAINTAINERS: Add Python library stanza John Snow
@ 2020-09-22 23:05 ` John Snow
2020-09-23 7:49 ` Philippe Mathieu-Daudé
2020-09-23 15:14 ` Markus Armbruster
0 siblings, 2 replies; 11+ messages in thread
From: John Snow @ 2020-09-22 23:05 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, ehabkost, Philippe Mathieu-Daudé,
alex.bennee, crosa, John Snow
I'm proposing that I split the actual Python library off from the other
miscellaneous python scripts we have and declare it maintained. Add
myself as a maintainer of this folder, along with Cleber.
v2: change python/* to python/, thanks Alex.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Cleber Rosa <crosa@redhat.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
---
MAINTAINERS | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3d17cad19a..c0222ee645 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2355,11 +2355,18 @@ S: Maintained
F: include/sysemu/cryptodev*.h
F: backends/cryptodev*.c
+Python library
+M: John Snow <jsnow@redhat.com>
+M: Cleber Rosa <crosa@redhat.com>
+R: Eduardo Habkost <ehabkost@redhat.com>
+S: Maintained
+F: python/
+T: git https://gitlab.com/jsnow/qemu.git python
+
Python scripts
M: Eduardo Habkost <ehabkost@redhat.com>
M: Cleber Rosa <crosa@redhat.com>
S: Odd fixes
-F: python/qemu/*py
F: scripts/*.py
F: tests/*.py
--
2.26.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-09-22 23:05 ` [PATCH v2 1/1] " John Snow
@ 2020-09-23 7:49 ` Philippe Mathieu-Daudé
2020-09-23 14:30 ` John Snow
2020-09-23 15:14 ` Markus Armbruster
1 sibling, 1 reply; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-23 7:49 UTC (permalink / raw)
To: John Snow, qemu-devel; +Cc: peter.maydell, alex.bennee, ehabkost, crosa
On 9/23/20 1:05 AM, John Snow wrote:
> I'm proposing that I split the actual Python library off from the other
> miscellaneous python scripts we have and declare it maintained. Add
> myself as a maintainer of this folder, along with Cleber.
>
> v2: change python/* to python/, thanks Alex.
^ Can you drop that line from the description when applying please?
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Acked-by: Cleber Rosa <crosa@redhat.com>
> Acked-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> MAINTAINERS | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3d17cad19a..c0222ee645 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2355,11 +2355,18 @@ S: Maintained
> F: include/sysemu/cryptodev*.h
> F: backends/cryptodev*.c
>
> +Python library
> +M: John Snow <jsnow@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
> +R: Eduardo Habkost <ehabkost@redhat.com>
> +S: Maintained
> +F: python/
> +T: git https://gitlab.com/jsnow/qemu.git python
> +
> Python scripts
> M: Eduardo Habkost <ehabkost@redhat.com>
> M: Cleber Rosa <crosa@redhat.com>
> S: Odd fixes
> -F: python/qemu/*py
> F: scripts/*.py
> F: tests/*.py
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-09-23 7:49 ` Philippe Mathieu-Daudé
@ 2020-09-23 14:30 ` John Snow
0 siblings, 0 replies; 11+ messages in thread
From: John Snow @ 2020-09-23 14:30 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: peter.maydell, alex.bennee, ehabkost, crosa
On 9/23/20 3:49 AM, Philippe Mathieu-Daudé wrote:
> On 9/23/20 1:05 AM, John Snow wrote:
>> I'm proposing that I split the actual Python library off from the other
>> miscellaneous python scripts we have and declare it maintained. Add
>> myself as a maintainer of this folder, along with Cleber.
>>
>> v2: change python/* to python/, thanks Alex.
>
> ^ Can you drop that line from the description when applying please?
>
Yup, forgot to put below the dashed line, oops.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>> Acked-by: Cleber Rosa <crosa@redhat.com>
>> Acked-by: Eduardo Habkost <ehabkost@redhat.com>
>> ---
>> MAINTAINERS | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 3d17cad19a..c0222ee645 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2355,11 +2355,18 @@ S: Maintained
>> F: include/sysemu/cryptodev*.h
>> F: backends/cryptodev*.c
>>
>> +Python library
>> +M: John Snow <jsnow@redhat.com>
>> +M: Cleber Rosa <crosa@redhat.com>
>> +R: Eduardo Habkost <ehabkost@redhat.com>
>> +S: Maintained
>> +F: python/
>> +T: git https://gitlab.com/jsnow/qemu.git python
>> +
>> Python scripts
>> M: Eduardo Habkost <ehabkost@redhat.com>
>> M: Cleber Rosa <crosa@redhat.com>
>> S: Odd fixes
>> -F: python/qemu/*py
>> F: scripts/*.py
>> F: tests/*.py
>>
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-09-22 23:05 ` [PATCH v2 1/1] " John Snow
2020-09-23 7:49 ` Philippe Mathieu-Daudé
@ 2020-09-23 15:14 ` Markus Armbruster
2020-09-23 15:17 ` John Snow
1 sibling, 1 reply; 11+ messages in thread
From: Markus Armbruster @ 2020-09-23 15:14 UTC (permalink / raw)
To: John Snow
Cc: peter.maydell, ehabkost, Philippe Mathieu-Daudé,
qemu-devel, crosa, alex.bennee
John Snow <jsnow@redhat.com> writes:
> I'm proposing that I split the actual Python library off from the other
> miscellaneous python scripts we have and declare it maintained. Add
> myself as a maintainer of this folder, along with Cleber.
>
> v2: change python/* to python/, thanks Alex.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Acked-by: Cleber Rosa <crosa@redhat.com>
> Acked-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> MAINTAINERS | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3d17cad19a..c0222ee645 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2355,11 +2355,18 @@ S: Maintained
> F: include/sysemu/cryptodev*.h
> F: backends/cryptodev*.c
>
> +Python library
> +M: John Snow <jsnow@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
> +R: Eduardo Habkost <ehabkost@redhat.com>
> +S: Maintained
> +F: python/
> +T: git https://gitlab.com/jsnow/qemu.git python
> +
> Python scripts
> M: Eduardo Habkost <ehabkost@redhat.com>
> M: Cleber Rosa <crosa@redhat.com>
> S: Odd fixes
> -F: python/qemu/*py
> F: scripts/*.py
> F: tests/*.py
Separate sections just so you can have the appropriate S:, or is there a
deeper logic behind the split?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-09-23 15:14 ` Markus Armbruster
@ 2020-09-23 15:17 ` John Snow
2020-09-23 15:37 ` Eduardo Habkost
0 siblings, 1 reply; 11+ messages in thread
From: John Snow @ 2020-09-23 15:17 UTC (permalink / raw)
To: Markus Armbruster
Cc: peter.maydell, ehabkost, Philippe Mathieu-Daudé,
qemu-devel, crosa, alex.bennee
On 9/23/20 11:14 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
>
>> I'm proposing that I split the actual Python library off from the other
>> miscellaneous python scripts we have and declare it maintained. Add
>> myself as a maintainer of this folder, along with Cleber.
>>
>> v2: change python/* to python/, thanks Alex.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>> Acked-by: Cleber Rosa <crosa@redhat.com>
>> Acked-by: Eduardo Habkost <ehabkost@redhat.com>
>> ---
>> MAINTAINERS | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 3d17cad19a..c0222ee645 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2355,11 +2355,18 @@ S: Maintained
>> F: include/sysemu/cryptodev*.h
>> F: backends/cryptodev*.c
>>
>> +Python library
>> +M: John Snow <jsnow@redhat.com>
>> +M: Cleber Rosa <crosa@redhat.com>
>> +R: Eduardo Habkost <ehabkost@redhat.com>
>> +S: Maintained
>> +F: python/
>> +T: git https://gitlab.com/jsnow/qemu.git python
>> +
>> Python scripts
>> M: Eduardo Habkost <ehabkost@redhat.com>
>> M: Cleber Rosa <crosa@redhat.com>
>> S: Odd fixes
>> -F: python/qemu/*py
>> F: scripts/*.py
>> F: tests/*.py
>
> Separate sections just so you can have the appropriate S:, or is there a
> deeper logic behind the split?
>
Yes, different intended levels of support. I don't currently have the
bandwidth to promise support for the miscellaneous Python scripts in
./scripts, but I do promise to support to a higher level the code in
./python.
Over time, I intend to migrate things into ./python, but there are some
series that need to happen first before I start doing that.
--js
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-09-23 15:17 ` John Snow
@ 2020-09-23 15:37 ` Eduardo Habkost
2020-09-23 16:49 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 11+ messages in thread
From: Eduardo Habkost @ 2020-09-23 15:37 UTC (permalink / raw)
To: John Snow
Cc: peter.maydell, Philippe Mathieu-Daudé,
Markus Armbruster, qemu-devel, crosa, alex.bennee
On Wed, Sep 23, 2020 at 11:17:01AM -0400, John Snow wrote:
> On 9/23/20 11:14 AM, Markus Armbruster wrote:
> > John Snow <jsnow@redhat.com> writes:
> >
> > > I'm proposing that I split the actual Python library off from the other
> > > miscellaneous python scripts we have and declare it maintained. Add
> > > myself as a maintainer of this folder, along with Cleber.
> > >
> > > v2: change python/* to python/, thanks Alex.
> > >
> > > Signed-off-by: John Snow <jsnow@redhat.com>
> > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > > Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > > Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> > > Acked-by: Cleber Rosa <crosa@redhat.com>
> > > Acked-by: Eduardo Habkost <ehabkost@redhat.com>
> > > ---
> > > MAINTAINERS | 9 ++++++++-
> > > 1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 3d17cad19a..c0222ee645 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -2355,11 +2355,18 @@ S: Maintained
> > > F: include/sysemu/cryptodev*.h
> > > F: backends/cryptodev*.c
> > > +Python library
> > > +M: John Snow <jsnow@redhat.com>
> > > +M: Cleber Rosa <crosa@redhat.com>
> > > +R: Eduardo Habkost <ehabkost@redhat.com>
> > > +S: Maintained
> > > +F: python/
> > > +T: git https://gitlab.com/jsnow/qemu.git python
> > > +
> > > Python scripts
> > > M: Eduardo Habkost <ehabkost@redhat.com>
> > > M: Cleber Rosa <crosa@redhat.com>
> > > S: Odd fixes
> > > -F: python/qemu/*py
> > > F: scripts/*.py
> > > F: tests/*.py
> >
> > Separate sections just so you can have the appropriate S:, or is there a
> > deeper logic behind the split?
> >
>
> Yes, different intended levels of support. I don't currently have the
> bandwidth to promise support for the miscellaneous Python scripts in
> ./scripts, but I do promise to support to a higher level the code in
> ./python.
>
> Over time, I intend to migrate things into ./python, but there are some
> series that need to happen first before I start doing that.
Also, the actual owners for most scripts in ./scripts are already
listed elsewhere. I believe we shouldn't really have M: lines
for the scripts/*.py section, just R:.
--
Eduardo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-09-23 15:37 ` Eduardo Habkost
@ 2020-09-23 16:49 ` Philippe Mathieu-Daudé
2020-09-24 6:58 ` Markus Armbruster
2020-10-01 15:27 ` John Snow
0 siblings, 2 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-23 16:49 UTC (permalink / raw)
To: Eduardo Habkost, John Snow
Cc: peter.maydell, crosa, alex.bennee, Markus Armbruster, qemu-devel
On 9/23/20 5:37 PM, Eduardo Habkost wrote:
> On Wed, Sep 23, 2020 at 11:17:01AM -0400, John Snow wrote:
>> On 9/23/20 11:14 AM, Markus Armbruster wrote:
>>> John Snow <jsnow@redhat.com> writes:
>>>
>>>> I'm proposing that I split the actual Python library off from the other
>>>> miscellaneous python scripts we have and declare it maintained. Add
>>>> myself as a maintainer of this folder, along with Cleber.
>>>>
>>>> v2: change python/* to python/, thanks Alex.
>>>>
>>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>>>> Acked-by: Cleber Rosa <crosa@redhat.com>
>>>> Acked-by: Eduardo Habkost <ehabkost@redhat.com>
>>>> ---
>>>> MAINTAINERS | 9 ++++++++-
>>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 3d17cad19a..c0222ee645 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -2355,11 +2355,18 @@ S: Maintained
>>>> F: include/sysemu/cryptodev*.h
>>>> F: backends/cryptodev*.c
>>>> +Python library
>>>> +M: John Snow <jsnow@redhat.com>
>>>> +M: Cleber Rosa <crosa@redhat.com>
>>>> +R: Eduardo Habkost <ehabkost@redhat.com>
>>>> +S: Maintained
>>>> +F: python/
>>>> +T: git https://gitlab.com/jsnow/qemu.git python
>>>> +
>>>> Python scripts
>>>> M: Eduardo Habkost <ehabkost@redhat.com>
>>>> M: Cleber Rosa <crosa@redhat.com>
>>>> S: Odd fixes
>>>> -F: python/qemu/*py
>>>> F: scripts/*.py
>>>> F: tests/*.py
>>>
>>> Separate sections just so you can have the appropriate S:, or is there a
>>> deeper logic behind the split?
>>>
>>
>> Yes, different intended levels of support. I don't currently have the
>> bandwidth to promise support for the miscellaneous Python scripts in
>> ./scripts, but I do promise to support to a higher level the code in
>> ./python.
>>
>> Over time, I intend to migrate things into ./python, but there are some
>> series that need to happen first before I start doing that.
>
> Also, the actual owners for most scripts in ./scripts are already
> listed elsewhere. I believe we shouldn't really have M: lines
> for the scripts/*.py section, just R:.
Agreed. Maybe worth a comment in the section although.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-09-23 16:49 ` Philippe Mathieu-Daudé
@ 2020-09-24 6:58 ` Markus Armbruster
2020-10-01 15:27 ` John Snow
1 sibling, 0 replies; 11+ messages in thread
From: Markus Armbruster @ 2020-09-24 6:58 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: peter.maydell, Eduardo Habkost, John Snow, Markus Armbruster,
qemu-devel, crosa, alex.bennee
Philippe Mathieu-Daudé <philmd@redhat.com> writes:
> On 9/23/20 5:37 PM, Eduardo Habkost wrote:
>> On Wed, Sep 23, 2020 at 11:17:01AM -0400, John Snow wrote:
>>> On 9/23/20 11:14 AM, Markus Armbruster wrote:
>>>> John Snow <jsnow@redhat.com> writes:
>>>>
>>>>> I'm proposing that I split the actual Python library off from the other
>>>>> miscellaneous python scripts we have and declare it maintained. Add
>>>>> myself as a maintainer of this folder, along with Cleber.
>>>>>
>>>>> v2: change python/* to python/, thanks Alex.
>>>>>
>>>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>>>>> Acked-by: Cleber Rosa <crosa@redhat.com>
>>>>> Acked-by: Eduardo Habkost <ehabkost@redhat.com>
>>>>> ---
>>>>> MAINTAINERS | 9 ++++++++-
>>>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index 3d17cad19a..c0222ee645 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -2355,11 +2355,18 @@ S: Maintained
>>>>> F: include/sysemu/cryptodev*.h
>>>>> F: backends/cryptodev*.c
>>>>> +Python library
>>>>> +M: John Snow <jsnow@redhat.com>
>>>>> +M: Cleber Rosa <crosa@redhat.com>
>>>>> +R: Eduardo Habkost <ehabkost@redhat.com>
>>>>> +S: Maintained
>>>>> +F: python/
>>>>> +T: git https://gitlab.com/jsnow/qemu.git python
>>>>> +
>>>>> Python scripts
>>>>> M: Eduardo Habkost <ehabkost@redhat.com>
>>>>> M: Cleber Rosa <crosa@redhat.com>
>>>>> S: Odd fixes
>>>>> -F: python/qemu/*py
>>>>> F: scripts/*.py
>>>>> F: tests/*.py
>>>>
>>>> Separate sections just so you can have the appropriate S:, or is there a
>>>> deeper logic behind the split?
>>>>
>>>
>>> Yes, different intended levels of support. I don't currently have the
>>> bandwidth to promise support for the miscellaneous Python scripts in
>>> ./scripts, but I do promise to support to a higher level the code in
>>> ./python.
>>>
>>> Over time, I intend to migrate things into ./python, but there are some
>>> series that need to happen first before I start doing that.
>>
>> Also, the actual owners for most scripts in ./scripts are already
>> listed elsewhere. I believe we shouldn't really have M: lines
>> for the scripts/*.py section, just R:.
Good point.
> Agreed. Maybe worth a comment in the section although.
Let's do it.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-09-23 16:49 ` Philippe Mathieu-Daudé
2020-09-24 6:58 ` Markus Armbruster
@ 2020-10-01 15:27 ` John Snow
2020-10-01 15:49 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 11+ messages in thread
From: John Snow @ 2020-10-01 15:27 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Eduardo Habkost
Cc: peter.maydell, crosa, alex.bennee, Markus Armbruster, qemu-devel
On 9/23/20 12:49 PM, Philippe Mathieu-Daudé wrote:
> On 9/23/20 5:37 PM, Eduardo Habkost wrote:
>> On Wed, Sep 23, 2020 at 11:17:01AM -0400, John Snow wrote:
>>> On 9/23/20 11:14 AM, Markus Armbruster wrote:
>>>> John Snow <jsnow@redhat.com> writes:
>>>>
>>>>> I'm proposing that I split the actual Python library off from the other
>>>>> miscellaneous python scripts we have and declare it maintained. Add
>>>>> myself as a maintainer of this folder, along with Cleber.
>>>>>
>>>>> v2: change python/* to python/, thanks Alex.
>>>>>
>>>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>>>>> Acked-by: Cleber Rosa <crosa@redhat.com>
>>>>> Acked-by: Eduardo Habkost <ehabkost@redhat.com>
>>>>> ---
>>>>> MAINTAINERS | 9 ++++++++-
>>>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index 3d17cad19a..c0222ee645 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -2355,11 +2355,18 @@ S: Maintained
>>>>> F: include/sysemu/cryptodev*.h
>>>>> F: backends/cryptodev*.c
>>>>> +Python library
>>>>> +M: John Snow <jsnow@redhat.com>
>>>>> +M: Cleber Rosa <crosa@redhat.com>
>>>>> +R: Eduardo Habkost <ehabkost@redhat.com>
>>>>> +S: Maintained
>>>>> +F: python/
>>>>> +T: git https://gitlab.com/jsnow/qemu.git python
>>>>> +
>>>>> Python scripts
>>>>> M: Eduardo Habkost <ehabkost@redhat.com>
>>>>> M: Cleber Rosa <crosa@redhat.com>
>>>>> S: Odd fixes
>>>>> -F: python/qemu/*py
>>>>> F: scripts/*.py
>>>>> F: tests/*.py
>>>>
>>>> Separate sections just so you can have the appropriate S:, or is there a
>>>> deeper logic behind the split?
>>>>
>>>
>>> Yes, different intended levels of support. I don't currently have the
>>> bandwidth to promise support for the miscellaneous Python scripts in
>>> ./scripts, but I do promise to support to a higher level the code in
>>> ./python.
>>>
>>> Over time, I intend to migrate things into ./python, but there are some
>>> series that need to happen first before I start doing that.
>>
>> Also, the actual owners for most scripts in ./scripts are already
>> listed elsewhere. I believe we shouldn't really have M: lines
>> for the scripts/*.py section, just R:.
>
> Agreed. Maybe worth a comment in the section although.
>
*in* the section? There is no precedent for that. Is this really so
important?
I'll give you a commit message blurb.
--js
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 1/1] MAINTAINERS: Add Python library stanza
2020-10-01 15:27 ` John Snow
@ 2020-10-01 15:49 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-01 15:49 UTC (permalink / raw)
To: John Snow, Eduardo Habkost
Cc: peter.maydell, crosa, alex.bennee, Markus Armbruster, qemu-devel
On 10/1/20 5:27 PM, John Snow wrote:
> On 9/23/20 12:49 PM, Philippe Mathieu-Daudé wrote:
>> On 9/23/20 5:37 PM, Eduardo Habkost wrote:
>>> On Wed, Sep 23, 2020 at 11:17:01AM -0400, John Snow wrote:
>>>> On 9/23/20 11:14 AM, Markus Armbruster wrote:
>>>>> John Snow <jsnow@redhat.com> writes:
>>>>>
>>>>>> I'm proposing that I split the actual Python library off from the
>>>>>> other
>>>>>> miscellaneous python scripts we have and declare it maintained. Add
>>>>>> myself as a maintainer of this folder, along with Cleber.
>>>>>>
>>>>>> v2: change python/* to python/, thanks Alex.
>>>>>>
>>>>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>>>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>>> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>>>>>> Acked-by: Cleber Rosa <crosa@redhat.com>
>>>>>> Acked-by: Eduardo Habkost <ehabkost@redhat.com>
>>>>>> ---
>>>>>> MAINTAINERS | 9 ++++++++-
>>>>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>> index 3d17cad19a..c0222ee645 100644
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -2355,11 +2355,18 @@ S: Maintained
>>>>>> F: include/sysemu/cryptodev*.h
>>>>>> F: backends/cryptodev*.c
>>>>>> +Python library
>>>>>> +M: John Snow <jsnow@redhat.com>
>>>>>> +M: Cleber Rosa <crosa@redhat.com>
>>>>>> +R: Eduardo Habkost <ehabkost@redhat.com>
>>>>>> +S: Maintained
>>>>>> +F: python/
>>>>>> +T: git https://gitlab.com/jsnow/qemu.git python
>>>>>> +
>>>>>> Python scripts
>>>>>> M: Eduardo Habkost <ehabkost@redhat.com>
>>>>>> M: Cleber Rosa <crosa@redhat.com>
>>>>>> S: Odd fixes
>>>>>> -F: python/qemu/*py
>>>>>> F: scripts/*.py
>>>>>> F: tests/*.py
>>>>>
>>>>> Separate sections just so you can have the appropriate S:, or is
>>>>> there a
>>>>> deeper logic behind the split?
>>>>>
>>>>
>>>> Yes, different intended levels of support. I don't currently have the
>>>> bandwidth to promise support for the miscellaneous Python scripts in
>>>> ./scripts, but I do promise to support to a higher level the code in
>>>> ./python.
>>>>
>>>> Over time, I intend to migrate things into ./python, but there are some
>>>> series that need to happen first before I start doing that.
>>>
>>> Also, the actual owners for most scripts in ./scripts are already
>>> listed elsewhere. I believe we shouldn't really have M: lines
>>> for the scripts/*.py section, just R:.
>>
>> Agreed. Maybe worth a comment in the section although.
>>
>
> *in* the section? There is no precedent for that. Is this really so
> important?
Well if this file is only consumed by scripts, and no human reads it,
then it is pointless indeed.
>
> I'll give you a commit message blurb.
That sometime works, thanks.
>
> --js
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-10-01 16:12 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22 23:05 [PATCH v2 0/1] MAINTAINERS: Add Python library stanza John Snow
2020-09-22 23:05 ` [PATCH v2 1/1] " John Snow
2020-09-23 7:49 ` Philippe Mathieu-Daudé
2020-09-23 14:30 ` John Snow
2020-09-23 15:14 ` Markus Armbruster
2020-09-23 15:17 ` John Snow
2020-09-23 15:37 ` Eduardo Habkost
2020-09-23 16:49 ` Philippe Mathieu-Daudé
2020-09-24 6:58 ` Markus Armbruster
2020-10-01 15:27 ` John Snow
2020-10-01 15:49 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.