From: Dalon L Westergreen <dalon.westergreen@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/8] ARM: socfpga: arria10: Add generic handoff devicetree include
Date: Mon, 07 Oct 2019 07:34:30 -0700 [thread overview]
Message-ID: <0683984be3f4f8ac6c5e9ac94e3f110663803a26.camel@linux.intel.com> (raw)
In-Reply-To: <5f982476-610e-cde3-391e-c7ad1f1990f0@gmail.com>
On Sun, 2019-10-06 at 20:05 +0200, Simon Goldschmidt wrote:
> Am 06.10.2019 um 19:44 schrieb Dalon L Westergreen:
> > On Sun, 2019-10-06 at 15:44 +0200, Marek Vasut wrote:
> > > On 10/6/19 1:19 AM, Dalon L Westergreen wrote:
> > > > On Sat, 2019-10-05 at 01:51 +0200, Marek Vasut wrote:
> > > > > On 10/5/19 12:30 AM, Dalon Westergreen wrote:
> > > > > > From: Dalon Westergreen <dalon.westergreen@intel.com
> > > > > > <mailto:dalon.westergreen@intel.com>
> > > > > > Generic handoff devicetree include uses a header generated bythe
> > > > > > qts-filter-a10.sh script in mach-socfpga. The scriptcreates the
> > > > > > header based on designspecific implementationsfor clock and pinmux
> > > > > > configurations.
> > > > >
> > > > > [...]
> > > > > > diff --git a/arch/arm/dts/socfpga_arria10_handoff_u-
> > > > > > boot.dtsib/arch/arm/dts/socfpga_arria10_handoff_u-boot.dtsi
> > > > >
> > > > > [...]
> > > > > > - clock_manager at 0xffd04000 {+ clkmgr at 0xffd04000 {+ comp
> > > > > > atible ="altr,socfpga-a10-clk-init";+ reg =
> > > > > > <0xffd04000 0x00000200>;+ reg-names =
> > > > > > "soc_clock_manager_OCP_SLV"; u-boot,dm-pre-reloc;
> > > > > > mainpll {+ vco0-psrc =<MAINPLLGRP_VCO0_PSRC>;+
> > > > > > vco1-denom =<MAINPLLGRP_VCO1_DENOM>;+
> > > > > > vco1-numer =<MAINPLLGRP_VCO1_NUMER>;
> > > > >
> > > > > But these bits are board-specific , they shouldn't be in common DT.
> > > >
> > > > This common dtsi requires that the top level u-boot.dtsi include the
> > > > boardspecific header. The formatand #define names are in fact common.
> > >
> > > OK, I now see what you're doing here. Can you explain that in a bit
> > > moredetail in the commit message ?
> > > Basically socfpga_board.h is included socfpga_board.dts , and then
> > > thepreprocessor correctly expands the values from socfpga_board.h in
> > > thesocfpga_board.dts , so this works for multiple boards too ?
> >
> > Exactly. Will add more detail in the commit message, and slim down the
> > included clocks inthe u-boot.dtsi
>
> I'm (still) working on a series to bring gen5 completely to devicetree, so
> that the 'qts' directories can be removed. I chose a different approach
> however, in that I generated everything into a '-handoff.dtsi' file (*). I'd
> be happy if we could find a common mechanism for all socfpga sub-archs. How
> does S10/Agilex handle this?
> (*): Gen5 has the downside that we're low on memory in SPL (regarding DM), and
> as we require large binary arrays there, I chose to encode the binary blob
> arrays in host byte order so that they could be used in-place instead of
> copying them from BE (dtb) to LE (stack/heap). Maybe that doesn't fit
> A10/S10/Agilex anyway?
Can you share your patch set with me, privately or otherwise, just so we can
take a similarapproach in the devicetree?
Also, have you looked at the bsp-editor python source that generates the
"generated" filesfrom the bsp-editor?
19.1std/647/linux64/ip/altera/preloader/scripts
I am hoping to replace these with a script included in the u-boot
source. iocsr.py doesa bunch of binary parsing.
--dalon
> Regards,Simon
next prev parent reply other threads:[~2019-10-07 14:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 22:30 [U-Boot] [PATCH 0/8] ARM: socfpga: arria10: Cleanup devicetree and Dalon Westergreen
2019-10-04 22:30 ` [U-Boot] [PATCH 1/8] ARM: socfpga: arria10: Add qts-filter for arria10 socfpga Dalon Westergreen
2019-10-04 23:47 ` Marek Vasut
2019-10-05 23:22 ` Dalon L Westergreen
2019-10-12 13:28 ` Chee, Tien Fong
2019-10-04 22:30 ` [U-Boot] [PATCH 2/8] ARM: socfpga: arria10: Sync A10 SoCDK devicetrees Dalon Westergreen
2019-10-04 23:47 ` Marek Vasut
2019-10-05 23:23 ` Dalon L Westergreen
2019-10-07 14:03 ` Dalon L Westergreen
2019-10-07 14:06 ` Marek Vasut
2019-10-07 14:49 ` Dalon L Westergreen
2019-10-07 15:16 ` Dalon L Westergreen
2019-10-04 22:30 ` [U-Boot] [PATCH 3/8] ARM: socfpga: arria10: Add common u-boot devicetree include Dalon Westergreen
2019-10-04 23:49 ` Marek Vasut
2019-10-05 23:25 ` Dalon L Westergreen
2019-10-06 13:40 ` Marek Vasut
2019-10-07 3:30 ` Dalon L Westergreen
2019-10-07 14:04 ` Simon Goldschmidt
2019-10-04 22:30 ` [U-Boot] [PATCH 4/8] ARM: socfpga: arria10: Add generic handoff " Dalon Westergreen
2019-10-04 23:51 ` Marek Vasut
2019-10-05 23:19 ` Dalon L Westergreen
2019-10-06 13:44 ` Marek Vasut
2019-10-06 17:44 ` Dalon L Westergreen
2019-10-06 18:05 ` Simon Goldschmidt
2019-10-06 23:04 ` Dalon L Westergreen
2019-10-07 14:34 ` Dalon L Westergreen [this message]
2019-10-07 14:45 ` Simon Goldschmidt
2019-10-08 17:08 ` Dalon L Westergreen
2019-10-06 23:06 ` Dalon L Westergreen
2019-10-04 22:30 ` [U-Boot] [PATCH 5/8] ARM: socfpga: arria10: Add handoff header for A10 SoCDK SDMMC Dalon Westergreen
2019-10-04 22:30 ` [U-Boot] [PATCH 6/8] ARM: socfpga: arria10: Add u-boot include for A10 SoCDK SDMMC devicetree Dalon Westergreen
2019-10-04 22:30 ` [U-Boot] [PATCH 7/8] ARM: socfpga: arria10: Remove old A10 SoCDK Handoff dtsi Dalon Westergreen
2019-10-04 22:30 ` [U-Boot] [PATCH 8/8] ARM: socfpga: Update README.socfpga to add qts-filter-a10 Dalon Westergreen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0683984be3f4f8ac6c5e9ac94e3f110663803a26.camel@linux.intel.com \
--to=dalon.westergreen@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.