* [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter
@ 2022-05-23 9:24 Chesnokov Gleb
2022-05-23 14:20 ` Chesnokov Gleb
2022-05-24 18:09 ` Himanshu Madhani
0 siblings, 2 replies; 7+ messages in thread
From: Chesnokov Gleb @ 2022-05-23 9:24 UTC (permalink / raw)
To: linux-scsi
The ql_dm_tgt_ex_pct parameter was introduced in commit ead038556f64
("qla2xxx: Add Dual mode support in the driver"). Then the use of this parameter
was dropped in commit 99e1b683c4be ("scsi: qla2xxx: Add ql2xiniexchg parameter").
Thus, remove ql_dm_tgt_ex_pct since it is no longer used.
---
drivers/scsi/qla2xxx/qla_target.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 6dfcfd8e7337..d03b9223b75e 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -48,13 +48,6 @@ MODULE_PARM_DESC(qlini_mode,
"when ready "
"\"enabled\" (default) - initiator mode will always stay enabled.");
-static int ql_dm_tgt_ex_pct = 0;
-module_param(ql_dm_tgt_ex_pct, int, S_IRUGO|S_IWUSR);
-MODULE_PARM_DESC(ql_dm_tgt_ex_pct,
- "For Dual Mode (qlini_mode=dual), this parameter determines "
- "the percentage of exchanges/cmds FW will allocate resources "
- "for Target mode.");
-
int ql2xuctrlirq = 1;
module_param(ql2xuctrlirq, int, 0644);
MODULE_PARM_DESC(ql2xuctrlirq,
--
2.36.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter
2022-05-23 9:24 [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter Chesnokov Gleb
@ 2022-05-23 14:20 ` Chesnokov Gleb
2022-05-24 18:09 ` Himanshu Madhani
1 sibling, 0 replies; 7+ messages in thread
From: Chesnokov Gleb @ 2022-05-23 14:20 UTC (permalink / raw)
To: linux-scsi
> The ql_dm_tgt_ex_pct parameter was introduced in commit ead038556f64
> ("qla2xxx: Add Dual mode support in the driver"). Then the use of this parameter
> was dropped in commit 99e1b683c4be ("scsi: qla2xxx: Add ql2xiniexchg parameter").
>
> Thus, remove ql_dm_tgt_ex_pct since it is no longer used.
> ---
> drivers/scsi/qla2xxx/qla_target.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 6dfcfd8e7337..d03b9223b75e 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -48,13 +48,6 @@ MODULE_PARM_DESC(qlini_mode,
> "when ready "
> "\"enabled\" (default) - initiator mode will always stay enabled.");
>
> -static int ql_dm_tgt_ex_pct = 0;
> -module_param(ql_dm_tgt_ex_pct, int, S_IRUGO|S_IWUSR);
> -MODULE_PARM_DESC(ql_dm_tgt_ex_pct,
> - "For Dual Mode (qlini_mode=dual), this parameter determines "
> - "the percentage of exchanges/cmds FW will allocate resources "
> - "for Target mode.");
> -
> int ql2xuctrlirq = 1;
> module_param(ql2xuctrlirq, int, 0644);
> MODULE_PARM_DESC(ql2xuctrlirq,
> --
> 2.36.1
I'm sorry, I forgot to add Signed-off-by: Gleb Chesnokov <Chesnokov.G@raidix.com>
Best Regards,
Gleb.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter
2022-05-23 9:24 [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter Chesnokov Gleb
2022-05-23 14:20 ` Chesnokov Gleb
@ 2022-05-24 18:09 ` Himanshu Madhani
2022-05-25 14:52 ` Chesnokov Gleb
1 sibling, 1 reply; 7+ messages in thread
From: Himanshu Madhani @ 2022-05-24 18:09 UTC (permalink / raw)
To: Chesnokov Gleb; +Cc: linux-scsi
> On May 23, 2022, at 2:24 AM, Chesnokov Gleb <Chesnokov.G@raidix.com> wrote:
>
> The ql_dm_tgt_ex_pct parameter was introduced in commit ead038556f64
> ("qla2xxx: Add Dual mode support in the driver"). Then the use of this parameter
> was dropped in commit 99e1b683c4be ("scsi: qla2xxx: Add ql2xiniexchg parameter").
>
> Thus, remove ql_dm_tgt_ex_pct since it is no longer used.
> ---
> drivers/scsi/qla2xxx/qla_target.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index 6dfcfd8e7337..d03b9223b75e 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -48,13 +48,6 @@ MODULE_PARM_DESC(qlini_mode,
> "when ready "
> "\"enabled\" (default) - initiator mode will always stay enabled.");
>
> -static int ql_dm_tgt_ex_pct = 0;
> -module_param(ql_dm_tgt_ex_pct, int, S_IRUGO|S_IWUSR);
> -MODULE_PARM_DESC(ql_dm_tgt_ex_pct,
> - "For Dual Mode (qlini_mode=dual), this parameter determines "
> - "the percentage of exchanges/cmds FW will allocate resources "
> - "for Target mode.");
> -
> int ql2xuctrlirq = 1;
> module_param(ql2xuctrlirq, int, 0644);
> MODULE_PARM_DESC(ql2xuctrlirq,
> --
> 2.36.1
Once s-o-b is fixed, Please add
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter
2022-05-24 18:09 ` Himanshu Madhani
@ 2022-05-25 14:52 ` Chesnokov Gleb
2022-05-25 15:16 ` Himanshu Madhani
0 siblings, 1 reply; 7+ messages in thread
From: Chesnokov Gleb @ 2022-05-25 14:52 UTC (permalink / raw)
To: Himanshu Madhani; +Cc: linux-scsi
> Once s-o-b is fixed, Please add
>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
I'm still newbie in linux kernel contribution, so I'm not sure what exactly I need to do.
Do I need to resend the patch with fixed s-o-b as a second version?
Thanks,
Gleb.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter
2022-05-25 14:52 ` Chesnokov Gleb
@ 2022-05-25 15:16 ` Himanshu Madhani
2022-05-25 15:41 ` Chesnokov Gleb
0 siblings, 1 reply; 7+ messages in thread
From: Himanshu Madhani @ 2022-05-25 15:16 UTC (permalink / raw)
To: Chesnokov Gleb; +Cc: linux-scsi
> On May 25, 2022, at 7:52 AM, Chesnokov Gleb <Chesnokov.G@raidix.com> wrote:
>
>> Once s-o-b is fixed, Please add
>>
>> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
>
> I'm still newbie in linux kernel contribution, so I'm not sure what exactly I need to do.
> Do I need to resend the patch with fixed s-o-b as a second version?
It will be easier for the maintainer to pick up the patch if you resend with SOB and RB added.
>
> Thanks,
> Gleb.
--
Himanshu Madhani Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter
2022-05-25 15:16 ` Himanshu Madhani
@ 2022-05-25 15:41 ` Chesnokov Gleb
2022-06-02 2:49 ` Martin K. Petersen
0 siblings, 1 reply; 7+ messages in thread
From: Chesnokov Gleb @ 2022-05-25 15:41 UTC (permalink / raw)
To: Himanshu Madhani; +Cc: linux-scsi
The ql_dm_tgt_ex_pct parameter was introduced in commit ead038556f64
("qla2xxx: Add Dual mode support in the driver"). Then the use of this parameter
was dropped in commit 99e1b683c4be ("scsi: qla2xxx: Add ql2xiniexchg parameter").
Thus, remove ql_dm_tgt_ex_pct since it is no longer used.
Signed-off-by: Gleb Chesnokov <Chesnokov.G@raidix.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
---
drivers/scsi/qla2xxx/qla_target.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 6dfcfd8e7337..d03b9223b75e 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -48,13 +48,6 @@ MODULE_PARM_DESC(qlini_mode,
"when ready "
"\"enabled\" (default) - initiator mode will always stay enabled.");
-static int ql_dm_tgt_ex_pct = 0;
-module_param(ql_dm_tgt_ex_pct, int, S_IRUGO|S_IWUSR);
-MODULE_PARM_DESC(ql_dm_tgt_ex_pct,
- "For Dual Mode (qlini_mode=dual), this parameter determines "
- "the percentage of exchanges/cmds FW will allocate resources "
- "for Target mode.");
-
int ql2xuctrlirq = 1;
module_param(ql2xuctrlirq, int, 0644);
MODULE_PARM_DESC(ql2xuctrlirq,
--
2.36.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter
2022-05-25 15:41 ` Chesnokov Gleb
@ 2022-06-02 2:49 ` Martin K. Petersen
0 siblings, 0 replies; 7+ messages in thread
From: Martin K. Petersen @ 2022-06-02 2:49 UTC (permalink / raw)
To: Chesnokov Gleb; +Cc: Himanshu Madhani, linux-scsi
Chesnokov,
> The ql_dm_tgt_ex_pct parameter was introduced in commit ead038556f64
> ("qla2xxx: Add Dual mode support in the driver"). Then the use of this
> parameter was dropped in commit 99e1b683c4be ("scsi: qla2xxx: Add
> ql2xiniexchg parameter").
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-06-02 2:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23 9:24 [PATCH 1/1] qla2xxx: Remove unused ql_dm_tgt_ex_pct parameter Chesnokov Gleb
2022-05-23 14:20 ` Chesnokov Gleb
2022-05-24 18:09 ` Himanshu Madhani
2022-05-25 14:52 ` Chesnokov Gleb
2022-05-25 15:16 ` Himanshu Madhani
2022-05-25 15:41 ` Chesnokov Gleb
2022-06-02 2:49 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.