* [PATCH -next] leds: max77650: Remove set but not used variable 'parent'
@ 2019-05-25 14:19 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2019-05-25 14:19 UTC (permalink / raw)
To: bgolaszewski, jacek.anaszewski, pavel, dmurphy
Cc: linux-kernel, linux-leds, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/leds/leds-max77650.c: In function max77650_led_probe:
drivers/leds/leds-max77650.c:67:17: warning: variable parent set but not used [-Wunused-but-set-variable]
It is never used and can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/leds/leds-max77650.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c
index 6b74ce9cac12..8a8e5c65b157 100644
--- a/drivers/leds/leds-max77650.c
+++ b/drivers/leds/leds-max77650.c
@@ -64,7 +64,6 @@ static int max77650_led_probe(struct platform_device *pdev)
{
struct device_node *of_node, *child;
struct max77650_led *leds, *led;
- struct device *parent;
struct device *dev;
struct regmap *map;
const char *label;
@@ -72,7 +71,6 @@ static int max77650_led_probe(struct platform_device *pdev)
u32 reg;
dev = &pdev->dev;
- parent = dev->parent;
of_node = dev->of_node;
if (!of_node)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH -next] leds: max77650: Remove set but not used variable 'parent'
@ 2019-05-25 14:19 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2019-05-25 14:19 UTC (permalink / raw)
To: bgolaszewski, jacek.anaszewski, pavel, dmurphy
Cc: linux-kernel, linux-leds, YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/leds/leds-max77650.c: In function max77650_led_probe:
drivers/leds/leds-max77650.c:67:17: warning: variable parent set but not used [-Wunused-but-set-variable]
It is never used and can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/leds/leds-max77650.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c
index 6b74ce9cac12..8a8e5c65b157 100644
--- a/drivers/leds/leds-max77650.c
+++ b/drivers/leds/leds-max77650.c
@@ -64,7 +64,6 @@ static int max77650_led_probe(struct platform_device *pdev)
{
struct device_node *of_node, *child;
struct max77650_led *leds, *led;
- struct device *parent;
struct device *dev;
struct regmap *map;
const char *label;
@@ -72,7 +71,6 @@ static int max77650_led_probe(struct platform_device *pdev)
u32 reg;
dev = &pdev->dev;
- parent = dev->parent;
of_node = dev->of_node;
if (!of_node)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] leds: max77650: Remove set but not used variable 'parent'
2019-05-25 14:19 ` YueHaibing
(?)
@ 2019-05-26 17:11 ` Jacek Anaszewski
-1 siblings, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2019-05-26 17:11 UTC (permalink / raw)
To: YueHaibing, bgolaszewski, pavel, dmurphy; +Cc: linux-kernel, linux-leds
Hi YueHaibing,
Thank you for the patch.
On 5/25/19 4:19 PM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/leds/leds-max77650.c: In function max77650_led_probe:
> drivers/leds/leds-max77650.c:67:17: warning: variable parent set but not used [-Wunused-but-set-variable]
>
> It is never used and can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/leds/leds-max77650.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/leds/leds-max77650.c b/drivers/leds/leds-max77650.c
> index 6b74ce9cac12..8a8e5c65b157 100644
> --- a/drivers/leds/leds-max77650.c
> +++ b/drivers/leds/leds-max77650.c
> @@ -64,7 +64,6 @@ static int max77650_led_probe(struct platform_device *pdev)
> {
> struct device_node *of_node, *child;
> struct max77650_led *leds, *led;
> - struct device *parent;
> struct device *dev;
> struct regmap *map;
> const char *label;
> @@ -72,7 +71,6 @@ static int max77650_led_probe(struct platform_device *pdev)
> u32 reg;
>
> dev = &pdev->dev;
> - parent = dev->parent;
> of_node = dev->of_node;
>
> if (!of_node)
>
Applied.
--
Best regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-26 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-25 14:19 [PATCH -next] leds: max77650: Remove set but not used variable 'parent' YueHaibing
2019-05-25 14:19 ` YueHaibing
2019-05-26 17:11 ` Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.