* [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi
@ 2015-01-15 13:51 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2015-01-15 13:51 UTC (permalink / raw)
To: kgene; +Cc: olof, arnd, linux-samsung-soc, linux-arm-kernel, Sylwester Nawrocki
Assign proper FIMC-IS UART gate clock in the device DT node and not
use the SRC_MASK gate. This fixes regression introduced in commit
a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove
SRC_MASK_ISP gates").
Without this change exynos4 fimc-is driver fails to probe with an
error log:
[ 1.842447] ERROR: could not get clock /camera/fimc-is@12000000:uart(13)
[ 1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
[ 1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Kukjin, could you take this patch into your tree ? I have been applying it
for several kernel releases now to get the Exynos4 FIMC driver even passing
probing.
Thanks,
Sylwester
arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 93b7040..86e1800 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -225,7 +225,7 @@
<&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
<&clock CLK_DIV_MCUISP0>,
<&clock CLK_DIV_MCUISP1>,
- <&clock CLK_SCLK_UART_ISP>,
+ <&clock CLK_UART_ISP_SCLK>,
<&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
<&clock CLK_ACLK400_MCUISP>,
<&clock CLK_DIV_ACLK400_MCUISP>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi
@ 2015-01-15 13:51 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2015-01-15 13:51 UTC (permalink / raw)
To: linux-arm-kernel
Assign proper FIMC-IS UART gate clock in the device DT node and not
use the SRC_MASK gate. This fixes regression introduced in commit
a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove
SRC_MASK_ISP gates").
Without this change exynos4 fimc-is driver fails to probe with an
error log:
[ 1.842447] ERROR: could not get clock /camera/fimc-is at 12000000:uart(13)
[ 1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
[ 1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Kukjin, could you take this patch into your tree ? I have been applying it
for several kernel releases now to get the Exynos4 FIMC driver even passing
probing.
Thanks,
Sylwester
arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 93b7040..86e1800 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -225,7 +225,7 @@
<&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
<&clock CLK_DIV_MCUISP0>,
<&clock CLK_DIV_MCUISP1>,
- <&clock CLK_SCLK_UART_ISP>,
+ <&clock CLK_UART_ISP_SCLK>,
<&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
<&clock CLK_ACLK400_MCUISP>,
<&clock CLK_DIV_ACLK400_MCUISP>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi
2015-01-15 13:51 ` Sylwester Nawrocki
@ 2015-02-03 4:12 ` Kukjin Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2015-02-03 4:12 UTC (permalink / raw)
To: 'Sylwester Nawrocki', kgene
Cc: olof, linux-samsung-soc, linux-arm-kernel, arnd
Sylwester Nawrocki wrote:
>
> Assign proper FIMC-IS UART gate clock in the device DT node and not
> use the SRC_MASK gate. This fixes regression introduced in commit
> a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove
> SRC_MASK_ISP gates").
>
> Without this change exynos4 fimc-is driver fails to probe with an
> error log:
>
> [ 1.842447] ERROR: could not get clock /camera/fimc-is@12000000:uart(13)
> [ 1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
> [ 1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>
> Kukjin, could you take this patch into your tree ? I have been applying it
> for several kernel releases now to get the Exynos4 FIMC driver even passing
> probing.
>
> Thanks,
> Sylwester
> arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index 93b7040..86e1800 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -225,7 +225,7 @@
> <&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
> <&clock CLK_DIV_MCUISP0>,
> <&clock CLK_DIV_MCUISP1>,
> - <&clock CLK_SCLK_UART_ISP>,
> + <&clock CLK_UART_ISP_SCLK>,
> <&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
> <&clock CLK_ACLK400_MCUISP>,
> <&clock CLK_DIV_ACLK400_MCUISP>;
> --
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi
@ 2015-02-03 4:12 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2015-02-03 4:12 UTC (permalink / raw)
To: linux-arm-kernel
Sylwester Nawrocki wrote:
>
> Assign proper FIMC-IS UART gate clock in the device DT node and not
> use the SRC_MASK gate. This fixes regression introduced in commit
> a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove
> SRC_MASK_ISP gates").
>
> Without this change exynos4 fimc-is driver fails to probe with an
> error log:
>
> [ 1.842447] ERROR: could not get clock /camera/fimc-is at 12000000:uart(13)
> [ 1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
> [ 1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>
> Kukjin, could you take this patch into your tree ? I have been applying it
> for several kernel releases now to get the Exynos4 FIMC driver even passing
> probing.
>
> Thanks,
> Sylwester
> arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index 93b7040..86e1800 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -225,7 +225,7 @@
> <&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
> <&clock CLK_DIV_MCUISP0>,
> <&clock CLK_DIV_MCUISP1>,
> - <&clock CLK_SCLK_UART_ISP>,
> + <&clock CLK_UART_ISP_SCLK>,
> <&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
> <&clock CLK_ACLK400_MCUISP>,
> <&clock CLK_DIV_ACLK400_MCUISP>;
> --
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi
@ 2014-10-31 13:34 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2014-10-31 13:34 UTC (permalink / raw)
To: kgene.kim; +Cc: linux-arm-kernel, linux-samsung-soc, Sylwester Nawrocki
Assign proper FIMC-IS UART gate clock in the device DT node and not
use the SRC_MASK gate. This fixes regression introduced in commit
a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove
SRC_MASK_ISP gates").
Without this change exynos4 fimc-is driver fails to probe with an
error log:
[ 1.842447] ERROR: could not get clock /camera/fimc-is@12000000:uart(13)
[ 1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
[ 1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 861bb91..dd98768 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -224,7 +224,7 @@
<&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
<&clock CLK_DIV_MCUISP0>,
<&clock CLK_DIV_MCUISP1>,
- <&clock CLK_SCLK_UART_ISP>,
+ <&clock CLK_UART_ISP_SCLK>,
<&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
<&clock CLK_ACLK400_MCUISP>,
<&clock CLK_DIV_ACLK400_MCUISP>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi
@ 2014-10-31 13:34 ` Sylwester Nawrocki
0 siblings, 0 replies; 6+ messages in thread
From: Sylwester Nawrocki @ 2014-10-31 13:34 UTC (permalink / raw)
To: linux-arm-kernel
Assign proper FIMC-IS UART gate clock in the device DT node and not
use the SRC_MASK gate. This fixes regression introduced in commit
a37c82a3b3c0910019abfd22a97be1f ("clk: samsung: exynos4: Remove
SRC_MASK_ISP gates").
Without this change exynos4 fimc-is driver fails to probe with an
error log:
[ 1.842447] ERROR: could not get clock /camera/fimc-is at 12000000:uart(13)
[ 1.848529] exynos4-fimc-is 12000000.fimc-is: failed to get clock: uart
[ 1.855275] exynos4-fimc-is: probe of 12000000.fimc-is failed with error -2
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
arch/arm/boot/dts/exynos4x12.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index 861bb91..dd98768 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -224,7 +224,7 @@
<&clock CLK_DIV_ISP0>,<&clock CLK_DIV_ISP1>,
<&clock CLK_DIV_MCUISP0>,
<&clock CLK_DIV_MCUISP1>,
- <&clock CLK_SCLK_UART_ISP>,
+ <&clock CLK_UART_ISP_SCLK>,
<&clock CLK_ACLK200>, <&clock CLK_DIV_ACLK200>,
<&clock CLK_ACLK400_MCUISP>,
<&clock CLK_DIV_ACLK400_MCUISP>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-03 4:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-15 13:51 [PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi Sylwester Nawrocki
2015-01-15 13:51 ` Sylwester Nawrocki
2015-02-03 4:12 ` Kukjin Kim
2015-02-03 4:12 ` Kukjin Kim
-- strict thread matches above, loose matches on Subject: below --
2014-10-31 13:34 Sylwester Nawrocki
2014-10-31 13:34 ` Sylwester Nawrocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.