* [PATCH v2] mt76: mt7615: set proper length in strncmp
@ 2020-02-05 18:31 ` Ryder Lee
0 siblings, 0 replies; 2+ messages in thread
From: Ryder Lee @ 2020-02-05 18:31 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi
Cc: Shayne Chen, Sean Wang, Evelyn Tsai, Chih-Min Chen,
linux-wireless, linux-mediatek, Ryder Lee
Use sizeof(hdr->fw_ver) as max len.
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
---
changes since v2 - use sizeof() instead.
---
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index 6639f9291721..c3c01e095926 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -491,7 +491,7 @@ static int mt7615_load_ram(struct mt7615_dev *dev)
goto out;
}
- if (!strncmp(hdr->fw_ver, "2.0", 6))
+ if (!strncmp(hdr->fw_ver, "2.0", sizeof(hdr->fw_ver)))
dev->fw_ver = MT7615_FIRMWARE_V2;
else
dev->fw_ver = MT7615_FIRMWARE_V1;
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2] mt76: mt7615: set proper length in strncmp
@ 2020-02-05 18:31 ` Ryder Lee
0 siblings, 0 replies; 2+ messages in thread
From: Ryder Lee @ 2020-02-05 18:31 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi
Cc: Ryder Lee, Evelyn Tsai, Chih-Min Chen, Sean Wang, linux-wireless,
linux-mediatek, Shayne Chen
Use sizeof(hdr->fw_ver) as max len.
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
---
changes since v2 - use sizeof() instead.
---
drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index 6639f9291721..c3c01e095926 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -491,7 +491,7 @@ static int mt7615_load_ram(struct mt7615_dev *dev)
goto out;
}
- if (!strncmp(hdr->fw_ver, "2.0", 6))
+ if (!strncmp(hdr->fw_ver, "2.0", sizeof(hdr->fw_ver)))
dev->fw_ver = MT7615_FIRMWARE_V2;
else
dev->fw_ver = MT7615_FIRMWARE_V1;
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-05 18:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 18:31 [PATCH v2] mt76: mt7615: set proper length in strncmp Ryder Lee
2020-02-05 18:31 ` Ryder Lee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.