* [syzbot] KMSAN: uninit-value in asix_mdio_read (3) @ 2022-03-13 7:35 syzbot 2022-03-13 17:42 ` Pavel Skripkin 0 siblings, 1 reply; 4+ messages in thread From: syzbot @ 2022-03-13 7:35 UTC (permalink / raw) To: andrew, davem, glider, kuba, linux-kernel, linux-usb, linux, netdev, paskripkin, syzkaller-bugs Hello, syzbot found the following issue on: HEAD commit: 724946410067 x86: kmsan: enable KMSAN builds for x86 git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=158dd1f6700000 kernel config: https://syzkaller.appspot.com/x/.config?x=28718f555f258365 dashboard link: https://syzkaller.appspot.com/bug?extid=9ed16c369e0f40e366b2 compiler: clang version 14.0.0 (/usr/local/google/src/llvm-git-monorepo 2b554920f11c8b763cd9ed9003f4e19b919b8e1f), GNU ld (GNU Binutils for Debian) 2.35.2 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11b31281700000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15e8c4ee700000 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+9ed16c369e0f40e366b2@syzkaller.appspotmail.com asix 1-1:0.0 (unnamed net_device) (uninitialized): Failed to enable software MII access asix 1-1:0.0 (unnamed net_device) (uninitialized): Failed to read reg index 0x0000: -71 ===================================================== BUG: KMSAN: uninit-value in asix_check_host_enable drivers/net/usb/asix_common.c:84 [inline] BUG: KMSAN: uninit-value in asix_mdio_read+0x537/0xa40 drivers/net/usb/asix_common.c:499 asix_check_host_enable drivers/net/usb/asix_common.c:84 [inline] asix_mdio_read+0x537/0xa40 drivers/net/usb/asix_common.c:499 asix_mdio_bus_read+0xba/0xe0 drivers/net/usb/asix_common.c:558 __mdiobus_read+0xbf/0x4f0 drivers/net/phy/mdio_bus.c:762 mdiobus_read+0xaa/0xf0 drivers/net/phy/mdio_bus.c:869 get_phy_c22_id drivers/net/phy/phy_device.c:813 [inline] get_phy_device+0x218/0x8b0 drivers/net/phy/phy_device.c:890 mdiobus_scan+0x1c7/0x940 __mdiobus_register+0xe6c/0x11a0 drivers/net/phy/mdio_bus.c:589 __devm_mdiobus_register+0x18f/0x2f0 drivers/net/phy/mdio_devres.c:87 ax88772_init_mdio drivers/net/usb/asix_devices.c:676 [inline] ax88772_bind+0x10b1/0x1770 drivers/net/usb/asix_devices.c:786 usbnet_probe+0x1251/0x4160 drivers/net/usb/usbnet.c:1747 usb_probe_interface+0xf19/0x1600 drivers/usb/core/driver.c:396 really_probe+0x653/0x14b0 drivers/base/dd.c:596 __driver_probe_device+0x3e9/0x530 drivers/base/dd.c:752 driver_probe_device drivers/base/dd.c:782 [inline] __device_attach_driver+0x79f/0x1120 drivers/base/dd.c:899 bus_for_each_drv+0x2d6/0x3f0 drivers/base/bus.c:427 __device_attach+0x593/0x8e0 drivers/base/dd.c:970 device_initial_probe+0x4a/0x60 drivers/base/dd.c:1017 bus_probe_device+0x17b/0x3e0 drivers/base/bus.c:487 device_add+0x1fff/0x26e0 drivers/base/core.c:3405 usb_set_configuration+0x37e9/0x3ed0 drivers/usb/core/message.c:2170 usb_generic_driver_probe+0x13c/0x300 drivers/usb/core/generic.c:238 usb_probe_device+0x309/0x570 drivers/usb/core/driver.c:293 really_probe+0x653/0x14b0 drivers/base/dd.c:596 __driver_probe_device+0x3e9/0x530 drivers/base/dd.c:752 driver_probe_device drivers/base/dd.c:782 [inline] __device_attach_driver+0x79f/0x1120 drivers/base/dd.c:899 bus_for_each_drv+0x2d6/0x3f0 drivers/base/bus.c:427 __device_attach+0x593/0x8e0 drivers/base/dd.c:970 device_initial_probe+0x4a/0x60 drivers/base/dd.c:1017 bus_probe_device+0x17b/0x3e0 drivers/base/bus.c:487 device_add+0x1fff/0x26e0 drivers/base/core.c:3405 usb_new_device+0x1b8e/0x2950 drivers/usb/core/hub.c:2566 hub_port_connect drivers/usb/core/hub.c:5358 [inline] hub_port_connect_change drivers/usb/core/hub.c:5502 [inline] port_event drivers/usb/core/hub.c:5660 [inline] hub_event+0x58e3/0x89e0 drivers/usb/core/hub.c:5742 process_one_work+0xdb6/0x1820 kernel/workqueue.c:2307 worker_thread+0x10b3/0x21e0 kernel/workqueue.c:2454 kthread+0x3c7/0x500 kernel/kthread.c:377 ret_from_fork+0x1f/0x30 Local variable smsr.i created at: asix_mdio_read+0xaf/0xa40 drivers/net/usb/asix_common.c:499 asix_mdio_bus_read+0xba/0xe0 drivers/net/usb/asix_common.c:558 CPU: 0 PID: 7 Comm: kworker/0:1 Not tainted 5.17.0-rc4-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: usb_hub_wq hub_event ===================================================== --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller@googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. syzbot can test patches for this issue, for details see: https://goo.gl/tpsmEJ#testing-patches ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [syzbot] KMSAN: uninit-value in asix_mdio_read (3) 2022-03-13 7:35 [syzbot] KMSAN: uninit-value in asix_mdio_read (3) syzbot @ 2022-03-13 17:42 ` Pavel Skripkin 2022-03-13 17:57 ` syzbot 0 siblings, 1 reply; 4+ messages in thread From: Pavel Skripkin @ 2022-03-13 17:42 UTC (permalink / raw) To: syzbot, andrew, davem, glider, kuba, linux-kernel, linux-usb, linux, netdev, syzkaller-bugs [-- Attachment #1: Type: text/plain, Size: 965 bytes --] On 3/13/22 10:35, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 724946410067 x86: kmsan: enable KMSAN builds for x86 > git tree: https://github.com/google/kmsan.git master > console output: https://syzkaller.appspot.com/x/log.txt?x=158dd1f6700000 > kernel config: https://syzkaller.appspot.com/x/.config?x=28718f555f258365 > dashboard link: https://syzkaller.appspot.com/bug?extid=9ed16c369e0f40e366b2 > compiler: clang version 14.0.0 (/usr/local/google/src/llvm-git-monorepo 2b554920f11c8b763cd9ed9003f4e19b919b8e1f), GNU ld (GNU Binutils for Debian) 2.35.2 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11b31281700000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15e8c4ee700000 > Hm, we have closed the same bug with my patch from -next tree. Let's check if it really fixes the problem... #syz test: https://github.com/google/kmsan.git master With regards, Pavel Skripkin [-- Attachment #2: 0001-net-asix-add-proper-error-handling-of-usb-read-error.patch --] [-- Type: text/x-patch, Size: 5107 bytes --] From 2e250fc010a2883961784261474a8fb26c10b68c Mon Sep 17 00:00:00 2001 From: Pavel Skripkin <paskripkin@gmail.com> Date: Sun, 6 Feb 2022 21:05:16 +0300 Subject: [PATCH] net: asix: add proper error handling of usb read errors Syzbot once again hit uninit value in asix driver. The problem still the same -- asix_read_cmd() reads less bytes, than was requested by caller. Since all read requests are performed via asix_read_cmd() let's catch usb related error there and add __must_check notation to be sure all callers actually check return value. So, this patch adds sanity check inside asix_read_cmd(), that simply checks if bytes read are not less, than was requested and adds missing error handling of asix_read_cmd() all across the driver code. Fixes: d9fe64e51114 ("net: asix: Add in_pm parameter") Reported-and-tested-by: syzbot+6ca9f7867b77c2d316ac@syzkaller.appspotmail.com Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> Tested-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/net/usb/asix.h | 4 ++-- drivers/net/usb/asix_common.c | 19 +++++++++++++------ drivers/net/usb/asix_devices.c | 21 ++++++++++++++++++--- 3 files changed, 33 insertions(+), 11 deletions(-) diff --git a/drivers/net/usb/asix.h b/drivers/net/usb/asix.h index 2a1e31defe71..4334aafab59a 100644 --- a/drivers/net/usb/asix.h +++ b/drivers/net/usb/asix.h @@ -192,8 +192,8 @@ extern const struct driver_info ax88172a_info; /* ASIX specific flags */ #define FLAG_EEPROM_MAC (1UL << 0) /* init device MAC from eeprom */ -int asix_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, - u16 size, void *data, int in_pm); +int __must_check asix_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, + u16 size, void *data, int in_pm); int asix_write_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 size, void *data, int in_pm); diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index 71682970be58..524805285019 100644 --- a/drivers/net/usb/asix_common.c +++ b/drivers/net/usb/asix_common.c @@ -11,8 +11,8 @@ #define AX_HOST_EN_RETRIES 30 -int asix_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, - u16 size, void *data, int in_pm) +int __must_check asix_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, + u16 size, void *data, int in_pm) { int ret; int (*fn)(struct usbnet *, u8, u8, u16, u16, void *, u16); @@ -27,9 +27,12 @@ int asix_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, ret = fn(dev, cmd, USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE, value, index, data, size); - if (unlikely(ret < 0)) + if (unlikely(ret < size)) { + ret = ret < 0 ? ret : -ENODATA; + netdev_warn(dev->net, "Failed to read reg index 0x%04x: %d\n", index, ret); + } return ret; } @@ -79,7 +82,7 @@ static int asix_check_host_enable(struct usbnet *dev, int in_pm) 0, 0, 1, &smsr, in_pm); if (ret == -ENODEV) break; - else if (ret < sizeof(smsr)) + else if (ret < 0) continue; else if (smsr & AX_HOST_EN) break; @@ -579,8 +582,12 @@ int asix_mdio_read_nopm(struct net_device *netdev, int phy_id, int loc) return ret; } - asix_read_cmd(dev, AX_CMD_READ_MII_REG, phy_id, - (__u16)loc, 2, &res, 1); + ret = asix_read_cmd(dev, AX_CMD_READ_MII_REG, phy_id, + (__u16)loc, 2, &res, 1); + if (ret < 0) { + mutex_unlock(&dev->phy_mutex); + return ret; + } asix_set_hw_mii(dev, 1); mutex_unlock(&dev->phy_mutex); diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index 4514d35ef4c4..6b2fbdf4e0fd 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c @@ -755,7 +755,12 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf) priv->phy_addr = ret; priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10); - asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0); + ret = asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0); + if (ret < 0) { + netdev_dbg(dev->net, "Failed to read STATMNGSTS_REG: %d\n", ret); + return ret; + } + chipcode &= AX_CHIPCODE_MASK; ret = (chipcode == AX_AX88772_CHIPCODE) ? ax88772_hw_reset(dev, 0) : @@ -920,11 +925,21 @@ static int ax88178_reset(struct usbnet *dev) int gpio0 = 0; u32 phyid; - asix_read_cmd(dev, AX_CMD_READ_GPIOS, 0, 0, 1, &status, 0); + ret = asix_read_cmd(dev, AX_CMD_READ_GPIOS, 0, 0, 1, &status, 0); + if (ret < 0) { + netdev_dbg(dev->net, "Failed to read GPIOS: %d\n", ret); + return ret; + } + netdev_dbg(dev->net, "GPIO Status: 0x%04x\n", status); asix_write_cmd(dev, AX_CMD_WRITE_ENABLE, 0, 0, 0, NULL, 0); - asix_read_cmd(dev, AX_CMD_READ_EEPROM, 0x0017, 0, 2, &eeprom, 0); + ret = asix_read_cmd(dev, AX_CMD_READ_EEPROM, 0x0017, 0, 2, &eeprom, 0); + if (ret < 0) { + netdev_dbg(dev->net, "Failed to read EEPROM: %d\n", ret); + return ret; + } + asix_write_cmd(dev, AX_CMD_WRITE_DISABLE, 0, 0, 0, NULL, 0); netdev_dbg(dev->net, "EEPROM index 0x17 is 0x%04x\n", eeprom); -- 2.35.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [syzbot] KMSAN: uninit-value in asix_mdio_read (3) 2022-03-13 17:42 ` Pavel Skripkin @ 2022-03-13 17:57 ` syzbot 2022-03-13 17:58 ` Pavel Skripkin 0 siblings, 1 reply; 4+ messages in thread From: syzbot @ 2022-03-13 17:57 UTC (permalink / raw) To: andrew, davem, glider, kuba, linux-kernel, linux-usb, linux, netdev, paskripkin, syzkaller-bugs Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-and-tested-by: syzbot+9ed16c369e0f40e366b2@syzkaller.appspotmail.com Tested on: commit: 72494641 x86: kmsan: enable KMSAN builds for x86 git tree: https://github.com/google/kmsan.git master kernel config: https://syzkaller.appspot.com/x/.config?x=28718f555f258365 dashboard link: https://syzkaller.appspot.com/bug?extid=9ed16c369e0f40e366b2 compiler: clang version 14.0.0 (/usr/local/google/src/llvm-git-monorepo 2b554920f11c8b763cd9ed9003f4e19b919b8e1f), GNU ld (GNU Binutils for Debian) 2.35.2 patch: https://syzkaller.appspot.com/x/patch.diff?x=11ccaa41700000 Note: testing is done by a robot and is best-effort only. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [syzbot] KMSAN: uninit-value in asix_mdio_read (3) 2022-03-13 17:57 ` syzbot @ 2022-03-13 17:58 ` Pavel Skripkin 0 siblings, 0 replies; 4+ messages in thread From: Pavel Skripkin @ 2022-03-13 17:58 UTC (permalink / raw) To: syzbot, andrew, davem, glider, kuba, linux-kernel, linux-usb, linux, netdev, syzkaller-bugs On 3/13/22 20:57, syzbot wrote: > Hello, > > syzbot has tested the proposed patch and the reproducer did not trigger any issue: > > Reported-and-tested-by: syzbot+9ed16c369e0f40e366b2@syzkaller.appspotmail.com > > Tested on: > > commit: 72494641 x86: kmsan: enable KMSAN builds for x86 > git tree: https://github.com/google/kmsan.git master > kernel config: https://syzkaller.appspot.com/x/.config?x=28718f555f258365 > dashboard link: https://syzkaller.appspot.com/bug?extid=9ed16c369e0f40e366b2 > compiler: clang version 14.0.0 (/usr/local/google/src/llvm-git-monorepo 2b554920f11c8b763cd9ed9003f4e19b919b8e1f), GNU ld (GNU Binutils for Debian) 2.35.2 > patch: https://syzkaller.appspot.com/x/patch.diff?x=11ccaa41700000 > > Note: testing is done by a robot and is best-effort only. #syz fix: net: asix: add proper error handling of usb read errors With regards, Pavel Skripkin ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-13 17:58 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-03-13 7:35 [syzbot] KMSAN: uninit-value in asix_mdio_read (3) syzbot 2022-03-13 17:42 ` Pavel Skripkin 2022-03-13 17:57 ` syzbot 2022-03-13 17:58 ` Pavel Skripkin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.