All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: Disable Exynos5250 I2S controllers by default
@ 2013-09-06 18:17 Mark Brown
  2013-09-10 17:35 ` Mark Rutland
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2013-09-06 18:17 UTC (permalink / raw)
  To: Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren, Kukjin Kim
  Cc: linux-samsung-soc, linaro-kernel, Mark Brown

From: Mark Brown <broonie@linaro.org>

Rather than requiring each board to explicitly disable the I2S controllers
it is not using instead require boards to enable those that they are using.

This is required for audio operation on Arndale, one of the unused I2S
controllers is pinmuxed with the LDO enable GPIOs for the WM1811A.

Signed-off-by: Mark Brown <broonie@linaro.org>
---

This seems like a more robust approach to handling the externally
visible IPs - if this is OK I can go through and do further updates for
other devices.

 arch/arm/boot/dts/exynos5250-arndale.dts  | 4 ++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts | 8 --------
 arch/arm/boot/dts/exynos5250.dtsi         | 3 +++
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index cee55fa..4687fa0 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -412,6 +412,10 @@
 		status = "disabled";
 	};
 
+	i2s0: i2s@03830000 {
+		status = "okay";
+	};
+
 	spi_0: spi@12d20000 {
 		status = "disabled";
 	};
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 2538b32..f86d567 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -231,14 +231,6 @@
 		status = "okay";
 	};
 
-	i2s1: i2s@12D60000 {
-		status = "disabled";
-	};
-
-	i2s2: i2s@12D70000 {
-		status = "disabled";
-	};
-
 	sound {
 		compatible = "samsung,smdk-wm8994";
 
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 7d7cc77..c863113 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -417,6 +417,7 @@
 
 	i2s0: i2s@03830000 {
 		compatible = "samsung,s5pv210-i2s";
+		status = "disabled";
 		reg = <0x03830000 0x100>;
 		dmas = <&pdma0 10
 			&pdma0 9
@@ -433,6 +434,7 @@
 
 	i2s1: i2s@12D60000 {
 		compatible = "samsung,s3c6410-i2s";
+		status = "disabled";
 		reg = <0x12D60000 0x100>;
 		dmas = <&pdma1 12
 			&pdma1 11>;
@@ -445,6 +447,7 @@
 
 	i2s2: i2s@12D70000 {
 		compatible = "samsung,s3c6410-i2s";
+		status = "disabled";
 		reg = <0x12D70000 0x100>;
 		dmas = <&pdma0 12
 			&pdma0 11>;
-- 
1.8.4.rc3

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: Disable Exynos5250 I2S controllers by default
  2013-09-06 18:17 [PATCH] ARM: dts: Disable Exynos5250 I2S controllers by default Mark Brown
@ 2013-09-10 17:35 ` Mark Rutland
  2013-09-10 17:41   ` Mark Brown
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Rutland @ 2013-09-10 17:35 UTC (permalink / raw)
  To: Mark Brown
  Cc: rob.herring, Pawel Moll, Stephen Warren, Kukjin Kim,
	linux-samsung-soc, linaro-kernel, Mark Brown

On Fri, Sep 06, 2013 at 07:17:15PM +0100, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> Rather than requiring each board to explicitly disable the I2S controllers
> it is not using instead require boards to enable those that they are using.
> 
> This is required for audio operation on Arndale, one of the unused I2S
> controllers is pinmuxed with the LDO enable GPIOs for the WM1811A.
> 
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> 
> This seems like a more robust approach to handling the externally
> visible IPs - if this is OK I can go through and do further updates for
> other devices.

Acked-by: Mark Rutland <mark.rutland@arm.com>

It seems far more sensible to me to mark devices disabled by default in
shared dtsi files and then okay them as needed in particular dts files.
I'd be happy with more of this.

> 
>  arch/arm/boot/dts/exynos5250-arndale.dts  | 4 ++++
>  arch/arm/boot/dts/exynos5250-smdk5250.dts | 8 --------
>  arch/arm/boot/dts/exynos5250.dtsi         | 3 +++
>  3 files changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
> index cee55fa..4687fa0 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -412,6 +412,10 @@
>  		status = "disabled";
>  	};
>  
> +	i2s0: i2s@03830000 {
> +		status = "okay";
> +	};
> +
>  	spi_0: spi@12d20000 {
>  		status = "disabled";
>  	};
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index 2538b32..f86d567 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -231,14 +231,6 @@
>  		status = "okay";
>  	};
>  
> -	i2s1: i2s@12D60000 {
> -		status = "disabled";
> -	};
> -
> -	i2s2: i2s@12D70000 {
> -		status = "disabled";
> -	};
> -
>  	sound {
>  		compatible = "samsung,smdk-wm8994";
>  
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 7d7cc77..c863113 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -417,6 +417,7 @@
>  
>  	i2s0: i2s@03830000 {
>  		compatible = "samsung,s5pv210-i2s";
> +		status = "disabled";
>  		reg = <0x03830000 0x100>;
>  		dmas = <&pdma0 10
>  			&pdma0 9
> @@ -433,6 +434,7 @@
>  
>  	i2s1: i2s@12D60000 {
>  		compatible = "samsung,s3c6410-i2s";
> +		status = "disabled";
>  		reg = <0x12D60000 0x100>;
>  		dmas = <&pdma1 12
>  			&pdma1 11>;
> @@ -445,6 +447,7 @@
>  
>  	i2s2: i2s@12D70000 {
>  		compatible = "samsung,s3c6410-i2s";
> +		status = "disabled";
>  		reg = <0x12D70000 0x100>;
>  		dmas = <&pdma0 12
>  			&pdma0 11>;
> -- 
> 1.8.4.rc3
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: Disable Exynos5250 I2S controllers by default
  2013-09-10 17:35 ` Mark Rutland
@ 2013-09-10 17:41   ` Mark Brown
  2013-09-12 10:42     ` Kukjin Kim
  0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2013-09-10 17:41 UTC (permalink / raw)
  To: Mark Rutland
  Cc: rob.herring, Pawel Moll, Stephen Warren, Kukjin Kim,
	linux-samsung-soc, linaro-kernel

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

On Tue, Sep 10, 2013 at 06:35:48PM +0100, Mark Rutland wrote:

> It seems far more sensible to me to mark devices disabled by default in
> shared dtsi files and then okay them as needed in particular dts files.
> I'd be happy with more of this.

Yeah, me too - though only for devices that have an external impact, for
things that are internal only (eg, a crypto engine) it makes sense to
enable them by default since they should normally be usable regardless
of the system configuration.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [PATCH] ARM: dts: Disable Exynos5250 I2S controllers by default
  2013-09-10 17:41   ` Mark Brown
@ 2013-09-12 10:42     ` Kukjin Kim
  2013-09-12 11:15       ` Tomasz Figa
  0 siblings, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2013-09-12 10:42 UTC (permalink / raw)
  To: 'Mark Brown', 'Mark Rutland'
  Cc: rob.herring, 'Pawel Moll', 'Stephen Warren',
	linux-samsung-soc, linaro-kernel, 'devicetree'

Mark Brown wrote:
> 
> On Tue, Sep 10, 2013 at 06:35:48PM +0100, Mark Rutland wrote:
> 
> > It seems far more sensible to me to mark devices disabled by default in
> > shared dtsi files and then okay them as needed in particular dts files.
> > I'd be happy with more of this.
> 
> Yeah, me too - though only for devices that have an external impact, for
> things that are internal only (eg, a crypto engine) it makes sense to
> enable them by default since they should normally be usable regardless
> of the system configuration.

(+ DT ML)

Makes sense but I need to get the opinions from DT guys...

- Kukjin

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: Disable Exynos5250 I2S controllers by default
  2013-09-12 10:42     ` Kukjin Kim
@ 2013-09-12 11:15       ` Tomasz Figa
  0 siblings, 0 replies; 5+ messages in thread
From: Tomasz Figa @ 2013-09-12 11:15 UTC (permalink / raw)
  To: Kukjin Kim
  Cc: 'Mark Brown', 'Mark Rutland',
	rob.herring, 'Pawel Moll', 'Stephen Warren',
	linux-samsung-soc, linaro-kernel, 'devicetree'

Hi Kukjin,

On Thursday 12 of September 2013 19:42:57 Kukjin Kim wrote:
> Mark Brown wrote:
> > On Tue, Sep 10, 2013 at 06:35:48PM +0100, Mark Rutland wrote:
> > > It seems far more sensible to me to mark devices disabled by default
> > > in
> > > shared dtsi files and then okay them as needed in particular dts
> > > files.
> > > I'd be happy with more of this.
> > 
> > Yeah, me too - though only for devices that have an external impact,
> > for
> > things that are internal only (eg, a crypto engine) it makes sense to
> > enable them by default since they should normally be usable regardless
> > of the system configuration.
> 
> (+ DT ML)
> 
> Makes sense but I need to get the opinions from DT guys...

Yes, this patch should have been posted to the DT ML indeed, but it has 
been already acked by Mark Rutland, one of DT binding maintainers.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-12 11:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-06 18:17 [PATCH] ARM: dts: Disable Exynos5250 I2S controllers by default Mark Brown
2013-09-10 17:35 ` Mark Rutland
2013-09-10 17:41   ` Mark Brown
2013-09-12 10:42     ` Kukjin Kim
2013-09-12 11:15       ` Tomasz Figa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.