[PATCH] drm/amd/display: remove duplicated comparison expression

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-09 15:49 ` Colin King
  0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2019-11-09 15:49 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
	David Zhou, David Airlie, Daniel Vetter, Charlene Liu,
	Dmytro Laktyushkin, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

There is comparison expression that is duplicated and hence one
of the expressions can be removed.  Remove it.

Addresses-Coverity: ("Same on both sides")
Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 1fdba13b3d0f..1fa255e077d0 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
 	}
 
 	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
-			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
 			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
 		update_flags->bits.plane_size_change = 1;
 		elevate_update_type(&update_type, UPDATE_TYPE_MED);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-09 15:49 ` Colin King
  0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2019-11-09 15:49 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
	David Zhou, David Airlie, Daniel Vetter, Charlene Liu,
	Dmytro Laktyushkin, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

There is comparison expression that is duplicated and hence one
of the expressions can be removed.  Remove it.

Addresses-Coverity: ("Same on both sides")
Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 1fdba13b3d0f..1fa255e077d0 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
 	}
 
 	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
-			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
 			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
 		update_flags->bits.plane_size_change = 1;
 		elevate_update_type(&update_type, UPDATE_TYPE_MED);
-- 
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-09 15:49 ` Colin King
  0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2019-11-09 15:49 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
	David Zhou, David Airlie, Daniel Vetter, Charlene Liu,
	Dmytro Laktyushkin, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

There is comparison expression that is duplicated and hence one
of the expressions can be removed.  Remove it.

Addresses-Coverity: ("Same on both sides")
Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 1fdba13b3d0f..1fa255e077d0 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
 	}
 
 	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
-			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
 			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
 		update_flags->bits.plane_size_change = 1;
 		elevate_update_type(&update_type, UPDATE_TYPE_MED);
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-09 15:49 ` Colin King
  0 siblings, 0 replies; 12+ messages in thread
From: Colin King @ 2019-11-09 15:49 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Alex Deucher, Christian König,
	David Zhou, David Airlie, Daniel Vetter, Charlene Liu,
	Dmytro Laktyushkin, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

There is comparison expression that is duplicated and hence one
of the expressions can be removed.  Remove it.

Addresses-Coverity: ("Same on both sides")
Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 1fdba13b3d0f..1fa255e077d0 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
 	}
 
 	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
-			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
 			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
 		update_flags->bits.plane_size_change = 1;
 		elevate_update_type(&update_type, UPDATE_TYPE_MED);
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH] drm/amd/display: remove duplicated comparison expression
  2019-11-09 15:49 ` Colin King
  (?)
  (?)
@ 2019-11-11 13:37   ` Kazlauskas, Nicholas
  -1 siblings, 0 replies; 12+ messages in thread
From: Kazlauskas, Nicholas @ 2019-11-11 13:37 UTC (permalink / raw)
  To: Colin King, Harry Wentland, Leo Li, Alex Deucher,
	Christian König, David Zhou, David Airlie, Daniel Vetter,
	Charlene Liu, Dmytro Laktyushkin, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

On 2019-11-09 10:49 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There is comparison expression that is duplicated and hence one
> of the expressions can be removed.  Remove it.
> 
> Addresses-Coverity: ("Same on both sides")
> Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Thanks!

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 1fdba13b3d0f..1fa255e077d0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
>   	}
>   
>   	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> -			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
>   			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
>   		update_flags->bits.plane_size_change = 1;
>   		elevate_update_type(&update_type, UPDATE_TYPE_MED);
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-11 13:37   ` Kazlauskas, Nicholas
  0 siblings, 0 replies; 12+ messages in thread
From: Kazlauskas, Nicholas @ 2019-11-11 13:37 UTC (permalink / raw)
  To: Colin King, Harry Wentland, Leo Li, Alex Deucher,
	Christian König, David Zhou, David Airlie, Daniel Vetter,
	Charlene Liu, Dmytro Laktyushkin, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

On 2019-11-09 10:49 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There is comparison expression that is duplicated and hence one
> of the expressions can be removed.  Remove it.
> 
> Addresses-Coverity: ("Same on both sides")
> Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Thanks!

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 1fdba13b3d0f..1fa255e077d0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
>   	}
>   
>   	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> -			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
>   			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
>   		update_flags->bits.plane_size_change = 1;
>   		elevate_update_type(&update_type, UPDATE_TYPE_MED);
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-11 13:37   ` Kazlauskas, Nicholas
  0 siblings, 0 replies; 12+ messages in thread
From: Kazlauskas, Nicholas @ 2019-11-11 13:37 UTC (permalink / raw)
  To: Colin King, Harry Wentland, Leo Li, Alex Deucher,
	Christian König, David Zhou, David Airlie, Daniel Vetter,
	Charlene Liu, Dmytro Laktyushkin, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

On 2019-11-09 10:49 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There is comparison expression that is duplicated and hence one
> of the expressions can be removed.  Remove it.
> 
> Addresses-Coverity: ("Same on both sides")
> Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Thanks!

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 1fdba13b3d0f..1fa255e077d0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
>   	}
>   
>   	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> -			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
>   			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
>   		update_flags->bits.plane_size_change = 1;
>   		elevate_update_type(&update_type, UPDATE_TYPE_MED);
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-11 13:37   ` Kazlauskas, Nicholas
  0 siblings, 0 replies; 12+ messages in thread
From: Kazlauskas, Nicholas @ 2019-11-11 13:37 UTC (permalink / raw)
  To: Colin King, Harry Wentland, Leo Li, Alex Deucher,
	Christian König, David Zhou, David Airlie, Daniel Vetter,
	Charlene Liu, Dmytro Laktyushkin, amd-gfx, dri-devel
  Cc: kernel-janitors, linux-kernel

On 2019-11-09 10:49 a.m., Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There is comparison expression that is duplicated and hence one
> of the expressions can be removed.  Remove it.
> 
> Addresses-Coverity: ("Same on both sides")
> Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>

Thanks!

Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 1fdba13b3d0f..1fa255e077d0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
>   	}
>   
>   	if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> -			|| u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
>   			|| u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
>   		update_flags->bits.plane_size_change = 1;
>   		elevate_update_type(&update_type, UPDATE_TYPE_MED);
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] drm/amd/display: remove duplicated comparison expression
  2019-11-11 13:37   ` Kazlauskas, Nicholas
  (?)
  (?)
@ 2019-11-11 17:35     ` Alex Deucher
  -1 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2019-11-11 17:35 UTC (permalink / raw)
  To: Kazlauskas, Nicholas
  Cc: Colin King, Harry Wentland, Leo Li, Alex Deucher,
	Christian König, David Zhou, David Airlie, Daniel Vetter,
	Charlene Liu, Dmytro Laktyushkin, amd-gfx list,
	Maling list - DRI developers, kernel-janitors, LKML

Applied.  Thanks!

Alex

On Mon, Nov 11, 2019 at 8:38 AM Kazlauskas, Nicholas
<nicholas.kazlauskas@amd.com> wrote:
>
> On 2019-11-09 10:49 a.m., Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is comparison expression that is duplicated and hence one
> > of the expressions can be removed.  Remove it.
> >
> > Addresses-Coverity: ("Same on both sides")
> > Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> Thanks!
>
> Nicholas Kazlauskas
>
> > ---
> >   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > index 1fdba13b3d0f..1fa255e077d0 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
> >       }
> >
> >       if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> > -                     || u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> >                       || u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
> >               update_flags->bits.plane_size_change = 1;
> >               elevate_update_type(&update_type, UPDATE_TYPE_MED);
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-11 17:35     ` Alex Deucher
  0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2019-11-11 17:35 UTC (permalink / raw)
  To: Kazlauskas, Nicholas
  Cc: David Zhou, Charlene Liu, Leo Li, kernel-janitors, LKML,
	amd-gfx list, David Airlie, Dmytro Laktyushkin,
	Maling list - DRI developers, Daniel Vetter, Alex Deucher,
	Colin King, Harry Wentland, Christian König

Applied.  Thanks!

Alex

On Mon, Nov 11, 2019 at 8:38 AM Kazlauskas, Nicholas
<nicholas.kazlauskas@amd.com> wrote:
>
> On 2019-11-09 10:49 a.m., Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is comparison expression that is duplicated and hence one
> > of the expressions can be removed.  Remove it.
> >
> > Addresses-Coverity: ("Same on both sides")
> > Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> Thanks!
>
> Nicholas Kazlauskas
>
> > ---
> >   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > index 1fdba13b3d0f..1fa255e077d0 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
> >       }
> >
> >       if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> > -                     || u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> >                       || u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
> >               update_flags->bits.plane_size_change = 1;
> >               elevate_update_type(&update_type, UPDATE_TYPE_MED);
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-11 17:35     ` Alex Deucher
  0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2019-11-11 17:35 UTC (permalink / raw)
  To: Kazlauskas, Nicholas
  Cc: Charlene Liu, Leo Li, kernel-janitors, LKML, amd-gfx list,
	David Airlie, Dmytro Laktyushkin, Maling list - DRI developers,
	Alex Deucher, Colin King, Christian König

Applied.  Thanks!

Alex

On Mon, Nov 11, 2019 at 8:38 AM Kazlauskas, Nicholas
<nicholas.kazlauskas@amd.com> wrote:
>
> On 2019-11-09 10:49 a.m., Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is comparison expression that is duplicated and hence one
> > of the expressions can be removed.  Remove it.
> >
> > Addresses-Coverity: ("Same on both sides")
> > Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> Thanks!
>
> Nicholas Kazlauskas
>
> > ---
> >   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > index 1fdba13b3d0f..1fa255e077d0 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
> >       }
> >
> >       if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> > -                     || u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> >                       || u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
> >               update_flags->bits.plane_size_change = 1;
> >               elevate_update_type(&update_type, UPDATE_TYPE_MED);
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] drm/amd/display: remove duplicated comparison expression
@ 2019-11-11 17:35     ` Alex Deucher
  0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2019-11-11 17:35 UTC (permalink / raw)
  To: Kazlauskas, Nicholas
  Cc: Colin King, Harry Wentland, Leo Li, Alex Deucher,
	Christian König, David Zhou, David Airlie, Daniel Vetter,
	Charlene Liu, Dmytro Laktyushkin, amd-gfx list,
	Maling list - DRI developers, kernel-janitors, LKML

Applied.  Thanks!

Alex

On Mon, Nov 11, 2019 at 8:38 AM Kazlauskas, Nicholas
<nicholas.kazlauskas@amd.com> wrote:
>
> On 2019-11-09 10:49 a.m., Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > There is comparison expression that is duplicated and hence one
> > of the expressions can be removed.  Remove it.
> >
> > Addresses-Coverity: ("Same on both sides")
> > Fixes: 12e2b2d4c65f ("drm/amd/display: add dcc programming for dual plane")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
> Thanks!
>
> Nicholas Kazlauskas
>
> > ---
> >   drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > index 1fdba13b3d0f..1fa255e077d0 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > @@ -1491,7 +1491,6 @@ static enum surface_update_type get_plane_info_update_type(const struct dc_surfa
> >       }
> >
> >       if (u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> > -                     || u->plane_info->plane_size.surface_pitch != u->surface->plane_size.surface_pitch
> >                       || u->plane_info->plane_size.chroma_pitch != u->surface->plane_size.chroma_pitch) {
> >               update_flags->bits.plane_size_change = 1;
> >               elevate_update_type(&update_type, UPDATE_TYPE_MED);
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-11-11 17:35 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-09 15:49 [PATCH] drm/amd/display: remove duplicated comparison expression Colin King
2019-11-09 15:49 ` Colin King
2019-11-09 15:49 ` Colin King
2019-11-09 15:49 ` Colin King
2019-11-11 13:37 ` Kazlauskas, Nicholas
2019-11-11 13:37   ` Kazlauskas, Nicholas
2019-11-11 13:37   ` Kazlauskas, Nicholas
2019-11-11 13:37   ` Kazlauskas, Nicholas
2019-11-11 17:35   ` Alex Deucher
2019-11-11 17:35     ` Alex Deucher
2019-11-11 17:35     ` Alex Deucher
2019-11-11 17:35     ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.