All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni at redhat.com>
To: mptcp at lists.01.org
Subject: [MPTCP] [PATCH net v2 5/5] mptcp: initialize the data_fin field for mpc packets
Date: Thu, 30 Apr 2020 15:01:55 +0200	[thread overview]
Message-ID: <0701d07b1b9b94052fbb8f32b870a037e0f7d3ac.1588243786.git.pabeni@redhat.com> (raw)
In-Reply-To: cover.1588243786.git.pabeni@redhat.com

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

When parsing MPC+data packets we set the dss field, so
we must also initialize the data_fin, or we can find stray
value there.

Fixes: 9a19371bf029 ("mptcp: fix data_fin handing in RX path")
Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
---
 net/mptcp/options.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index 9486720c3256..45497af23906 100644
--- a/net/mptcp/options.c
+++ b/net/mptcp/options.c
@@ -858,6 +858,7 @@ void mptcp_incoming_options(struct sock *sk, struct sk_buff *skb,
 			mpext->subflow_seq = 1;
 			mpext->dsn64 = 1;
 			mpext->mpc_map = 1;
+			mpext->data_fin = 0;
 		} else {
 			mpext->data_seq = mp_opt.data_seq;
 			mpext->subflow_seq = mp_opt.subflow_seq;
-- 
2.21.1

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
	Mat Martineau <mathew.j.martineau@linux.intel.com>,
	Matthieu Baerts <matthieu.baerts@tessares.net>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Christoph Paasch <cpaasch@apple.com>,
	mptcp@lists.01.org
Subject: [PATCH net v2 5/5] mptcp: initialize the data_fin field for mpc packets
Date: Thu, 30 Apr 2020 15:01:55 +0200	[thread overview]
Message-ID: <0701d07b1b9b94052fbb8f32b870a037e0f7d3ac.1588243786.git.pabeni@redhat.com> (raw)
In-Reply-To: <cover.1588243786.git.pabeni@redhat.com>

When parsing MPC+data packets we set the dss field, so
we must also initialize the data_fin, or we can find stray
value there.

Fixes: 9a19371bf029 ("mptcp: fix data_fin handing in RX path")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
 net/mptcp/options.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index 9486720c3256..45497af23906 100644
--- a/net/mptcp/options.c
+++ b/net/mptcp/options.c
@@ -858,6 +858,7 @@ void mptcp_incoming_options(struct sock *sk, struct sk_buff *skb,
 			mpext->subflow_seq = 1;
 			mpext->dsn64 = 1;
 			mpext->mpc_map = 1;
+			mpext->data_fin = 0;
 		} else {
 			mpext->data_seq = mp_opt.data_seq;
 			mpext->subflow_seq = mp_opt.subflow_seq;
-- 
2.21.1


             reply	other threads:[~2020-04-30 13:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30 13:01 Paolo Abeni [this message]
2020-04-30 13:01 ` [PATCH net v2 5/5] mptcp: initialize the data_fin field for mpc packets Paolo Abeni
  -- strict thread matches above, loose matches on Subject: below --
2020-04-30 19:23 [MPTCP] Re: [PATCH net v2 0/5] mptcp: fix incoming options parsing David Miller
2020-04-30 19:23 ` David Miller
2020-04-30 13:01 [MPTCP] [PATCH net v2 4/5] mptcp: fix 'use_ack' option access Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni
2020-04-30 13:01 [MPTCP] [PATCH net v2 3/5] mptcp: avoid a WARN on bad input Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni
2020-04-30 13:01 [MPTCP] [PATCH net v2 2/5] mptcp: move option parsing into mptcp_incoming_options() Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni
2020-04-30 13:01 [MPTCP] [PATCH net v2 1/5] mptcp: consolidate synack processing Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni
2020-04-30 13:01 [MPTCP] [PATCH net v2 0/5] mptcp: fix incoming options parsing Paolo Abeni
2020-04-30 13:01 ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0701d07b1b9b94052fbb8f32b870a037e0f7d3ac.1588243786.git.pabeni@redhat.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.