All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shane Francis <bigbeeshane@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	heiko@sntech.de, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: clock: update rk3588 clock definitions
Date: Sun, 26 Mar 2023 22:04:08 +0200	[thread overview]
Message-ID: <0711b320-6c36-6564-70d2-35fc76ac1ebc@linaro.org> (raw)
In-Reply-To: <20230326184040.33008-2-bigbeeshane@gmail.com>

On 26/03/2023 20:40, Shane Francis wrote:
> Some vendor uboot bootloaders use the target kernels DTB image to
> determine the target clock speeds for some PLLs, currently this can cause
> uboot to set the clock rate for gpll incorrectly on to cpll (breaking)
> RGMII.

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.

> 
> This change starts the PLL clock definitions from 1 to correct this
> miss-match
> 
> This could be handled by uboot bu updating mappings in that code base
> however not all devices will have a replaceable uboot (in cases such as
> when a secure boot chain is implemented)
> 
> Signed-off-by: Shane Francis <bigbeeshane@gmail.com>
> ---
>  .../dt-bindings/clock/rockchip,rk3588-cru.h   | 1442 ++++++++---------
>  1 file changed, 721 insertions(+), 721 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index b5616bca7b44..d63b07d054b7 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h

We did not finish discussion yet, so sending new version 50 minutes
after your last reply does not give me chance to respond.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shane Francis <bigbeeshane@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	heiko@sntech.de, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: clock: update rk3588 clock definitions
Date: Sun, 26 Mar 2023 22:04:08 +0200	[thread overview]
Message-ID: <0711b320-6c36-6564-70d2-35fc76ac1ebc@linaro.org> (raw)
In-Reply-To: <20230326184040.33008-2-bigbeeshane@gmail.com>

On 26/03/2023 20:40, Shane Francis wrote:
> Some vendor uboot bootloaders use the target kernels DTB image to
> determine the target clock speeds for some PLLs, currently this can cause
> uboot to set the clock rate for gpll incorrectly on to cpll (breaking)
> RGMII.

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.

> 
> This change starts the PLL clock definitions from 1 to correct this
> miss-match
> 
> This could be handled by uboot bu updating mappings in that code base
> however not all devices will have a replaceable uboot (in cases such as
> when a secure boot chain is implemented)
> 
> Signed-off-by: Shane Francis <bigbeeshane@gmail.com>
> ---
>  .../dt-bindings/clock/rockchip,rk3588-cru.h   | 1442 ++++++++---------
>  1 file changed, 721 insertions(+), 721 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index b5616bca7b44..d63b07d054b7 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h

We did not finish discussion yet, so sending new version 50 minutes
after your last reply does not give me chance to respond.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shane Francis <bigbeeshane@gmail.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	heiko@sntech.de, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: clock: update rk3588 clock definitions
Date: Sun, 26 Mar 2023 22:04:08 +0200	[thread overview]
Message-ID: <0711b320-6c36-6564-70d2-35fc76ac1ebc@linaro.org> (raw)
In-Reply-To: <20230326184040.33008-2-bigbeeshane@gmail.com>

On 26/03/2023 20:40, Shane Francis wrote:
> Some vendor uboot bootloaders use the target kernels DTB image to
> determine the target clock speeds for some PLLs, currently this can cause
> uboot to set the clock rate for gpll incorrectly on to cpll (breaking)
> RGMII.

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.

> 
> This change starts the PLL clock definitions from 1 to correct this
> miss-match
> 
> This could be handled by uboot bu updating mappings in that code base
> however not all devices will have a replaceable uboot (in cases such as
> when a secure boot chain is implemented)
> 
> Signed-off-by: Shane Francis <bigbeeshane@gmail.com>
> ---
>  .../dt-bindings/clock/rockchip,rk3588-cru.h   | 1442 ++++++++---------
>  1 file changed, 721 insertions(+), 721 deletions(-)
> 
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index b5616bca7b44..d63b07d054b7 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h

We did not finish discussion yet, so sending new version 50 minutes
after your last reply does not give me chance to respond.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-26 20:04 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-26  0:15 [PATCH 1/2] arm64: dts: Add basic NanoPi R6S (RK3588S) Support Shane Francis
2023-03-26  0:15 ` Shane Francis
2023-03-26  0:15 ` Shane Francis
2023-03-26  0:15 ` [PATCH 2/2] dt-bindings: clock: update rk3588 clock definitions Shane Francis
2023-03-26  0:15   ` Shane Francis
2023-03-26  0:15   ` Shane Francis
2023-03-26  0:53   ` Heiko Stübner
2023-03-26  0:53     ` Heiko Stübner
2023-03-26  0:53     ` Heiko Stübner
2023-03-26 12:30     ` Shane Francis
2023-03-26 12:30       ` Shane Francis
2023-03-26 12:30       ` Shane Francis
2023-03-26 12:50       ` Peter Geis
2023-03-26 12:50         ` Peter Geis
2023-03-26 12:50         ` Peter Geis
2023-03-26  9:37   ` Krzysztof Kozlowski
2023-03-26  9:37     ` Krzysztof Kozlowski
2023-03-26  9:37     ` Krzysztof Kozlowski
2023-03-26 12:15     ` Shane Francis
2023-03-26 12:15       ` Shane Francis
2023-03-26 12:15       ` Shane Francis
     [not found]     ` <CABnpCuCzdbWTTp1Gc6wWPsB80J5GYw1QzKtZzzyEYU456E=1JA@mail.gmail.com>
2023-03-26 14:51       ` Krzysztof Kozlowski
2023-03-26 14:51         ` Krzysztof Kozlowski
2023-03-26 14:51         ` Krzysztof Kozlowski
2023-03-26 16:57         ` Shane Francis
2023-03-26 16:57           ` Shane Francis
2023-03-26 16:57           ` Shane Francis
2023-03-26 16:59         ` Shane Francis
2023-03-26 16:59           ` Shane Francis
2023-03-26 16:59           ` Shane Francis
2023-03-26 17:23           ` Krzysztof Kozlowski
2023-03-26 17:23             ` Krzysztof Kozlowski
2023-03-26 17:23             ` Krzysztof Kozlowski
2023-03-26 17:51             ` Shane Francis
2023-03-26 17:51               ` Shane Francis
2023-03-26 17:51               ` Shane Francis
2023-03-26 20:02               ` Krzysztof Kozlowski
2023-03-26 20:02                 ` Krzysztof Kozlowski
2023-03-26 20:02                 ` Krzysztof Kozlowski
2023-03-26 21:42                 ` Mark Kettenis
2023-03-26 21:42                   ` Mark Kettenis
2023-03-26 21:42                   ` Mark Kettenis
2023-03-26 23:40                   ` Shane Francis
2023-03-26 23:40                     ` Shane Francis
2023-03-26 23:40                     ` Shane Francis
2023-03-27  9:07                     ` Heiko Stübner
2023-03-27  9:07                       ` Heiko Stübner
2023-03-27  9:07                       ` Heiko Stübner
2023-03-27  9:22                       ` Shane Francis
2023-03-27  9:22                         ` Shane Francis
2023-03-27  9:22                         ` Shane Francis
2023-03-26  9:38 ` [PATCH 1/2] arm64: dts: Add basic NanoPi R6S (RK3588S) Support Krzysztof Kozlowski
2023-03-26  9:38   ` Krzysztof Kozlowski
2023-03-26  9:38   ` Krzysztof Kozlowski
2023-03-26 12:31   ` Shane Francis
2023-03-26 12:31     ` Shane Francis
2023-03-26 12:31     ` Shane Francis
2023-03-26 18:40 ` [PATCH v2 1/3] " Shane Francis
2023-03-26 18:40   ` Shane Francis
2023-03-26 18:40   ` Shane Francis
2023-03-26 18:40   ` [PATCH v2 2/3] dt-bindings: clock: update rk3588 clock definitions Shane Francis
2023-03-26 18:40     ` Shane Francis
2023-03-26 18:40     ` Shane Francis
2023-03-26 20:04     ` Krzysztof Kozlowski [this message]
2023-03-26 20:04       ` Krzysztof Kozlowski
2023-03-26 20:04       ` Krzysztof Kozlowski
2023-03-26 23:31       ` Shane Francis
2023-03-26 23:31         ` Shane Francis
2023-03-26 23:31         ` Shane Francis
2023-03-26 18:40   ` [PATCH v2 3/3] arm64: dts: Add FriendlyElec NanoPi R6S device binding Shane Francis
2023-03-26 18:40     ` Shane Francis
2023-03-26 18:40     ` Shane Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0711b320-6c36-6564-70d2-35fc76ac1ebc@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=bigbeeshane@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.