[PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[John Crispin]

When the clk code for mt2701 was merged, we forgot to add the reset
controller of the ethernet subsystem. This series adds the missing code
and header files required to reference the bits from within a devicetree
file.

John Crispin (2):
  clk: mediatek: add mt2701 ethernet reset
  reset: mediatek: Add MT2701 ethsys reset controller include file

 drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
 include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
 2 files changed, 9 insertions(+)

-- 
1.7.10.4

[PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[John Crispin]

When the clk code for mt2701 was merged, we forgot to add the reset
controller of the ethernet subsystem. This series adds the missing code
and header files required to reference the bits from within a devicetree
file.

John Crispin (2):
  clk: mediatek: add mt2701 ethernet reset
  reset: mediatek: Add MT2701 ethsys reset controller include file

 drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
 include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
 2 files changed, 9 insertions(+)

-- 
1.7.10.4

[PATCH 1/2] clk: mediatek: add mt2701 ethernet reset

[John Crispin]

The ethernet clock core has a reset register that is currently not exposed
to the user. Fix this by adding the missing registration code.

Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/clk/mediatek/clk-mt2701-eth.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/mediatek/clk-mt2701-eth.c b/drivers/clk/mediatek/clk-mt2701-eth.c
index 877be87..9251a65 100644
--- a/drivers/clk/mediatek/clk-mt2701-eth.c
+++ b/drivers/clk/mediatek/clk-mt2701-eth.c
@@ -66,6 +66,8 @@ static int clk_mt2701_eth_probe(struct platform_device *pdev)
 			"could not register clock provider: %s: %d\n",
 			pdev->name, r);
 
+	mtk_register_reset_controller(node, 1, 0x34);
+
 	return r;
 }
 
-- 
1.7.10.4

[PATCH 1/2] clk: mediatek: add mt2701 ethernet reset

[John Crispin]

The ethernet clock core has a reset register that is currently not exposed
to the user. Fix this by adding the missing registration code.

Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/clk/mediatek/clk-mt2701-eth.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/mediatek/clk-mt2701-eth.c b/drivers/clk/mediatek/clk-mt2701-eth.c
index 877be87..9251a65 100644
--- a/drivers/clk/mediatek/clk-mt2701-eth.c
+++ b/drivers/clk/mediatek/clk-mt2701-eth.c
@@ -66,6 +66,8 @@ static int clk_mt2701_eth_probe(struct platform_device *pdev)
 			"could not register clock provider: %s: %d\n",
 			pdev->name, r);
 
+	mtk_register_reset_controller(node, 1, 0x34);
+
 	return r;
 }
 
-- 
1.7.10.4

Re: [PATCH 1/2] clk: mediatek: add mt2701 ethernet reset

[Stephen Boyd]

On 01/23, John Crispin wrote:
> The ethernet clock core has a reset register that is currently not exposed
> to the user. Fix this by adding the missing registration code.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 1/2] clk: mediatek: add mt2701 ethernet reset

[Stephen Boyd]

On 01/23, John Crispin wrote:
> The ethernet clock core has a reset register that is currently not exposed
> to the user. Fix this by adding the missing registration code.
> 
> Signed-off-by: John Crispin <john@phrozen.org>
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 2/2] reset: mediatek: Add MT2701 ethsys reset controller include file

[John Crispin]

Add the missing reset bits of the ethsys core to the mt2701-reset include
file, so that we can reference them from within a devicetree file.

Signed-off-by: John Crispin <john@phrozen.org>
---
 include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/dt-bindings/reset/mt2701-resets.h b/include/dt-bindings/reset/mt2701-resets.h
index aaf0305..21deb54 100644
--- a/include/dt-bindings/reset/mt2701-resets.h
+++ b/include/dt-bindings/reset/mt2701-resets.h
@@ -80,4 +80,11 @@
 #define MT2701_HIFSYS_PCIE1_RST			25
 #define MT2701_HIFSYS_PCIE2_RST			26
 
+/* ETHSYS resets */
+#define MT2701_ETHSYS_SYS_RST			0
+#define MT2701_ETHSYS_MCM_RST			2
+#define MT2701_ETHSYS_FE_RST			6
+#define MT2701_ETHSYS_GMAC_RST			23
+#define MT2701_ETHSYS_PPE_RST			31
+
 #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT2701 */
-- 
1.7.10.4

[PATCH 2/2] reset: mediatek: Add MT2701 ethsys reset controller include file

[John Crispin]

Add the missing reset bits of the ethsys core to the mt2701-reset include
file, so that we can reference them from within a devicetree file.

Signed-off-by: John Crispin <john@phrozen.org>
---
 include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/include/dt-bindings/reset/mt2701-resets.h b/include/dt-bindings/reset/mt2701-resets.h
index aaf0305..21deb54 100644
--- a/include/dt-bindings/reset/mt2701-resets.h
+++ b/include/dt-bindings/reset/mt2701-resets.h
@@ -80,4 +80,11 @@
 #define MT2701_HIFSYS_PCIE1_RST			25
 #define MT2701_HIFSYS_PCIE2_RST			26
 
+/* ETHSYS resets */
+#define MT2701_ETHSYS_SYS_RST			0
+#define MT2701_ETHSYS_MCM_RST			2
+#define MT2701_ETHSYS_FE_RST			6
+#define MT2701_ETHSYS_GMAC_RST			23
+#define MT2701_ETHSYS_PPE_RST			31
+
 #endif  /* _DT_BINDINGS_RESET_CONTROLLER_MT2701 */
-- 
1.7.10.4

Re: [PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[Stephen Boyd]

On 01/23, John Crispin wrote:
> When the clk code for mt2701 was merged, we forgot to add the reset
> controller of the ethernet subsystem. This series adds the missing code
> and header files required to reference the bits from within a devicetree
> file.
> 
> John Crispin (2):
>   clk: mediatek: add mt2701 ethernet reset
>   reset: mediatek: Add MT2701 ethsys reset controller include file
> 
>  drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
>  include/dt-bindings/reset/mt2701-resets.h |    7 +++++++

Any planned DT users in the next merge window? Should I put this
into a topic branch? Do you want a clk maintainer ack? At the
least we need someone like James to ack this first.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[Stephen Boyd]

On 01/23, John Crispin wrote:
> When the clk code for mt2701 was merged, we forgot to add the reset
> controller of the ethernet subsystem. This series adds the missing code
> and header files required to reference the bits from within a devicetree
> file.
> 
> John Crispin (2):
>   clk: mediatek: add mt2701 ethernet reset
>   reset: mediatek: Add MT2701 ethsys reset controller include file
> 
>  drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
>  include/dt-bindings/reset/mt2701-resets.h |    7 +++++++

Any planned DT users in the next merge window? Should I put this
into a topic branch? Do you want a clk maintainer ack? At the
least we need someone like James to ack this first.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[Stephen Boyd]

On 01/23, John Crispin wrote:
> When the clk code for mt2701 was merged, we forgot to add the reset
> controller of the ethernet subsystem. This series adds the missing code
> and header files required to reference the bits from within a devicetree
> file.
> 
> John Crispin (2):
>   clk: mediatek: add mt2701 ethernet reset
>   reset: mediatek: Add MT2701 ethsys reset controller include file
> 
>  drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
>  include/dt-bindings/reset/mt2701-resets.h |    7 +++++++

Any planned DT users in the next merge window? Should I put this
into a topic branch? Do you want a clk maintainer ack? At the
least we need someone like James to ack this first.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[John Crispin]

On 27/01/2017 01:14, Stephen Boyd wrote:
> On 01/23, John Crispin wrote:
>> When the clk code for mt2701 was merged, we forgot to add the reset
>> controller of the ethernet subsystem. This series adds the missing code
>> and header files required to reference the bits from within a devicetree
>> file.
>>
>> John Crispin (2):
>>   clk: mediatek: add mt2701 ethernet reset
>>   reset: mediatek: Add MT2701 ethsys reset controller include file
>>
>>  drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
>>  include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
> 
> Any planned DT users in the next merge window? Should I put this
> into a topic branch? Do you want a clk maintainer ack? At the
> least we need someone like James to ack this first.
> 

Hi Stephen,

the addition of the dtsi snippets for the ethernet core is pending due
to this patch. getting it into v4.11 would be geat so that i can sent
dtsi changes during the next merge window.

	John

[PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[John Crispin]

On 27/01/2017 01:14, Stephen Boyd wrote:
> On 01/23, John Crispin wrote:
>> When the clk code for mt2701 was merged, we forgot to add the reset
>> controller of the ethernet subsystem. This series adds the missing code
>> and header files required to reference the bits from within a devicetree
>> file.
>>
>> John Crispin (2):
>>   clk: mediatek: add mt2701 ethernet reset
>>   reset: mediatek: Add MT2701 ethsys reset controller include file
>>
>>  drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
>>  include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
> 
> Any planned DT users in the next merge window? Should I put this
> into a topic branch? Do you want a clk maintainer ack? At the
> least we need someone like James to ack this first.
> 

Hi Stephen,

the addition of the dtsi snippets for the ethernet core is pending due
to this patch. getting it into v4.11 would be geat so that i can sent
dtsi changes during the next merge window.

	John

Re: [PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[Stephen Boyd]

On 01/27, John Crispin wrote:
> 
> 
> On 27/01/2017 01:14, Stephen Boyd wrote:
> > On 01/23, John Crispin wrote:
> >> When the clk code for mt2701 was merged, we forgot to add the reset
> >> controller of the ethernet subsystem. This series adds the missing code
> >> and header files required to reference the bits from within a devicetree
> >> file.
> >>
> >> John Crispin (2):
> >>   clk: mediatek: add mt2701 ethernet reset
> >>   reset: mediatek: Add MT2701 ethsys reset controller include file
> >>
> >>  drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
> >>  include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
> > 
> > Any planned DT users in the next merge window? Should I put this
> > into a topic branch? Do you want a clk maintainer ack? At the
> > least we need someone like James to ack this first.
> > 
> 
> Hi Stephen,
> 
> the addition of the dtsi snippets for the ethernet core is pending due
> to this patch. getting it into v4.11 would be geat so that i can sent
> dtsi changes during the next merge window.
> 

Sorry, I never saw anything from anyone @mediatek so I never did
anything here. I suppose I'll just go and apply this to clk-next
now and then v4.13 can get the ethernet patches?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[Stephen Boyd]

On 01/27, John Crispin wrote:
> 
> 
> On 27/01/2017 01:14, Stephen Boyd wrote:
> > On 01/23, John Crispin wrote:
> >> When the clk code for mt2701 was merged, we forgot to add the reset
> >> controller of the ethernet subsystem. This series adds the missing code
> >> and header files required to reference the bits from within a devicetree
> >> file.
> >>
> >> John Crispin (2):
> >>   clk: mediatek: add mt2701 ethernet reset
> >>   reset: mediatek: Add MT2701 ethsys reset controller include file
> >>
> >>  drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
> >>  include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
> > 
> > Any planned DT users in the next merge window? Should I put this
> > into a topic branch? Do you want a clk maintainer ack? At the
> > least we need someone like James to ack this first.
> > 
> 
> Hi Stephen,
> 
> the addition of the dtsi snippets for the ethernet core is pending due
> to this patch. getting it into v4.11 would be geat so that i can sent
> dtsi changes during the next merge window.
> 

Sorry, I never saw anything from anyone @mediatek so I never did
anything here. I suppose I'll just go and apply this to clk-next
now and then v4.13 can get the ethernet patches?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[John Crispin]

On 19/04/17 19:18, Stephen Boyd wrote:
> On 01/27, John Crispin wrote:
>>
>> On 27/01/2017 01:14, Stephen Boyd wrote:
>>> On 01/23, John Crispin wrote:
>>>> When the clk code for mt2701 was merged, we forgot to add the reset
>>>> controller of the ethernet subsystem. This series adds the missing code
>>>> and header files required to reference the bits from within a devicetree
>>>> file.
>>>>
>>>> John Crispin (2):
>>>>    clk: mediatek: add mt2701 ethernet reset
>>>>    reset: mediatek: Add MT2701 ethsys reset controller include file
>>>>
>>>>   drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
>>>>   include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
>>> Any planned DT users in the next merge window? Should I put this
>>> into a topic branch? Do you want a clk maintainer ack? At the
>>> least we need someone like James to ack this first.
>>>
>> Hi Stephen,
>>
>> the addition of the dtsi snippets for the ethernet core is pending due
>> to this patch. getting it into v4.11 would be geat so that i can sent
>> dtsi changes during the next merge window.
>>
> Sorry, I never saw anything from anyone @mediatek so I never did
> anything here. I suppose I'll just go and apply this to clk-next
> now and then v4.13 can get the ethernet patches?
>
Hi Stephen,

sounds like a plan. i'll add the series to my local pending tree and 
resend stuff during the next merge window if it was not merged by then.

     John

[PATCH 0/2] clk: mediatek: add missing ethernet reset definition

[John Crispin]

On 19/04/17 19:18, Stephen Boyd wrote:
> On 01/27, John Crispin wrote:
>>
>> On 27/01/2017 01:14, Stephen Boyd wrote:
>>> On 01/23, John Crispin wrote:
>>>> When the clk code for mt2701 was merged, we forgot to add the reset
>>>> controller of the ethernet subsystem. This series adds the missing code
>>>> and header files required to reference the bits from within a devicetree
>>>> file.
>>>>
>>>> John Crispin (2):
>>>>    clk: mediatek: add mt2701 ethernet reset
>>>>    reset: mediatek: Add MT2701 ethsys reset controller include file
>>>>
>>>>   drivers/clk/mediatek/clk-mt2701-eth.c     |    2 ++
>>>>   include/dt-bindings/reset/mt2701-resets.h |    7 +++++++
>>> Any planned DT users in the next merge window? Should I put this
>>> into a topic branch? Do you want a clk maintainer ack? At the
>>> least we need someone like James to ack this first.
>>>
>> Hi Stephen,
>>
>> the addition of the dtsi snippets for the ethernet core is pending due
>> to this patch. getting it into v4.11 would be geat so that i can sent
>> dtsi changes during the next merge window.
>>
> Sorry, I never saw anything from anyone @mediatek so I never did
> anything here. I suppose I'll just go and apply this to clk-next
> now and then v4.13 can get the ethernet patches?
>
Hi Stephen,

sounds like a plan. i'll add the series to my local pending tree and 
resend stuff during the next merge window if it was not merged by then.

     John