From: Ludovic BARRE <ludovic.barre@st.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Rob Herring <robh+dt@kernel.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, DTML <devicetree@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com> Subject: Re: [PATCH 3/9] mmc: mmci: add a reference at mmc_host_ops in mmci struct Date: Mon, 27 Jan 2020 11:57:39 +0100 [thread overview] Message-ID: <075935e7-6c26-9baa-72a5-8dbdecef1e8e@st.com> (raw) In-Reply-To: <CAPDyKFpBgRGbRjOKHygknUMvGt9AKke+svoSG+So4B7hdZ8AMw@mail.gmail.com> Le 1/24/20 à 2:09 PM, Ulf Hansson a écrit : > On Fri, 10 Jan 2020 at 14:49, Ludovic Barre <ludovic.barre@st.com> wrote: >> >> This patch adds mmc_host_ops pointer in mmci struct. >> The variant init function may need to add a mmc_host_ops, >> for example to add the execute_tuning support if this feature >> is available. >> >> Signed-off-by: Ludovic Barre <ludovic.barre@st.com> >> --- >> drivers/mmc/host/mmci.c | 1 + >> drivers/mmc/host/mmci.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c >> index 7b13d66cbb21..00b473f57047 100644 >> --- a/drivers/mmc/host/mmci.c >> +++ b/drivers/mmc/host/mmci.c >> @@ -1923,6 +1923,7 @@ static int mmci_probe(struct amba_device *dev, >> >> host = mmc_priv(mmc); >> host->mmc = mmc; >> + host->mmc_ops = &mmci_ops; > > Nitpick: > > Can you please also move the assignment "mmc->ops = &mmci_ops;" to > this place as well, as I think these belongs together. OK > >> >> /* >> * Some variant (STM32) doesn't have opendrain bit, nevertheless >> diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h >> index ea6a0b5779d4..55acc0971a44 100644 >> --- a/drivers/mmc/host/mmci.h >> +++ b/drivers/mmc/host/mmci.h >> @@ -407,6 +407,7 @@ struct mmci_host { >> u32 mask1_reg; >> u8 vqmmc_enabled:1; >> struct mmci_platform_data *plat; >> + struct mmc_host_ops *mmc_ops; >> struct mmci_host_ops *ops; >> struct variant_data *variant; >> struct pinctrl *pinctrl; >> -- >> 2.17.1 >> > > Kind regards > Uffe >
WARNING: multiple messages have this Message-ID (diff)
From: Ludovic BARRE <ludovic.barre@st.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: DTML <devicetree@vger.kernel.org>, Alexandre Torgue <alexandre.torgue@st.com>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, linux-stm32@st-md-mailman.stormreply.com, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 3/9] mmc: mmci: add a reference at mmc_host_ops in mmci struct Date: Mon, 27 Jan 2020 11:57:39 +0100 [thread overview] Message-ID: <075935e7-6c26-9baa-72a5-8dbdecef1e8e@st.com> (raw) In-Reply-To: <CAPDyKFpBgRGbRjOKHygknUMvGt9AKke+svoSG+So4B7hdZ8AMw@mail.gmail.com> Le 1/24/20 à 2:09 PM, Ulf Hansson a écrit : > On Fri, 10 Jan 2020 at 14:49, Ludovic Barre <ludovic.barre@st.com> wrote: >> >> This patch adds mmc_host_ops pointer in mmci struct. >> The variant init function may need to add a mmc_host_ops, >> for example to add the execute_tuning support if this feature >> is available. >> >> Signed-off-by: Ludovic Barre <ludovic.barre@st.com> >> --- >> drivers/mmc/host/mmci.c | 1 + >> drivers/mmc/host/mmci.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c >> index 7b13d66cbb21..00b473f57047 100644 >> --- a/drivers/mmc/host/mmci.c >> +++ b/drivers/mmc/host/mmci.c >> @@ -1923,6 +1923,7 @@ static int mmci_probe(struct amba_device *dev, >> >> host = mmc_priv(mmc); >> host->mmc = mmc; >> + host->mmc_ops = &mmci_ops; > > Nitpick: > > Can you please also move the assignment "mmc->ops = &mmci_ops;" to > this place as well, as I think these belongs together. OK > >> >> /* >> * Some variant (STM32) doesn't have opendrain bit, nevertheless >> diff --git a/drivers/mmc/host/mmci.h b/drivers/mmc/host/mmci.h >> index ea6a0b5779d4..55acc0971a44 100644 >> --- a/drivers/mmc/host/mmci.h >> +++ b/drivers/mmc/host/mmci.h >> @@ -407,6 +407,7 @@ struct mmci_host { >> u32 mask1_reg; >> u8 vqmmc_enabled:1; >> struct mmci_platform_data *plat; >> + struct mmc_host_ops *mmc_ops; >> struct mmci_host_ops *ops; >> struct variant_data *variant; >> struct pinctrl *pinctrl; >> -- >> 2.17.1 >> > > Kind regards > Uffe > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-27 10:58 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-10 13:48 [PATCH 0/9] mmc: mmci: sdmmc: add sdr104 support Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-10 13:48 ` [PATCH 1/9] mmc: mmci: sdmmc: replace sg_dma_xxx macros Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-10 13:48 ` [PATCH 2/9] mmc: mmci: sdmmc: rename sdmmc_priv struct to sdmmc_idma Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-10 13:48 ` [PATCH 3/9] mmc: mmci: add a reference at mmc_host_ops in mmci struct Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 13:09 ` Ulf Hansson 2020-01-24 13:09 ` Ulf Hansson 2020-01-27 10:57 ` Ludovic BARRE [this message] 2020-01-27 10:57 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 4/9] mmc: mmci: add private pointer for variant Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-10 13:48 ` [PATCH 5/9] dt-bindings: mmc: mmci: add delay block base register for sdmmc Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-15 14:56 ` Rob Herring 2020-01-15 14:56 ` Rob Herring 2020-01-16 9:20 ` Ludovic BARRE 2020-01-16 9:20 ` Ludovic BARRE 2020-01-16 14:33 ` Rob Herring 2020-01-16 14:33 ` Rob Herring 2020-01-16 14:52 ` Ludovic BARRE 2020-01-16 14:52 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 6/9] mmc: mmci: sdmmc: add execute tuning with delay block Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 13:10 ` Ulf Hansson 2020-01-24 13:10 ` Ulf Hansson 2020-01-27 13:19 ` Ludovic BARRE 2020-01-27 13:19 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 7/9] mmc: mmci: add volt_switch callbacks Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 13:12 ` Ulf Hansson 2020-01-24 13:12 ` Ulf Hansson 2020-01-27 13:21 ` Ludovic BARRE 2020-01-27 13:21 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 8/9] mmc: mmci: sdmmc: add voltage switch functions Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 13:16 ` Ulf Hansson 2020-01-24 13:16 ` Ulf Hansson 2020-01-27 13:50 ` Ludovic BARRE 2020-01-27 13:50 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 9/9] mmc: mmci: add sdmmc variant revision 2.0 Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 12:55 ` [PATCH 0/9] mmc: mmci: sdmmc: add sdr104 support Ludovic BARRE 2020-01-24 12:55 ` Ludovic BARRE 2020-01-24 13:19 ` Ulf Hansson 2020-01-24 13:19 ` Ulf Hansson 2020-01-27 13:52 ` Ludovic BARRE 2020-01-27 13:52 ` Ludovic BARRE
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=075935e7-6c26-9baa-72a5-8dbdecef1e8e@st.com \ --to=ludovic.barre@st.com \ --cc=alexandre.torgue@st.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.