From: Vlastimil Babka <vbabka@suse.cz>
To: Hyeonggon Yoo <42.hyeyoo@gmail.com>,
David Rientjes <rientjes@google.com>
Cc: linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [QUESTION] is SLAB considered legacy and deprecated?
Date: Mon, 4 Oct 2021 13:39:46 +0200 [thread overview]
Message-ID: <075fde61-8c28-25ec-0ec1-28b1bdea7c95@suse.cz> (raw)
In-Reply-To: <20211004060109.GA2949@linux.asia-northeast3-a.c.our-ratio-313919.internal>
On 10/4/21 08:01, Hyeonggon Yoo wrote:
> On Sun, Oct 03, 2021 at 06:25:29PM -0700, David Rientjes wrote:
>> I would disagree that SLAB isn't currently maintained, I think it's
>> actively maintained.
>
> I thought it was not actively maintained because most of patches were
> fixups and cleanups for years and as Vlastimil said, new features are
Fixups and cleanups still count as "actively maintained". The opposite
case would be "nobody uses it because it was broken for years since
commit X and we only noticed now".
> only added to SLUB. development was focused on SLUB.
>
>> I think the general guidance is that changes for both allocators can still
>> be merged upstream if they show a significant win (improved performnace,
>> maintaining performance while reducing memory footprint, code hygiene,
>> etc) and there's no specific policy that we cannot make changes to
>> mm/slab.c.
>
> Good.
>
> I see things to improve in SLAB and want to improve it.
> I will appreciate if you review them.
It would be great if your motivation started with "I prefer SLAB over
SLUB because X and Y but I need to improve Z", not just a theoretical
concern.
> Thanks,
> Hyeonggon
>
next prev parent reply other threads:[~2021-10-04 11:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 9:03 [QUESTION] is SLAB considered legacy and deprecated? Hyeonggon Yoo
2021-09-27 17:03 ` Vlastimil Babka
2021-09-28 11:12 ` Hyeonggon Yoo
2021-09-29 10:50 ` Hyeonggon Yoo
2021-10-01 14:07 ` Vlastimil Babka
2021-10-03 5:59 ` Hyeonggon Yoo
2021-10-04 1:25 ` David Rientjes
2021-10-04 1:25 ` David Rientjes
2021-10-04 6:01 ` Hyeonggon Yoo
2021-10-04 11:39 ` Vlastimil Babka [this message]
2021-10-05 13:31 ` Hyeonggon Yoo
2021-10-04 11:34 ` Vlastimil Babka
2021-10-04 14:22 ` Hyeonggon Yoo
2021-10-01 0:39 ` Queueing is outside of SLUB nowdays Hyeonggon Yoo
2021-10-04 14:56 ` Christoph Lameter
2021-10-04 14:56 ` Christoph Lameter
2021-10-05 8:19 ` Vlastimil Babka
2021-10-05 14:16 ` Hyeonggon Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=075fde61-8c28-25ec-0ec1-28b1bdea7c95@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.