Re: Queueing is outside of SLUB nowdays

From: Vlastimil Babka <vbabka@suse.cz>
To: Christoph Lameter <cl@gentwo.de>, Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: Queueing is outside of SLUB nowdays
Date: Tue, 5 Oct 2021 10:19:32 +0200	[thread overview]
Message-ID: <09ca489a-ecfb-dd5e-b057-dc9c59c8585e@suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2110041648220.294708@gentwo.de>

On 10/4/21 16:56, Christoph Lameter wrote:
> On Fri, 1 Oct 2021, Hyeonggon Yoo wrote:
> 
>> Looking at other layers, they implemented queuing layer outside of SLUB.
>> See commit 795bb1c00dd ("net: bulk free infrastructure for NAPI context,
>> use napi_consume_skb") for example. They made skb cache because SLUB is
>> not suitable for intensive alloc/free.
>>
>> And because the queue is outside of slab, it can go lockless
>> depending on it's context. (But it's not easy to do so in slab because
>> slab is general purpose allocator.)
> 
> The queuing within in SLUB/SLAB is lockless.
> 
>> So current approach on place where slab's performance is critical
>> is implementing queuing layer on top of slab.
> 
> If you have to use object specific characteristics to optimize then yes
> you can optimize further. However, the slab allocators implement each
> their own form of queuing that is generic.
> 
>> Then new question arising:
>>     - Is that proper way to solve fundamental problem?
> 
> There is a problem?

If someone benefits from implementing a caching layer on top of SL*B, it
probably indicates a problem.

>>       - why not use SLAB if they need queuing?
> 
> SLAB is LIFO queuing whereas SLUB uses spatial considerations and queues
> within a page before going outside.

IIUC SLUB queueing works well for allocation (we just consume a per-cpu
freelist that nobody else can touch) but freeing uses the corresponding
page's freelist so the atomics are more expensive. In both cases the linked
freelists might be also worse for cache locality than an array of pointers.
So perhaps some workload still benefit from a array-based cache on top of
SLUB and it would be great if they didn't have to implement own solutions?

> Slab requires disabling interrupts,
> SLUB is optimized to rely on per cpu atomics and there are numerous other
> differences.
> 
>>       - how does this approach work on SLAB?
> 
> SLAB has a lockless layer that is only requiring disabling interrupts. It
> provides a generic queuing layer as well.
> 
> See my talk on Slab allocators awhile back.
> 
> https://www.youtube.com/watch?v=h0VMLXavx30
> 